[U-Boot] [PATCH] ppc4xx: Fixt initialization of SDRAM_CODT register in ppc_4xx_ddr2.c
This fixes the initialization of the SDRAM_CODT register in the ppc4xx DDR2 initialization code. It also removes the use the SDRAM_CODT_FEEDBACK_RCV_SINGLE_END and SDRAM_CODT_FEEDBACK_DRV_SINGLE_END #define's since they are reserved bits.
Signed-off-by: Carolyn Smith carolyn.smith@tektronix.com --- diff -uprN old/cpu/ppc4xx/44x_spd_ddr2.c new/cpu/ppc4xx/44x_spd_ddr2.c --- old/cpu/ppc4xx/44x_spd_ddr2.c 2009-01-20 13:00:33.000000000 -0800 +++ new/cpu/ppc4xx/44x_spd_ddr2.c 2009-01-28 08:55:44.000000000 -0800 @@ -1104,11 +1104,11 @@ static void program_codt(unsigned long * * Set the SDRAM Controller On Die Termination Register *-----------------------------------------------------------------*/ mfsdram(SDRAM_CODT, codt); - codt |= (SDRAM_CODT_IO_NMODE - & (~SDRAM_CODT_DQS_SINGLE_END - & ~SDRAM_CODT_CKSE_SINGLE_END - & ~SDRAM_CODT_FEEBBACK_RCV_SINGLE_END - & ~SDRAM_CODT_FEEBBACK_DRV_SINGLE_END)); + + codt |= SDRAM_CODT_IO_NMODE; + + codt &= ~(SDRAM_CODT_DQS_SINGLE_END | SDRAM_CODT_CKSE_SINGLE_END); +
for (dimm_num = 0; dimm_num < num_dimm_banks; dimm_num++) { if (dimm_populated[dimm_num] != SDRAM_NONE) {
Dear Carolyn,
In message 2BA6BDB4C941C94BBD8375D55E05CCF9124BE50DEF@us-bv-m12.global.tektronix.net you wrote:
This fixes the initialization of the SDRAM_CODT register in the ppc4xx DDR2 initialization code. It also removes the use the SDRAM_CODT_FEEDBACK_RCV_SINGLE_END and SDRAM_CODT_FEEDBACK_DRV_SINGLE_END #define's since they are reserved bits.
The maximum line length is some 70 characters or so. This goes for the Seubject line (which gets used as tile of the commit message), and for the remainder of the commit message as well.
Your lines ary waaaaaay too long.
This will not be accepted.
Best regards,
Wolfgang Denk
participants (2)
-
carolyn.j.smith＠tektronix.com -
Wolfgang Denk