[U-Boot] [PATCH 1/2] dt: sun8i: Perfect r_pio node of the A83T

From: Ziping Chen techping.chan@gmail.com
Perfect `r_pio` node of the A83T based on `pio` node.
Signed-off-by: Ziping Chen techping.chan@gmail.com --- arch/arm/dts/sun8i-a83t.dtsi | 5 +++++ 1 file changed, 5 insertions(+)
diff --git a/arch/arm/dts/sun8i-a83t.dtsi b/arch/arm/dts/sun8i-a83t.dtsi index 0fe73e173f..128fe954c4 100644 --- a/arch/arm/dts/sun8i-a83t.dtsi +++ b/arch/arm/dts/sun8i-a83t.dtsi @@ -257,6 +257,11 @@ compatible = "allwinner,sun8i-a83t-r-pinctrl"; reg = <0x01f02c00 0x400>; interrupts = <GIC_SPI 45 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&osc24M>; + gpio-controller; + interrupt-controller; + #interrupt-cells = <3>; + #gpio-cells = <3>; }; }; };

From: Ziping Chen techping.chan@gmail.com
The SinA83T is an A83T core/daughter board combo from Sinlinx.
Add support for it.
Signed-off-by: Ziping Chen techping.chan@gmail.com --- arch/arm/dts/Makefile | 3 +- arch/arm/dts/sun8i-a83t-sinlinx-sina83t.dts | 107 ++++++++++++++++++++++++++++ board/sunxi/MAINTAINERS | 6 ++ configs/Sinlinx_SinA83T_defconfig | 21 ++++++ 4 files changed, 136 insertions(+), 1 deletion(-) create mode 100644 arch/arm/dts/sun8i-a83t-sinlinx-sina83t.dts create mode 100644 configs/Sinlinx_SinA83T_defconfig
diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile index 8b8f5e9e76..c0eae9f443 100644 --- a/arch/arm/dts/Makefile +++ b/arch/arm/dts/Makefile @@ -305,7 +305,8 @@ dtb-$(CONFIG_MACH_SUN8I_A33) += \ dtb-$(CONFIG_MACH_SUN8I_A83T) += \ sun8i-a83t-allwinner-h8homlet-v2.dtb \ sun8i-a83t-cubietruck-plus.dtb \ - sun8i-a83t-sinovoip-bpi-m3.dtb + sun8i-a83t-sinovoip-bpi-m3.dtb \ + sun8i-a83t-sinlinx-sina83t.dtb dtb-$(CONFIG_MACH_SUN8I_H3) += \ sun8i-h2-plus-orangepi-zero.dtb \ sun8i-h3-bananapi-m2-plus.dtb \ diff --git a/arch/arm/dts/sun8i-a83t-sinlinx-sina83t.dts b/arch/arm/dts/sun8i-a83t-sinlinx-sina83t.dts new file mode 100644 index 0000000000..ae50e022d4 --- /dev/null +++ b/arch/arm/dts/sun8i-a83t-sinlinx-sina83t.dts @@ -0,0 +1,107 @@ +/* + * Copyright 2017 Ziping Chen + * Ziping Chen techping.chan@gmail.com + * + * This file is dual-licensed: you can use it either under the terms + * of the GPL or the X11 license, at your option. Note that this dual + * licensing only applies to this file, and not this project as a + * whole. + * + * a) This file is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License as + * published by the Free Software Foundation; either version 2 of the + * License, or (at your option) any later version. + * + * This file is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * Or, alternatively, + * + * b) Permission is hereby granted, free of charge, to any person + * obtaining a copy of this software and associated documentation + * files (the "Software"), to deal in the Software without + * restriction, including without limitation the rights to use, + * copy, modify, merge, publish, distribute, sublicense, and/or + * sell copies of the Software, and to permit persons to whom the + * Software is furnished to do so, subject to the following + * conditions: + * + * The above copyright notice and this permission notice shall be + * included in all copies or substantial portions of the Software. + * + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR + * OTHER DEALINGS IN THE SOFTWARE. + */ + +/dts-v1/; +#include "sun8i-a83t.dtsi" +#include "sunxi-common-regulators.dtsi" + +#include <dt-bindings/gpio/gpio.h> +#include <dt-bindings/input/input.h> +#include <dt-bindings/pinctrl/sun4i-a10.h> + +/ { + model = "Sinlinx SinA83T"; + compatible = "sinlinx,sina83t", "allwinner,sun8i-a83t"; + + aliases { + serial0 = &uart0; + }; + + chosen { + stdout-path = "serial0:115200n8"; + }; + + leds { + compatible = "gpio-leds"; + + usr_led { + label = "sinlinx:blue:usr"; + gpios = <&r_pio 0 10 GPIO_ACTIVE_HIGH>; /* PL10 */ + default-state = "on"; + }; + }; +}; + +#define USB_CLASS_HUB 9 + +&ehci0 { + /* USB 2.0 4 port hub IC */ + status = "okay"; + #address-cells = <2>; + #size-cells = <2>; + + hub { + compatible = "usb-hub"; + usb,device-class = <USB_CLASS_HUB>; + #address-cells = <1>; + #size-cells = <0>; + }; +}; + +&ehci1 { + status = "okay"; +}; + +&ohci0 { + status = "okay"; +}; + +&uart0 { + pinctrl-names = "default"; + pinctrl-0 = <&uart0_pins_a>; + status = "okay"; +}; + +&usb_otg { + status = "okay"; +}; diff --git a/board/sunxi/MAINTAINERS b/board/sunxi/MAINTAINERS index 0f1290acc0..d9370f6d63 100644 --- a/board/sunxi/MAINTAINERS +++ b/board/sunxi/MAINTAINERS @@ -299,6 +299,12 @@ S: Maintained F: configs/Sinlinx_SinA33_defconfig W: http://linux-sunxi.org/Sinlinx_SinA33
+SINLINX SINA83T BOARD +M: Ziping Chen techping.chan@gmail.com +S: Maintained +F: configs/Sinlinx_SinA83T_defconfig +W: http://linux-sunxi.org/Sinlinx_SinA83T + SINOVOIP BPI M2 PLUS H3 BOARD M: Icenowy Zheng icenowy@aosc.io S: Maintained diff --git a/configs/Sinlinx_SinA83T_defconfig b/configs/Sinlinx_SinA83T_defconfig new file mode 100644 index 0000000000..d80ac77a58 --- /dev/null +++ b/configs/Sinlinx_SinA83T_defconfig @@ -0,0 +1,21 @@ +CONFIG_ARM=y +CONFIG_ARCH_SUNXI=y +CONFIG_MACH_SUN8I_A83T=y +CONFIG_DRAM_CLK=600 +CONFIG_DRAM_ZQ=15355 +CONFIG_DRAM_ODT_EN=y +CONFIG_MMC_SUNXI_SLOT_EXTRA=2 +CONFIG_AXP_GPIO=y +CONFIG_DEFAULT_DEVICE_TREE="sun8i-a83t-sinlinx-sina83t" +# CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set +CONFIG_SPL=y +# CONFIG_CMD_IMLS is not set +# CONFIG_CMD_FLASH is not set +# CONFIG_CMD_FPGA is not set +# CONFIG_SPL_DOS_PARTITION is not set +# CONFIG_SPL_ISO_PARTITION is not set +# CONFIG_SPL_EFI_PARTITION is not set +CONFIG_AXP_DLDO4_VOLT=3300 +CONFIG_USB_EHCI_HCD=y +CONFIG_USB_OHCI_HCD=y +CONFIG_USB_MUSB_HOST=y

Hi,
On Fri, Jun 09, 2017 at 09:24:19PM +0800, Ziping Chen wrote:
From: Ziping Chen techping.chan@gmail.com
The SinA83T is an A83T core/daughter board combo from Sinlinx.
Add support for it.
Signed-off-by: Ziping Chen techping.chan@gmail.com
arch/arm/dts/Makefile | 3 +- arch/arm/dts/sun8i-a83t-sinlinx-sina83t.dts | 107 ++++++++++++++++++++++++++++ board/sunxi/MAINTAINERS | 6 ++ configs/Sinlinx_SinA83T_defconfig | 21 ++++++ 4 files changed, 136 insertions(+), 1 deletion(-) create mode 100644 arch/arm/dts/sun8i-a83t-sinlinx-sina83t.dts create mode 100644 configs/Sinlinx_SinA83T_defconfig
diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile index 8b8f5e9e76..c0eae9f443 100644 --- a/arch/arm/dts/Makefile +++ b/arch/arm/dts/Makefile @@ -305,7 +305,8 @@ dtb-$(CONFIG_MACH_SUN8I_A33) += \ dtb-$(CONFIG_MACH_SUN8I_A83T) += \ sun8i-a83t-allwinner-h8homlet-v2.dtb \ sun8i-a83t-cubietruck-plus.dtb \
- sun8i-a83t-sinovoip-bpi-m3.dtb
- sun8i-a83t-sinovoip-bpi-m3.dtb \
- sun8i-a83t-sinlinx-sina83t.dtb
DT should be ordered alphabetically, so before the BPi M3.
dtb-$(CONFIG_MACH_SUN8I_H3) += \ sun8i-h2-plus-orangepi-zero.dtb \ sun8i-h3-bananapi-m2-plus.dtb \ diff --git a/arch/arm/dts/sun8i-a83t-sinlinx-sina83t.dts b/arch/arm/dts/sun8i-a83t-sinlinx-sina83t.dts new file mode 100644 index 0000000000..ae50e022d4 --- /dev/null +++ b/arch/arm/dts/sun8i-a83t-sinlinx-sina83t.dts @@ -0,0 +1,107 @@ +/*
- Copyright 2017 Ziping Chen
- Ziping Chen techping.chan@gmail.com
- This file is dual-licensed: you can use it either under the terms
- of the GPL or the X11 license, at your option. Note that this dual
- licensing only applies to this file, and not this project as a
- whole.
- a) This file is free software; you can redistribute it and/or
modify it under the terms of the GNU General Public License as
published by the Free Software Foundation; either version 2 of the
License, or (at your option) any later version.
This file is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
- Or, alternatively,
- b) Permission is hereby granted, free of charge, to any person
obtaining a copy of this software and associated documentation
files (the "Software"), to deal in the Software without
restriction, including without limitation the rights to use,
copy, modify, merge, publish, distribute, sublicense, and/or
sell copies of the Software, and to permit persons to whom the
Software is furnished to do so, subject to the following
conditions:
The above copyright notice and this permission notice shall be
included in all copies or substantial portions of the Software.
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
OTHER DEALINGS IN THE SOFTWARE.
- */
+/dts-v1/; +#include "sun8i-a83t.dtsi" +#include "sunxi-common-regulators.dtsi"
+#include <dt-bindings/gpio/gpio.h> +#include <dt-bindings/input/input.h> +#include <dt-bindings/pinctrl/sun4i-a10.h>
+/ {
- model = "Sinlinx SinA83T";
- compatible = "sinlinx,sina83t", "allwinner,sun8i-a83t";
- aliases {
serial0 = &uart0;
- };
- chosen {
stdout-path = "serial0:115200n8";
- };
- leds {
compatible = "gpio-leds";
usr_led {
label = "sinlinx:blue:usr";
gpios = <&r_pio 0 10 GPIO_ACTIVE_HIGH>; /* PL10 */
default-state = "on";
};
- };
+};
+#define USB_CLASS_HUB 9
+&ehci0 {
- /* USB 2.0 4 port hub IC */
- status = "okay";
- #address-cells = <2>;
- #size-cells = <2>;
- hub {
compatible = "usb-hub";
usb,device-class = <USB_CLASS_HUB>;
#address-cells = <1>;
#size-cells = <0>;
- };
+};
+&ehci1 {
- status = "okay";
+};
+&ohci0 {
- status = "okay";
+};
+&uart0 {
- pinctrl-names = "default";
- pinctrl-0 = <&uart0_pins_a>;
- status = "okay";
+};
+&usb_otg {
- status = "okay";
+};
Can you contribute that DT with Linux first? We share them with Linux, and it should be accepted there first.
Thanks! Maxime

Previously I did not submit the patch to linux because of the missing a83t's DT support of Linux... And I saw Bananapi M3 haven't been supported for Linux, but for U-Boot.
Well, now I will try to fix up the a83t's DT support for Linux, and then submitted it to uboot.
BTW, I found that the U-Boot's DT is a little different from the Linux's DT. Sometime I should adjust the DT file slightly to make it compatible for each other. For exmaple, Linux now uses "sun8i-h3-h5.dtsi" and "sun8i-h3.dtsi" for a h3 device, while U-Boot only uses "sun8i-h3.dtsi".
I would like to say that it is important to keep the consistency of U-Boot's and Linux's DT. And I am very glam to help for these works.
Thanks Ziping Chen
On Jun 10, 2017 12:51 AM, "Maxime Ripard" maxime.ripard@free-electrons.com wrote:
Hi,
On Fri, Jun 09, 2017 at 09:24:19PM +0800, Ziping Chen wrote:
From: Ziping Chen techping.chan@gmail.com
The SinA83T is an A83T core/daughter board combo from Sinlinx.
Add support for it.
Signed-off-by: Ziping Chen techping.chan@gmail.com
arch/arm/dts/Makefile | 3 +- arch/arm/dts/sun8i-a83t-sinlinx-sina83t.dts | 107
++++++++++++++++++++++++++++
board/sunxi/MAINTAINERS | 6 ++ configs/Sinlinx_SinA83T_defconfig | 21 ++++++ 4 files changed, 136 insertions(+), 1 deletion(-) create mode 100644 arch/arm/dts/sun8i-a83t-sinlinx-sina83t.dts create mode 100644 configs/Sinlinx_SinA83T_defconfig
diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile index 8b8f5e9e76..c0eae9f443 100644 --- a/arch/arm/dts/Makefile +++ b/arch/arm/dts/Makefile @@ -305,7 +305,8 @@ dtb-$(CONFIG_MACH_SUN8I_A33) += \ dtb-$(CONFIG_MACH_SUN8I_A83T) += \ sun8i-a83t-allwinner-h8homlet-v2.dtb \ sun8i-a83t-cubietruck-plus.dtb \
sun8i-a83t-sinovoip-bpi-m3.dtb
sun8i-a83t-sinovoip-bpi-m3.dtb \
sun8i-a83t-sinlinx-sina83t.dtb
DT should be ordered alphabetically, so before the BPi M3.
dtb-$(CONFIG_MACH_SUN8I_H3) += \ sun8i-h2-plus-orangepi-zero.dtb \ sun8i-h3-bananapi-m2-plus.dtb \ diff --git a/arch/arm/dts/sun8i-a83t-sinlinx-sina83t.dts
b/arch/arm/dts/sun8i-a83t-sinlinx-sina83t.dts
new file mode 100644 index 0000000000..ae50e022d4 --- /dev/null +++ b/arch/arm/dts/sun8i-a83t-sinlinx-sina83t.dts @@ -0,0 +1,107 @@ +/*
- Copyright 2017 Ziping Chen
- Ziping Chen techping.chan@gmail.com
- This file is dual-licensed: you can use it either under the terms
- of the GPL or the X11 license, at your option. Note that this dual
- licensing only applies to this file, and not this project as a
- whole.
- a) This file is free software; you can redistribute it and/or
modify it under the terms of the GNU General Public License as
published by the Free Software Foundation; either version 2 of
the
License, or (at your option) any later version.
This file is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
- Or, alternatively,
- b) Permission is hereby granted, free of charge, to any person
obtaining a copy of this software and associated documentation
files (the "Software"), to deal in the Software without
restriction, including without limitation the rights to use,
copy, modify, merge, publish, distribute, sublicense, and/or
sell copies of the Software, and to permit persons to whom the
Software is furnished to do so, subject to the following
conditions:
The above copyright notice and this permission notice shall be
included in all copies or substantial portions of the Software.
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
OTHER DEALINGS IN THE SOFTWARE.
- */
+/dts-v1/; +#include "sun8i-a83t.dtsi" +#include "sunxi-common-regulators.dtsi"
+#include <dt-bindings/gpio/gpio.h> +#include <dt-bindings/input/input.h> +#include <dt-bindings/pinctrl/sun4i-a10.h>
+/ {
model = "Sinlinx SinA83T";
compatible = "sinlinx,sina83t", "allwinner,sun8i-a83t";
aliases {
serial0 = &uart0;
};
chosen {
stdout-path = "serial0:115200n8";
};
leds {
compatible = "gpio-leds";
usr_led {
label = "sinlinx:blue:usr";
gpios = <&r_pio 0 10 GPIO_ACTIVE_HIGH>; /* PL10 */
default-state = "on";
};
};
+};
+#define USB_CLASS_HUB 9
+&ehci0 {
/* USB 2.0 4 port hub IC */
status = "okay";
#address-cells = <2>;
#size-cells = <2>;
hub {
compatible = "usb-hub";
usb,device-class = <USB_CLASS_HUB>;
#address-cells = <1>;
#size-cells = <0>;
};
+};
+&ehci1 {
status = "okay";
+};
+&ohci0 {
status = "okay";
+};
+&uart0 {
pinctrl-names = "default";
pinctrl-0 = <&uart0_pins_a>;
status = "okay";
+};
+&usb_otg {
status = "okay";
+};
Can you contribute that DT with Linux first? We share them with Linux, and it should be accepted there first.
Thanks! Maxime
-- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com

On Friday 09 June 2017 11:07 PM, Ziping Chen wrote:
Previously I did not submit the patch to linux because of the missing a83t's DT support of Linux... And I saw Bananapi M3 haven't been supported for Linux, but for U-Boot.
U-Boot has BPI M3, configs/Sinovoip_BPI_M3_defconfig
Well, now I will try to fix up the a83t's DT support for Linux, and then submitted it to uboot.
BTW, I found that the U-Boot's DT is a little different from the Linux's DT. Sometime I should adjust the DT file slightly to make it compatible for each other. For exmaple, Linux now uses "sun8i-h3-h5.dtsi" and "sun8i-h3.dtsi" for a h3 device, while U-Boot only uses "sun8i-h3.dtsi".
Yes, we did some recent addition sun50i-h5.dtsi ie in-line with Linux. So more can add anytime to sync with Linux.
Jagan.
participants (3)
-
Jagan Teki
-
Maxime Ripard
-
Ziping Chen