[PATCH] rpi_4_defconfig: add missing CONFIG_ARCH_FIXUP_FDT_MEMORY
As discussed at https://lore.kernel.org/linux-arm-kernel/b726290c-1038-3771-5187-6ac370bc92c... the defconfig for rpi4 miss CONFIG_ARCH_FIXUP_FDT_MEMORY. Without it, booting with an initrd fail.
Signed-off-by: Corentin Labbe clabbe@baylibre.com --- configs/rpi_4_defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configs/rpi_4_defconfig b/configs/rpi_4_defconfig index 6d148dab07..8540b3c927 100644 --- a/configs/rpi_4_defconfig +++ b/configs/rpi_4_defconfig @@ -7,7 +7,7 @@ CONFIG_ENV_SIZE=0x4000 CONFIG_NR_DRAM_BANKS=2 CONFIG_DISTRO_DEFAULTS=y CONFIG_OF_BOARD_SETUP=y -# CONFIG_ARCH_FIXUP_FDT_MEMORY is not set +CONFIG_ARCH_FIXUP_FDT_MEMORY=y CONFIG_MISC_INIT_R=y # CONFIG_DISPLAY_CPUINFO is not set # CONFIG_DISPLAY_BOARDINFO is not set
On Tue, Mar 31, 2020 at 12:26:35PM +0000, Corentin Labbe wrote:
As discussed at https://lore.kernel.org/linux-arm-kernel/b726290c-1038-3771-5187-6ac370bc92c... the defconfig for rpi4 miss CONFIG_ARCH_FIXUP_FDT_MEMORY. Without it, booting with an initrd fail.
Signed-off-by: Corentin Labbe clabbe@baylibre.com
configs/rpi_4_defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configs/rpi_4_defconfig b/configs/rpi_4_defconfig index 6d148dab07..8540b3c927 100644 --- a/configs/rpi_4_defconfig +++ b/configs/rpi_4_defconfig @@ -7,7 +7,7 @@ CONFIG_ENV_SIZE=0x4000 CONFIG_NR_DRAM_BANKS=2 CONFIG_DISTRO_DEFAULTS=y CONFIG_OF_BOARD_SETUP=y -# CONFIG_ARCH_FIXUP_FDT_MEMORY is not set +CONFIG_ARCH_FIXUP_FDT_MEMORY=y CONFIG_MISC_INIT_R=y # CONFIG_DISPLAY_CPUINFO is not set
# CONFIG_DISPLAY_BOARDINFO is not set
Hello
gentle ping
Regards
Hi Corentin,
On 24/04/2020 14:51, LABBE Corentin wrote:
On Tue, Mar 31, 2020 at 12:26:35PM +0000, Corentin Labbe wrote:
As discussed at https://lore.kernel.org/linux-arm-kernel/b726290c-1038-3771-5187-6ac370bc92c... the defconfig for rpi4 miss CONFIG_ARCH_FIXUP_FDT_MEMORY. Without it, booting with an initrd fail.
Signed-off-by: Corentin Labbe clabbe@baylibre.com
configs/rpi_4_defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configs/rpi_4_defconfig b/configs/rpi_4_defconfig index 6d148dab07..8540b3c927 100644 --- a/configs/rpi_4_defconfig +++ b/configs/rpi_4_defconfig @@ -7,7 +7,7 @@ CONFIG_ENV_SIZE=0x4000 CONFIG_NR_DRAM_BANKS=2 CONFIG_DISTRO_DEFAULTS=y CONFIG_OF_BOARD_SETUP=y -# CONFIG_ARCH_FIXUP_FDT_MEMORY is not set +CONFIG_ARCH_FIXUP_FDT_MEMORY=y CONFIG_MISC_INIT_R=y # CONFIG_DISPLAY_CPUINFO is not set
# CONFIG_DISPLAY_BOARDINFO is not set
Patch looks good, but is there any reason why you don't enable it for rpi_4_32b_defconfig and rpi_arm64_defconfig?
Regards, Matthias
On 09/05/2020 01:18, Matthias Brugger wrote:
Hi Corentin,
On 24/04/2020 14:51, LABBE Corentin wrote:
On Tue, Mar 31, 2020 at 12:26:35PM +0000, Corentin Labbe wrote:
As discussed at https://lore.kernel.org/linux-arm-kernel/b726290c-1038-3771-5187-6ac370bc92c... the defconfig for rpi4 miss CONFIG_ARCH_FIXUP_FDT_MEMORY. Without it, booting with an initrd fail.
Signed-off-by: Corentin Labbe clabbe@baylibre.com
configs/rpi_4_defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configs/rpi_4_defconfig b/configs/rpi_4_defconfig index 6d148dab07..8540b3c927 100644 --- a/configs/rpi_4_defconfig +++ b/configs/rpi_4_defconfig @@ -7,7 +7,7 @@ CONFIG_ENV_SIZE=0x4000 CONFIG_NR_DRAM_BANKS=2 CONFIG_DISTRO_DEFAULTS=y CONFIG_OF_BOARD_SETUP=y -# CONFIG_ARCH_FIXUP_FDT_MEMORY is not set +CONFIG_ARCH_FIXUP_FDT_MEMORY=y CONFIG_MISC_INIT_R=y # CONFIG_DISPLAY_CPUINFO is not set
# CONFIG_DISPLAY_BOARDINFO is not set
Patch looks good, but is there any reason why you don't enable it for rpi_4_32b_defconfig and rpi_arm64_defconfig?
And please add me to the recipients list, otherwise this patches most probably get lost.
Regards, Matthias
Hi Corentin,
On 09/05/2020 01:25, Matthias Brugger wrote:
On 09/05/2020 01:18, Matthias Brugger wrote:
Hi Corentin,
On 24/04/2020 14:51, LABBE Corentin wrote:
On Tue, Mar 31, 2020 at 12:26:35PM +0000, Corentin Labbe wrote:
As discussed at https://lore.kernel.org/linux-arm-kernel/b726290c-1038-3771-5187-6ac370bc92c... the defconfig for rpi4 miss CONFIG_ARCH_FIXUP_FDT_MEMORY. Without it, booting with an initrd fail.
Signed-off-by: Corentin Labbe clabbe@baylibre.com
configs/rpi_4_defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configs/rpi_4_defconfig b/configs/rpi_4_defconfig index 6d148dab07..8540b3c927 100644 --- a/configs/rpi_4_defconfig +++ b/configs/rpi_4_defconfig @@ -7,7 +7,7 @@ CONFIG_ENV_SIZE=0x4000 CONFIG_NR_DRAM_BANKS=2 CONFIG_DISTRO_DEFAULTS=y CONFIG_OF_BOARD_SETUP=y -# CONFIG_ARCH_FIXUP_FDT_MEMORY is not set +CONFIG_ARCH_FIXUP_FDT_MEMORY=y CONFIG_MISC_INIT_R=y # CONFIG_DISPLAY_CPUINFO is not set
# CONFIG_DISPLAY_BOARDINFO is not set
Patch looks good, but is there any reason why you don't enable it for rpi_4_32b_defconfig and rpi_arm64_defconfig?
And please add me to the recipients list, otherwise this patches most probably get lost.
Are you planning to send a new version of the patch which enables the option for all configs?
Regards, Matthias
On Tue, May 12, 2020 at 12:17:25PM +0200, Matthias Brugger wrote:
Hi Corentin,
On 09/05/2020 01:25, Matthias Brugger wrote:
On 09/05/2020 01:18, Matthias Brugger wrote:
Hi Corentin,
On 24/04/2020 14:51, LABBE Corentin wrote:
On Tue, Mar 31, 2020 at 12:26:35PM +0000, Corentin Labbe wrote:
As discussed at https://lore.kernel.org/linux-arm-kernel/b726290c-1038-3771-5187-6ac370bc92c... the defconfig for rpi4 miss CONFIG_ARCH_FIXUP_FDT_MEMORY. Without it, booting with an initrd fail.
Signed-off-by: Corentin Labbe clabbe@baylibre.com
configs/rpi_4_defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configs/rpi_4_defconfig b/configs/rpi_4_defconfig index 6d148dab07..8540b3c927 100644 --- a/configs/rpi_4_defconfig +++ b/configs/rpi_4_defconfig @@ -7,7 +7,7 @@ CONFIG_ENV_SIZE=0x4000 CONFIG_NR_DRAM_BANKS=2 CONFIG_DISTRO_DEFAULTS=y CONFIG_OF_BOARD_SETUP=y -# CONFIG_ARCH_FIXUP_FDT_MEMORY is not set +CONFIG_ARCH_FIXUP_FDT_MEMORY=y CONFIG_MISC_INIT_R=y # CONFIG_DISPLAY_CPUINFO is not set
# CONFIG_DISPLAY_BOARDINFO is not set
Patch looks good, but is there any reason why you don't enable it for rpi_4_32b_defconfig and rpi_arm64_defconfig?
And please add me to the recipients list, otherwise this patches most probably get lost.
Are you planning to send a new version of the patch which enables the option for all configs?
Yes, I will. But note that I didnt tested rpi_4_32b_defconfig. And I am currently unable to test it. If you want it to be tested, could you apply this patch as is, and I will submit the rpi_4_32b_defconfig later.
Regards
On 12/05/2020 13:34, LABBE Corentin wrote:
On Tue, May 12, 2020 at 12:17:25PM +0200, Matthias Brugger wrote:
Hi Corentin,
On 09/05/2020 01:25, Matthias Brugger wrote:
On 09/05/2020 01:18, Matthias Brugger wrote:
Hi Corentin,
On 24/04/2020 14:51, LABBE Corentin wrote:
On Tue, Mar 31, 2020 at 12:26:35PM +0000, Corentin Labbe wrote:
As discussed at https://lore.kernel.org/linux-arm-kernel/b726290c-1038-3771-5187-6ac370bc92c... the defconfig for rpi4 miss CONFIG_ARCH_FIXUP_FDT_MEMORY. Without it, booting with an initrd fail.
Signed-off-by: Corentin Labbe clabbe@baylibre.com
configs/rpi_4_defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configs/rpi_4_defconfig b/configs/rpi_4_defconfig index 6d148dab07..8540b3c927 100644 --- a/configs/rpi_4_defconfig +++ b/configs/rpi_4_defconfig @@ -7,7 +7,7 @@ CONFIG_ENV_SIZE=0x4000 CONFIG_NR_DRAM_BANKS=2 CONFIG_DISTRO_DEFAULTS=y CONFIG_OF_BOARD_SETUP=y -# CONFIG_ARCH_FIXUP_FDT_MEMORY is not set +CONFIG_ARCH_FIXUP_FDT_MEMORY=y CONFIG_MISC_INIT_R=y # CONFIG_DISPLAY_CPUINFO is not set
# CONFIG_DISPLAY_BOARDINFO is not set
Patch looks good, but is there any reason why you don't enable it for rpi_4_32b_defconfig and rpi_arm64_defconfig?
And please add me to the recipients list, otherwise this patches most probably get lost.
Are you planning to send a new version of the patch which enables the option for all configs?
Yes, I will. But note that I didnt tested rpi_4_32b_defconfig. And I am currently unable to test it. If you want it to be tested, could you apply this patch as is, and I will submit the rpi_4_32b_defconfig later.
Ok, please don't forget to submit/test configs/rpi_arm64_defconfig as well.
Regards, Matthias
participants (4)
-
Corentin Labbe -
LABBE Corentin
-
Matthias Brugger -
Matthias Brugger