[U-Boot-Users] [PATCH] mpc83xx: Correct the struct spi8xxx in mpc8xxx_spi.h
The commit 04a9e1180ac76a7bacc15a6fcd95ad839d65bddb cause the 83xx immap broken, so the DMA and PCI will be failed.
The patch fix the struct spi8xxx.
Signed-off-by: Dave Liu daveliu@freescale.com --- include/asm-ppc/immap_83xx.h | 4 ++-- include/asm-ppc/mpc8xxx_spi.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/asm-ppc/immap_83xx.h b/include/asm-ppc/immap_83xx.h index c16a098..023d725 100644 --- a/include/asm-ppc/immap_83xx.h +++ b/include/asm-ppc/immap_83xx.h @@ -388,14 +388,14 @@ typedef struct lbus83xx { * Serial Peripheral Interface */ typedef struct spi83xx { + u8 res0[0x20]; u32 mode; /* mode register */ u32 event; /* event register */ u32 mask; /* mask register */ u32 com; /* command register */ - u8 res0[0x10]; u32 tx; /* transmit register */ u32 rx; /* receive register */ - u8 res1[0xFD8]; + u8 res1[0xFC8]; } spi83xx_t;
/* diff --git a/include/asm-ppc/mpc8xxx_spi.h b/include/asm-ppc/mpc8xxx_spi.h index 053d11e..48b15e4 100644 --- a/include/asm-ppc/mpc8xxx_spi.h +++ b/include/asm-ppc/mpc8xxx_spi.h @@ -40,7 +40,7 @@ typedef struct spi8xxx { u32 com; /* command register */ u32 tx; /* transmit register */ u32 rx; /* receive register */ - u8 res1[0xC8]; /* fill up to 0x100 */ + u8 res1[0xFC8]; /* fill up to 0x1000 */ } spi8xxx_t;
#endif
Dave Liu wrote:
The commit 04a9e1180ac76a7bacc15a6fcd95ad839d65bddb cause the 83xx immap broken, so the DMA and PCI will be failed.
The patch fix the struct spi8xxx.
Signed-off-by: Dave Liu daveliu@freescale.com
include/asm-ppc/immap_83xx.h | 4 ++-- include/asm-ppc/mpc8xxx_spi.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/asm-ppc/immap_83xx.h b/include/asm-ppc/immap_83xx.h index c16a098..023d725 100644 --- a/include/asm-ppc/immap_83xx.h +++ b/include/asm-ppc/immap_83xx.h @@ -388,14 +388,14 @@ typedef struct lbus83xx {
- Serial Peripheral Interface
*/ typedef struct spi83xx {
- u8 res0[0x20]; u32 mode; /* mode register */ u32 event; /* event register */ u32 mask; /* mask register */ u32 com; /* command register */
- u8 res0[0x10]; u32 tx; /* transmit register */ u32 rx; /* receive register */
- u8 res1[0xFD8];
- u8 res1[0xFC8];
} spi83xx_t;
BTW - this one isn't used anywhere. We should probably remove it from this file. Not urgent, though.
regards, Ben
On Thu, 17 Jan 2008 22:09:24 -0500 Ben Warren biggerbadderben@gmail.com wrote:
Dave Liu wrote:
The commit 04a9e1180ac76a7bacc15a6fcd95ad839d65bddb cause the 83xx immap broken, so the DMA and PCI will be failed.
The patch fix the struct spi8xxx.
Signed-off-by: Dave Liu daveliu@freescale.com
<snip>
BTW - this one isn't used anywhere. We should probably remove it from this file. Not urgent, though.
I've applied Dave's patch (thanks Dave), and amended it to rm struct 83xxspi and pushed my tree.
Hopefully WD hasn't pulled it yet. In any case, we'll see what happens.
here's the resulting diff:
diff --git a/include/asm-ppc/immap_83xx.h b/include/asm-ppc/immap_83xx.h index c16a098..5b21539 100644 --- a/include/asm-ppc/immap_83xx.h +++ b/include/asm-ppc/immap_83xx.h @@ -385,20 +385,6 @@ typedef struct lbus83xx { } lbus83xx_t;
/* - * Serial Peripheral Interface - */ -typedef struct spi83xx { - u32 mode; /* mode register */ - u32 event; /* event register */ - u32 mask; /* mask register */ - u32 com; /* command register */ - u8 res0[0x10]; - u32 tx; /* transmit register */ - u32 rx; /* receive register */ - u8 res1[0xFD8]; -} spi83xx_t; - -/* * DMA/Messaging Unit */ typedef struct dma83xx { diff --git a/include/asm-ppc/mpc8xxx_spi.h b/include/asm-ppc/mpc8xxx_spi.h index 053d11e..48b15e4 100644 --- a/include/asm-ppc/mpc8xxx_spi.h +++ b/include/asm-ppc/mpc8xxx_spi.h @@ -40,7 +40,7 @@ typedef struct spi8xxx { u32 com; /* command register */ u32 tx; /* transmit register */ u32 rx; /* receive register */ - u8 res1[0xC8]; /* fill up to 0x100 */ + u8 res1[0xFC8]; /* fill up to 0x1000 */ } spi8xxx_t;
#endif
Kim
Kim Phillips wrote:
On Thu, 17 Jan 2008 22:09:24 -0500 Ben Warren biggerbadderben@gmail.com wrote:
Dave Liu wrote:
The commit 04a9e1180ac76a7bacc15a6fcd95ad839d65bddb cause the 83xx immap broken, so the DMA and PCI will be failed.
The patch fix the struct spi8xxx.
Signed-off-by: Dave Liu daveliu@freescale.com
<snip>
BTW - this one isn't used anywhere. We should probably remove it from this file. Not urgent, though.
I've applied Dave's patch (thanks Dave), and amended it to rm struct 83xxspi and pushed my tree.
Hopefully WD hasn't pulled it yet. In any case, we'll see what happens.
Fantastic - looks good. Thanks Kim & Dave.
regards, Ben
Hi, I have a question regarding the various version of u-boot.
Is there a page that you can point me to that holds like a release note or something that tells me what's different from the previous release. I tried looking http://www.denx.de/wiki/UBoot/WebHome but couldn't find anything. here are the version that i'm evaluating.
1.1.3 1.1.4 1.1.5 1.1.6 1.2.0 1.3.0 1.3.1
Any insight would be appreciated. Thanks Kunal _________________________________________________________________ Helping your favorite cause is as easy as instant messaging. You IM, we give. http://im.live.com/Messenger/IM/Home/?source=text_hotmail_join
k b wrote:
Hi, I have a question regarding the various version of u-boot.
Is there a page that you can point me to that holds like a release note or something that tells me what's different from the previous release. I tried looking http://www.denx.de/wiki/UBoot/WebHome but couldn't find anything. here are the version that i'm evaluating.
1.1.3 1.1.4 1.1.5 1.1.6 1.2.0 1.3.0 1.3.1
Any insight would be appreciated. Thanks Kunal
You have not given us any criteria that you are evaluating on. Unless you have a very specific reason for not using the tip of the tree, that is the version to use.
The more recent versions of u-boot fix bugs or limitations of the previous versions, are generally very compatible with previous versions, and are all very stable. The result is that the latest source is always the best choice.
To be specific: none of the above, but rather git clone git://www.denx.de/git/u-boot.git
U-boot is like Commissioner Dreyfus in "The Pink Panther Strikes Again." "Every day and in every way, I am getting better and better." http://www.imdb.com/title/tt0075066/quotes
Best regards, gvb
Gerald, Thanks for your response.
I have had a 1.1.3 running on a board for 3+ yrs now, and i might add with any problems. Now as I'm moving to a newer version of the board I'm evaluating the effort level vs extra features that newer version of uboot gets me. hence the reason of finding out whats in the newer version of u-boot.
So to reiterate where can i find this information about feature/bug fixes per release. Thanks Kunal
Date: Fri, 18 Jan 2008 15:06:51 -0500 From: gerald.vanbaren@ge.com To: k_bisla@hotmail.com CC: u-boot-users@lists.sourceforge.net Subject: Re: [U-Boot-Users] U-Boot versions
k b wrote:
Hi, I have a question regarding the various version of u-boot.
Is there a page that you can point me to that holds like a release note or something that tells me what's different from the previous release. I tried looking http://www.denx.de/wiki/UBoot/WebHome but couldn't find anything. here are the version that i'm evaluating.
1.1.3 1.1.4 1.1.5 1.1.6 1.2.0 1.3.0 1.3.1
Any insight would be appreciated. Thanks Kunal
You have not given us any criteria that you are evaluating on. Unless you have a very specific reason for not using the tip of the tree, that is the version to use.
The more recent versions of u-boot fix bugs or limitations of the previous versions, are generally very compatible with previous versions, and are all very stable. The result is that the latest source is always the best choice.
To be specific: none of the above, but rather git clone git://www.denx.de/git/u-boot.git
U-boot is like Commissioner Dreyfus in "The Pink Panther Strikes Again." "Every day and in every way, I am getting better and better."
Best regards, gvb
This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
_________________________________________________________________ Connect and share in new ways with Windows Live. http://www.windowslive.com/share.html?ocid=TXT_TAGHM_Wave2_sharelife_012008
k b wrote:
Gerald, Thanks for your response.
I have had a 1.1.3 running on a board for 3+ yrs now, and i might add with any problems. Now as I'm moving to a newer version of the board I'm evaluating the effort level vs extra features that newer version of uboot gets me. hence the reason of finding out whats in the newer version of u-boot.
So to reiterate where can i find this information about feature/bug fixes per release. Thanks Kunal
Hi Kunal,
Short answer: Lots. What are you looking for?
Long answer: git log grep -A 2 U_BOOT_CMD common/cmd*.c
You can also read the CHANGELOG in the top u-boot directory. The changelog is split into one prior to 1.1.5 which was manually maintained and the recent one which is generated from git log.
You will likely find that none of the above is a satisfactory answer. The problem is, u-boot is driven by individuals "scratching their itches" so it is a rolling, moving target that keeps getting features added to it. Nobody really cares what features were in the last version, they care about whether the current version they are using meets their needs.
Are you are happy with your current 1.1.3 version? I'm assuming that isn't the case, since you are asking this question.
What capabilities are you looking for that 1.1.3 doesn't have? If you ask specific questions, you will be more likely to get specific answers. Also, let us know what processor and board you are using.
Best regards, gvb
participants (6)
-
Ben Warren -
Dave Liu -
gvb.uboot -
Jerry Van Baren -
k b -
Kim Phillips