[U-Boot] [PATCH] MAKEALL: display SPL size if present

This makes it easier to detect changes in the SPL portion, as can currently be done for the main U-Boot image.
Signed-off-by: Scott Wood scottwood@freescale.com --- MAKEALL | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/MAKEALL b/MAKEALL index f735af6..395e982 100755 --- a/MAKEALL +++ b/MAKEALL @@ -508,6 +508,11 @@ build_target() {
${CROSS_COMPILE}size ${BUILD_DIR}/u-boot \ | tee -a ${LOG_DIR}/$target.MAKELOG + + if [ -e ${BUILD_DIR}/spl/u-boot-spl ]; then + ${CROSS_COMPILE}size ${BUILD_DIR}/spl/u-boot-spl \ + | tee -a ${LOG_DIR}/$target.MAKELOG + fi } build_targets() { for t in "$@" ; do

Dear Scott Wood,
In message 20120105231610.GA10980@schlenkerla.am.freescale.net you wrote:
This makes it easier to detect changes in the SPL portion, as can currently be done for the main U-Boot image.
Signed-off-by: Scott Wood scottwood@freescale.com
MAKEALL | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/MAKEALL b/MAKEALL index f735af6..395e982 100755 --- a/MAKEALL +++ b/MAKEALL @@ -508,6 +508,11 @@ build_target() {
${CROSS_COMPILE}size ${BUILD_DIR}/u-boot \ | tee -a ${LOG_DIR}/$target.MAKELOG
- if [ -e ${BUILD_DIR}/spl/u-boot-spl ]; then
${CROSS_COMPILE}size ${BUILD_DIR}/spl/u-boot-spl \
| tee -a ${LOG_DIR}/$target.MAKELOG
- fi
Can we please combine this into a single call to "size"?
Thanks.
Best regards,
Wolfgang Denk

This makes it easier to detect changes in the SPL portion, as can currently be done for the main U-Boot image.
Signed-off-by: Scott Wood scottwood@freescale.com --- v2: Only invoke size once.
MAKEALL | 8 ++++++-- 1 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/MAKEALL b/MAKEALL index 0f2b4a1..c33be1d 100755 --- a/MAKEALL +++ b/MAKEALL @@ -511,8 +511,12 @@ build_target() {
TOTAL_CNT=$((TOTAL_CNT + 1))
- ${CROSS_COMPILE}size ${BUILD_DIR}/u-boot \ - | tee -a ${LOG_DIR}/$target.MAKELOG + OBJS=${BUILD_DIR}/u-boot + if [ -e ${BUILD_DIR}/spl/u-boot-spl ]; then + OBJS="${OBJS} ${BUILD_DIR}/spl/u-boot-spl" + fi + + ${CROSS_COMPILE}size ${OBJS} | tee -a ${LOG_DIR}/$target.MAKELOG } build_targets() { for t in "$@" ; do

On Mon, Feb 20, 2012 at 3:56 PM, Scott Wood scottwood@freescale.com wrote:
This makes it easier to detect changes in the SPL portion, as can currently be done for the main U-Boot image.
Signed-off-by: Scott Wood scottwood@freescale.com
Acked-by: Tom Rini trini@ti.com

Hello Scott,
On Mon, 20 Feb 2012 16:56:25 -0600 Scott Wood scottwood@freescale.com wrote:
This makes it easier to detect changes in the SPL portion, as can currently be done for the main U-Boot image.
Signed-off-by: Scott Wood scottwood@freescale.com
v2: Only invoke size once.
MAKEALL | 8 ++++++-- 1 files changed, 6 insertions(+), 2 deletions(-)
Applied to u-boot-staging/agust@denx.de. Thanks.
Anatolij
participants (4)
-
Anatolij Gustschin
-
Scott Wood
-
Tom Rini
-
Wolfgang Denk