[U-Boot] [PATCH] pci: imx: display message if no pcie link
If CONFIG_PCI_SCAN_SHOW enabled then lets print a message of no link was detected.
Signed-off-by: Tim Harvey tharvey@gateworks.com --- drivers/pci/pcie_imx.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/pci/pcie_imx.c b/drivers/pci/pcie_imx.c index fd7e4d4..ca485ba 100644 --- a/drivers/pci/pcie_imx.c +++ b/drivers/pci/pcie_imx.c @@ -588,7 +588,9 @@ static int imx_pcie_link_up(void) udelay(10); count++; if (count >= 2000) { - debug("phy link never came up\n"); +#ifdef CONFIG_PCI_SCAN_SHOW + puts("PCI: pcie phy link never came up\n"); +#endif debug("DEBUG_R0: 0x%08x, DEBUG_R1: 0x%08x\n", readl(MX6_DBI_ADDR + PCIE_PHY_DEBUG_R0), readl(MX6_DBI_ADDR + PCIE_PHY_DEBUG_R1));
On Fri, May 08, 2015 at 03:17:10PM -0700, Tim Harvey wrote:
If CONFIG_PCI_SCAN_SHOW enabled then lets print a message of no link was detected.
Signed-off-by: Tim Harvey tharvey@gateworks.com
drivers/pci/pcie_imx.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
Why was this and another PCI patch assigned to me in patchwork (I've since cleared the delegation)?
-Scott
On Fri, May 22, 2015 at 1:50 PM, Scott Wood scottwood@freescale.com wrote:
On Fri, May 08, 2015 at 03:17:10PM -0700, Tim Harvey wrote:
If CONFIG_PCI_SCAN_SHOW enabled then lets print a message of no link was detected.
Signed-off-by: Tim Harvey tharvey@gateworks.com
drivers/pci/pcie_imx.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
Why was this and another PCI patch assigned to me in patchwork (I've since cleared the delegation)?
-Scott
Scott,
Just lucky I guess ;P
Who is the right person to send this to? If a subsection doesn't have a clear maintainer like drivers/pci would it be Tom?
Tim
On Fri, May 22, 2015 at 03:50:39PM -0500, Scott Wood wrote:
On Fri, May 08, 2015 at 03:17:10PM -0700, Tim Harvey wrote:
If CONFIG_PCI_SCAN_SHOW enabled then lets print a message of no link was detected.
Signed-off-by: Tim Harvey tharvey@gateworks.com
drivers/pci/pcie_imx.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
Why was this and another PCI patch assigned to me in patchwork (I've since cleared the delegation)?
I probably typo'd "sb" as "sc" when doing my triage. Did you have any other imx related patches by chance?
On Fri, 2015-05-22 at 17:26 -0400, Tom Rini wrote:
On Fri, May 22, 2015 at 03:50:39PM -0500, Scott Wood wrote:
On Fri, May 08, 2015 at 03:17:10PM -0700, Tim Harvey wrote:
If CONFIG_PCI_SCAN_SHOW enabled then lets print a message of no link was detected.
Signed-off-by: Tim Harvey tharvey@gateworks.com
drivers/pci/pcie_imx.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
Why was this and another PCI patch assigned to me in patchwork (I've since cleared the delegation)?
I probably typo'd "sb" as "sc" when doing my triage. Did you have any other imx related patches by chance?
Just the two PCI patches and some SPI MTD patches.
-Scott
On Fri, May 8, 2015 at 3:17 PM, Tim Harvey tharvey@gateworks.com wrote:
If CONFIG_PCI_SCAN_SHOW enabled then lets print a message of no link was detected.
Signed-off-by: Tim Harvey tharvey@gateworks.com
drivers/pci/pcie_imx.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/pci/pcie_imx.c b/drivers/pci/pcie_imx.c index fd7e4d4..ca485ba 100644 --- a/drivers/pci/pcie_imx.c +++ b/drivers/pci/pcie_imx.c @@ -588,7 +588,9 @@ static int imx_pcie_link_up(void) udelay(10); count++; if (count >= 2000) {
debug("phy link never came up\n");+#ifdef CONFIG_PCI_SCAN_SHOW
puts("PCI: pcie phy link never came up\n");+#endif debug("DEBUG_R0: 0x%08x, DEBUG_R1: 0x%08x\n", readl(MX6_DBI_ADDR + PCIE_PHY_DEBUG_R0), readl(MX6_DBI_ADDR + PCIE_PHY_DEBUG_R1)); -- 1.9.1
Stefano,
I probably should have sent this one to you directly being an imx driver.
Regards,
Tim
Hi Tim,
On 27/05/2015 15:21, Tim Harvey wrote:
On Fri, May 8, 2015 at 3:17 PM, Tim Harvey tharvey@gateworks.com wrote:
If CONFIG_PCI_SCAN_SHOW enabled then lets print a message of no link was detected.
Signed-off-by: Tim Harvey tharvey@gateworks.com
drivers/pci/pcie_imx.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/pci/pcie_imx.c b/drivers/pci/pcie_imx.c index fd7e4d4..ca485ba 100644 --- a/drivers/pci/pcie_imx.c +++ b/drivers/pci/pcie_imx.c @@ -588,7 +588,9 @@ static int imx_pcie_link_up(void) udelay(10); count++; if (count >= 2000) {
debug("phy link never came up\n");+#ifdef CONFIG_PCI_SCAN_SHOW
puts("PCI: pcie phy link never came up\n");+#endif debug("DEBUG_R0: 0x%08x, DEBUG_R1: 0x%08x\n", readl(MX6_DBI_ADDR + PCIE_PHY_DEBUG_R0), readl(MX6_DBI_ADDR + PCIE_PHY_DEBUG_R1)); -- 1.9.1
Stefano,
I probably should have sent this one to you directly being an imx driver.
I have seen the patch and the related discussion who should take care of it ;-)
Do not worry - I set myself as delegate for this and I will merge it soon.
Best regards, Stefano Babic
On 09/05/2015 00:17, Tim Harvey wrote:
If CONFIG_PCI_SCAN_SHOW enabled then lets print a message of no link was detected.
Signed-off-by: Tim Harvey tharvey@gateworks.com
drivers/pci/pcie_imx.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/pci/pcie_imx.c b/drivers/pci/pcie_imx.c index fd7e4d4..ca485ba 100644 --- a/drivers/pci/pcie_imx.c +++ b/drivers/pci/pcie_imx.c @@ -588,7 +588,9 @@ static int imx_pcie_link_up(void) udelay(10); count++; if (count >= 2000) {
debug("phy link never came up\n");+#ifdef CONFIG_PCI_SCAN_SHOW
puts("PCI: pcie phy link never came up\n");+#endif debug("DEBUG_R0: 0x%08x, DEBUG_R1: 0x%08x\n", readl(MX6_DBI_ADDR + PCIE_PHY_DEBUG_R0), readl(MX6_DBI_ADDR + PCIE_PHY_DEBUG_R1));
Applied to u-boot-imx, thanks !
Best regards, Stefano Babic
participants (4)
-
Scott Wood -
Stefano Babic -
Tim Harvey -
Tom Rini