[PATCH] smbios: address build warning
From: Peng Fan peng.fan@nxp.com
include display_options.h to address build warning: lib/smbios.c: In function ‘smbios_update_version’: lib/smbios.c:305:9: warning: implicit declaration of function ‘print_buffer’ [-Wimplicit-function-declaration] print_buffer((ulong)ptr, ptr, 1, old_len + 1, 0); ^~~~~~~~~~~~
Signed-off-by: Peng Fan peng.fan@nxp.com --- lib/smbios.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/lib/smbios.c b/lib/smbios.c index a36d4b4e54a..defb6b42f45 100644 --- a/lib/smbios.c +++ b/lib/smbios.c @@ -7,6 +7,7 @@
#define LOG_CATEGORY LOGC_BOARD
+#include <display_options.h> #include <dm.h> #include <env.h> #include <linux/stringify.h>
On 03.12.24 14:42, Peng Fan (OSS) wrote:
From: Peng Fan peng.fan@nxp.com
include display_options.h to address build warning:
build warning occurring with CONFIG_LOG=y
lib/smbios.c: In function ‘smbios_update_version’: lib/smbios.c:305:9: warning: implicit declaration of function ‘print_buffer’ [-Wimplicit-function-declaration] print_buffer((ulong)ptr, ptr, 1, old_len + 1, 0); ^~~~~~~~~~~~
Signed-off-by: Peng Fan peng.fan@nxp.com
Reviewed-by: Heinrich Schuchardt xypron.glpk@gmx.de
lib/smbios.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/lib/smbios.c b/lib/smbios.c index a36d4b4e54a..defb6b42f45 100644 --- a/lib/smbios.c +++ b/lib/smbios.c @@ -7,6 +7,7 @@
#define LOG_CATEGORY LOGC_BOARD
+#include <display_options.h> #include <dm.h> #include <env.h> #include <linux/stringify.h>
Subject: Re: [PATCH] smbios: address build warning
On 03.12.24 14:42, Peng Fan (OSS) wrote:
From: Peng Fan peng.fan@nxp.com
include display_options.h to address build warning:
build warning occurring with CONFIG_LOG=y
lib/smbios.c: In function ‘smbios_update_version’: lib/smbios.c:305:9: warning: implicit declaration of function
‘print_buffer’
[-Wimplicit-function-declaration] print_buffer((ulong)ptr, ptr, 1, old_len + 1, 0); ^~~~~~~~~~~~
Signed-off-by: Peng Fan peng.fan@nxp.com
Reviewed-by: Heinrich Schuchardt xypron.glpk@gmx.de
Thanks, please let me know whether I need to post V2 to update commit log to include "build warning occurring with CONFIG_LOG=y", or Maintainers could help update when apply the patch.
Thanks, Peng.
lib/smbios.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/lib/smbios.c b/lib/smbios.c index a36d4b4e54a..defb6b42f45 100644 --- a/lib/smbios.c +++ b/lib/smbios.c @@ -7,6 +7,7 @@
#define LOG_CATEGORY LOGC_BOARD
+#include <display_options.h> #include <dm.h> #include <env.h> #include <linux/stringify.h>
On 03.12.24 14:16, Peng Fan wrote:
Subject: Re: [PATCH] smbios: address build warning
On 03.12.24 14:42, Peng Fan (OSS) wrote:
From: Peng Fan peng.fan@nxp.com
include display_options.h to address build warning:
build warning occurring with CONFIG_LOG=y
lib/smbios.c: In function ‘smbios_update_version’: lib/smbios.c:305:9: warning: implicit declaration of function
‘print_buffer’
[-Wimplicit-function-declaration] print_buffer((ulong)ptr, ptr, 1, old_len + 1, 0); ^~~~~~~~~~~~
Signed-off-by: Peng Fan peng.fan@nxp.com
Reviewed-by: Heinrich Schuchardt xypron.glpk@gmx.de
Thanks, please let me know whether I need to post V2 to update commit log to include "build warning occurring with CONFIG_LOG=y", or Maintainers could help update when apply the patch.
Thanks, Peng.
To me the patch is ok as is. I was just wondering, why we did not see the issue in CI.
Best regards
Heinrich
lib/smbios.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/lib/smbios.c b/lib/smbios.c index a36d4b4e54a..defb6b42f45 100644 --- a/lib/smbios.c +++ b/lib/smbios.c @@ -7,6 +7,7 @@
#define LOG_CATEGORY LOGC_BOARD
+#include <display_options.h> #include <dm.h> #include <env.h> #include <linux/stringify.h>
On Tue, 3 Dec 2024 at 14:38, Peng Fan (OSS) peng.fan@oss.nxp.com wrote:
From: Peng Fan peng.fan@nxp.com
include display_options.h to address build warning: lib/smbios.c: In function ‘smbios_update_version’: lib/smbios.c:305:9: warning: implicit declaration of function ‘print_buffer’ [-Wimplicit-function-declaration] print_buffer((ulong)ptr, ptr, 1, old_len + 1, 0); ^~~~~~~~~~~~
Signed-off-by: Peng Fan peng.fan@nxp.com
lib/smbios.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/lib/smbios.c b/lib/smbios.c index a36d4b4e54a..defb6b42f45 100644 --- a/lib/smbios.c +++ b/lib/smbios.c @@ -7,6 +7,7 @@
#define LOG_CATEGORY LOGC_BOARD
+#include <display_options.h> #include <dm.h> #include <env.h>
#include <linux/stringify.h>
2.35.3
Reviewed-by: Ilias Apalodimas ilias.apalodimas@linaro.org
On Tue, 03 Dec 2024 21:42:57 +0800, Peng Fan (OSS) wrote:
include display_options.h to address build warning: lib/smbios.c: In function ‘smbios_update_version’: lib/smbios.c:305:9: warning: implicit declaration of function ‘print_buffer’ [-Wimplicit-function-declaration] print_buffer((ulong)ptr, ptr, 1, old_len + 1, 0); ^~~~~~~~~~~~
[...]
Applied to u-boot/next, thanks!
participants (5)
-
Heinrich Schuchardt -
Ilias Apalodimas -
Peng Fan -
Peng Fan (OSS) -
Tom Rini