[U-Boot] [PATCH] mx28: Show CPU frequency
Showing CPU frequency during boot is useful information.
Signed-off-by: Fabio Estevam fabio.estevam@freescale.com --- arch/arm/cpu/arm926ejs/mx28/mx28.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/arch/arm/cpu/arm926ejs/mx28/mx28.c b/arch/arm/cpu/arm926ejs/mx28/mx28.c index da90360..683777f 100644 --- a/arch/arm/cpu/arm926ejs/mx28/mx28.c +++ b/arch/arm/cpu/arm926ejs/mx28/mx28.c @@ -169,7 +169,8 @@ int arch_cpu_init(void) #if defined(CONFIG_DISPLAY_CPUINFO) int print_cpuinfo(void) { - printf("Freescale i.MX28 family\n"); + printf("Freescale i.MX28 family at %d MHz\n", + mxc_get_clock(MXC_ARM_CLK) / 1000000); return 0; } #endif
Showing CPU frequency during boot is useful information.
Signed-off-by: Fabio Estevam fabio.estevam@freescale.com
arch/arm/cpu/arm926ejs/mx28/mx28.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/arch/arm/cpu/arm926ejs/mx28/mx28.c b/arch/arm/cpu/arm926ejs/mx28/mx28.c index da90360..683777f 100644 --- a/arch/arm/cpu/arm926ejs/mx28/mx28.c +++ b/arch/arm/cpu/arm926ejs/mx28/mx28.c @@ -169,7 +169,8 @@ int arch_cpu_init(void) #if defined(CONFIG_DISPLAY_CPUINFO) int print_cpuinfo(void) {
- printf("Freescale i.MX28 family\n");
- printf("Freescale i.MX28 family at %d MHz\n",
mxc_get_clock(MXC_ARM_CLK) / 1000000);} #endif
Just put it amongst the other frequencies displayed by the clock command.
On 1/23/12, Marek Vasut marek.vasut@gmail.com wrote:
Just put it amongst the other frequencies displayed by the clock command.
What about this?
--- a/arch/arm/cpu/arm926ejs/mx28/mx28.c +++ b/arch/arm/cpu/arm926ejs/mx28/mx28.c @@ -170,6 +170,7 @@ int arch_cpu_init(void) int print_cpuinfo(void) { printf("Freescale i.MX28 family\n"); + do_mx28_showclocks(); return 0; } #endif
It will print a lot more info though.
Regards,
Fabio Estevam
On 23/01/2012 16:52, Fabio Estevam wrote:
On 1/23/12, Marek Vasut marek.vasut@gmail.com wrote:
Just put it amongst the other frequencies displayed by the clock command.
What about this?
--- a/arch/arm/cpu/arm926ejs/mx28/mx28.c +++ b/arch/arm/cpu/arm926ejs/mx28/mx28.c @@ -170,6 +170,7 @@ int arch_cpu_init(void) int print_cpuinfo(void) { printf("Freescale i.MX28 family\n");
do_mx28_showclocks(); return 0;} #endif
It will print a lot more info though.
Well, this is the reason we have a separate function / command (clocks) that can be called only when needed. Generally, we avoid to print too much information if they are not required and can slow down the boot process.
In print_cpuinfo() we output the processor type, the revision if it is available and maybe the processor frequency - nothing more. And if we need a complete overview of the clocks, there is the "clocks" command.
So really I prefer the patch as it is - the information printed are the same as for other SOCs, not only i.MX.
Best regards, Stefano Babic
On 23/01/2012 16:52, Fabio Estevam wrote:
On 1/23/12, Marek Vasut marek.vasut@gmail.com wrote:
Just put it amongst the other frequencies displayed by the clock command.
What about this?
--- a/arch/arm/cpu/arm926ejs/mx28/mx28.c +++ b/arch/arm/cpu/arm926ejs/mx28/mx28.c @@ -170,6 +170,7 @@ int arch_cpu_init(void)
int print_cpuinfo(void) {
printf("Freescale i.MX28 family\n");
do_mx28_showclocks(); return 0;} #endif
It will print a lot more info though.
Well, this is the reason we have a separate function / command (clocks) that can be called only when needed. Generally, we avoid to print too much information if they are not required and can slow down the boot process.
In print_cpuinfo() we output the processor type, the revision if it is available and maybe the processor frequency - nothing more. And if we need a complete overview of the clocks, there is the "clocks" command.
So really I prefer the patch as it is - the information printed are the same as for other SOCs, not only i.MX.
Best regards, Stefano Babic
Ok, fine by me then.
Acked-by: Marek Vasut marek.vasut@gmail.com
M
On 23/01/2012 03:38, Fabio Estevam wrote:
Showing CPU frequency during boot is useful information.
Signed-off-by: Fabio Estevam fabio.estevam@freescale.com
arch/arm/cpu/arm926ejs/mx28/mx28.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/arch/arm/cpu/arm926ejs/mx28/mx28.c b/arch/arm/cpu/arm926ejs/mx28/mx28.c index da90360..683777f 100644 --- a/arch/arm/cpu/arm926ejs/mx28/mx28.c +++ b/arch/arm/cpu/arm926ejs/mx28/mx28.c @@ -169,7 +169,8 @@ int arch_cpu_init(void) #if defined(CONFIG_DISPLAY_CPUINFO) int print_cpuinfo(void) {
- printf("Freescale i.MX28 family\n");
- printf("Freescale i.MX28 family at %d MHz\n",
mxc_get_clock(MXC_ARM_CLK) / 1000000);} #endif
Applied to u-boot-imx, thanks.
Best regards, Stefano Babic
participants (3)
-
Fabio Estevam -
Marek Vasut -
Stefano Babic