The free() function checks if its argument is NULL. It is superfluous to do the same check on the calling side.

Signed-off-by: Heinrich Schuchardt xypron.glpk@gmx.de --- common/spl/spl_fit.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/common/spl/spl_fit.c b/common/spl/spl_fit.c index 69dabd27f6..c51e4beb1c 100644 --- a/common/spl/spl_fit.c +++ b/common/spl/spl_fit.c @@ -425,8 +425,7 @@ static int spl_fit_append_fdt(struct spl_image_info *spl_image, debug("%s: DT overlay %s applied\n", __func__, fit_get_name(fit, node, NULL)); } - if (tmpbuffer) - free(tmpbuffer); + free(tmpbuffer); if (ret) return ret; } -- 2.25.1