[U-Boot] [PATCHv2 1/4] dm: MIGRATION: Add migration plan for DM_MMC
Given that at this point the MMC subsystem itself has been migrated along with a number of subsystem drivers, formalize a deadline for migration.
Cc: Simon Glass sjg@chromium.org Cc: Jaehoon Chung jh80.chung@samsung.com Signed-off-by: Tom Rini trini@konsulko.com --- Changes in v2: - Note that failure to migration may lead to removal. --- Makefile | 8 ++++++++ doc/driver-model/MIGRATION.txt | 9 +++++++++ 2 files changed, 17 insertions(+)
diff --git a/Makefile b/Makefile index a4b1d1db5241..0ab48f9ac97f 100644 --- a/Makefile +++ b/Makefile @@ -920,6 +920,14 @@ ifeq ($(CONFIG_DM_I2C_COMPAT)$(CONFIG_SANDBOX),y) @echo "before sending patches to the mailing list." @echo "====================================================" endif +ifneq ($(CONFIG_DM_MMC)$(CONFIG_OF_CONTROL)$(CONFIG_BLK),yyy) + @echo "===================== WARNING ======================" + @echo "This board does not use CONFIG_DM_MMC. Please update" + @echo "the board to use CONFIG_DM_MMC before the v2019.04 release." + @echo "Failure to update by the deadline may result in board removal." + @echo "See doc/driver-model/MIGRATION.txt for more info." + @echo "====================================================" +endif @# Check that this build does not use CONFIG options that we do not @# know about unless they are in Kconfig. All the existing CONFIG @# options are whitelisted, so new ones should not be added. diff --git a/doc/driver-model/MIGRATION.txt b/doc/driver-model/MIGRATION.txt index 5ebefd608b99..71c26571828a 100644 --- a/doc/driver-model/MIGRATION.txt +++ b/doc/driver-model/MIGRATION.txt @@ -5,6 +5,15 @@ U-Boot has been migrating to a new driver model since its introduction in 2014. This file describes the schedule for deprecation of pre-driver-model features.
+CONFIG_DM_MMC +------------- + +Status: In progress +Deadline: 2019.04 + +The subsystem itself has been converted and maintainers should submit patches +switching over to using CONFIG_DM_MMC and other base driver model options in +time for inclusion in the 2019.04 rerelease.
CONFIG_BLK ----------
As much of the USB system has been migrated to DM now, formalize a deadline for migration.
Cc: Marek Vasut marex@denx.de Cc: Simon Glass sjg@chromium.org Signed-off-by: Tom Rini trini@konsulko.com --- Changes in v2: - Note that failure to migration may lead to removal. --- Makefile | 8 ++++++++ doc/driver-model/MIGRATION.txt | 10 ++++++++++ 2 files changed, 18 insertions(+)
diff --git a/Makefile b/Makefile index 0ab48f9ac97f..c8e90566e37a 100644 --- a/Makefile +++ b/Makefile @@ -928,6 +928,14 @@ ifneq ($(CONFIG_DM_MMC)$(CONFIG_OF_CONTROL)$(CONFIG_BLK),yyy) @echo "See doc/driver-model/MIGRATION.txt for more info." @echo "====================================================" endif +ifneq ($(CONFIG_DM_USB)$(CONFIG_OF_CONTROL)$(CONFIG_BLK),yyy) + @echo "===================== WARNING ======================" + @echo "This board does not use CONFIG_DM_USB. Please update" + @echo "the board to use CONFIG_DM_USB before the v2019.07 release." + @echo "Failure to update by the deadline may result in board removal." + @echo "See doc/driver-model/MIGRATION.txt for more info." + @echo "====================================================" +endif @# Check that this build does not use CONFIG options that we do not @# know about unless they are in Kconfig. All the existing CONFIG @# options are whitelisted, so new ones should not be added. diff --git a/doc/driver-model/MIGRATION.txt b/doc/driver-model/MIGRATION.txt index 71c26571828a..0b763f72a453 100644 --- a/doc/driver-model/MIGRATION.txt +++ b/doc/driver-model/MIGRATION.txt @@ -15,6 +15,16 @@ The subsystem itself has been converted and maintainers should submit patches switching over to using CONFIG_DM_MMC and other base driver model options in time for inclusion in the 2019.04 rerelease.
+CONFIG_DM_USB +------------- + +Status: In progress +Deadline: 2019.07 + +The subsystem itself has been converted along with many of the host controller +and maintainers should submit patches switching over to using CONFIG_DM_USB and +other base driver model options in time for inclusion in the 2019.07 rerelease. + CONFIG_BLK ----------
On Thu, 29 Nov 2018 at 12:13, Tom Rini trini@konsulko.com wrote:
As much of the USB system has been migrated to DM now, formalize a deadline for migration.
Cc: Marek Vasut marex@denx.de Cc: Simon Glass sjg@chromium.org Signed-off-by: Tom Rini trini@konsulko.com
Changes in v2:
- Note that failure to migration may lead to removal.
Makefile | 8 ++++++++ doc/driver-model/MIGRATION.txt | 10 ++++++++++ 2 files changed, 18 insertions(+)
Reviewed-by: Simon Glass sjg@chromium.org
On 11/29/2018 08:12 PM, Tom Rini wrote:
As much of the USB system has been migrated to DM now, formalize a deadline for migration.
Cc: Marek Vasut marex@denx.de Cc: Simon Glass sjg@chromium.org Signed-off-by: Tom Rini trini@konsulko.com
Reviewed-by: Marek Vasut marex@denx.de
As the core of the subsystem has been converted along with some of the drivers, formalize a deadline for migration.
Cc: Akshay Bhat akshaybhat@timesys.com Cc: Andreas Geisreiter ageisreiter@dh-electronics.de Cc: Bin Meng bmeng.cn@gmail.com Cc: Christian Gmeiner christian.gmeiner@gmail.com Cc: Fabio Estevam fabio.estevam@nxp.com Cc: Jason Liu jason.hui.liu@nxp.com Cc: Ken Lin Ken.Lin@advantech.com.tw Cc: Ludwig Zenz lzenz@dh-electronics.de Cc: Marek Vasut marex@denx.de Cc: Max Krummenacher max.krummenacher@toradex.com Cc: Nikita Kiryanov nikita@compulab.co.il Cc: Otavio Salvador otavio@ossystems.com.br Cc: Peng Fan peng.fan@nxp.com Cc: Simon Glass sjg@chromium.org Cc: Soeren Moch smoch@web.de Cc: Stefan Roese sr@denx.de Cc: Stefano Babic sbabic@denx.de Cc: Tim Harvey tharvey@gateworks.com Cc: Troy Kisky troy.kisky@boundarydevices.com Cc: Tuomas Tynkkynen tuomas.tynkkynen@iki.fi Cc: York Sun york.sun@nxp.com Signed-off-by: Tom Rini trini@konsulko.com --- Changes in v2: - Note that failure to migration may lead to removal. - Even more Ccs
Apologies for the scattershot CC list here. A problem with this particular migration is we have a number of drivers for older platforms without clear ownership. Please feel free to loop in other people you know that might have interest here. Thanks! --- Makefile | 8 ++++++++ doc/driver-model/MIGRATION.txt | 10 ++++++++++ 2 files changed, 18 insertions(+)
diff --git a/Makefile b/Makefile index c8e90566e37a..1adf5f4bf72a 100644 --- a/Makefile +++ b/Makefile @@ -936,6 +936,14 @@ ifneq ($(CONFIG_DM_USB)$(CONFIG_OF_CONTROL)$(CONFIG_BLK),yyy) @echo "See doc/driver-model/MIGRATION.txt for more info." @echo "====================================================" endif +ifeq ($(CONFIG_LIBATA)$(CONFIG_DM_SCSI)$(CONFIG_MVSATA_IDE),y) + @echo "===================== WARNING ======================" + @echo "This board does not use CONFIG_DM_SCSI. Please update" + @echo "the storage controller to use CONFIG_DM_SCSI before the v2019.07 release." + @echo "Failure to update by the deadline may result in board removal." + @echo "See doc/driver-model/MIGRATION.txt for more info." + @echo "====================================================" +endif @# Check that this build does not use CONFIG options that we do not @# know about unless they are in Kconfig. All the existing CONFIG @# options are whitelisted, so new ones should not be added. diff --git a/doc/driver-model/MIGRATION.txt b/doc/driver-model/MIGRATION.txt index 0b763f72a453..6df7e02a63de 100644 --- a/doc/driver-model/MIGRATION.txt +++ b/doc/driver-model/MIGRATION.txt @@ -25,6 +25,16 @@ The subsystem itself has been converted along with many of the host controller and maintainers should submit patches switching over to using CONFIG_DM_USB and other base driver model options in time for inclusion in the 2019.07 rerelease.
+CONFIG_SATA +----------- + +Status: In progress +Deadline: 2019.07 + +The subsystem itself has been converted along with many of the host controller +and maintainers should submit patches switching over to using CONFIG_AHCI and +other base driver model options in time for inclusion in the 2019.07 rerelease. + CONFIG_BLK ----------
On Thu, 29 Nov 2018 at 12:13, Tom Rini trini@konsulko.com wrote:
As the core of the subsystem has been converted along with some of the drivers, formalize a deadline for migration.
Cc: Akshay Bhat akshaybhat@timesys.com Cc: Andreas Geisreiter ageisreiter@dh-electronics.de Cc: Bin Meng bmeng.cn@gmail.com Cc: Christian Gmeiner christian.gmeiner@gmail.com Cc: Fabio Estevam fabio.estevam@nxp.com Cc: Jason Liu jason.hui.liu@nxp.com Cc: Ken Lin Ken.Lin@advantech.com.tw Cc: Ludwig Zenz lzenz@dh-electronics.de Cc: Marek Vasut marex@denx.de Cc: Max Krummenacher max.krummenacher@toradex.com Cc: Nikita Kiryanov nikita@compulab.co.il Cc: Otavio Salvador otavio@ossystems.com.br Cc: Peng Fan peng.fan@nxp.com Cc: Simon Glass sjg@chromium.org Cc: Soeren Moch smoch@web.de Cc: Stefan Roese sr@denx.de Cc: Stefano Babic sbabic@denx.de Cc: Tim Harvey tharvey@gateworks.com Cc: Troy Kisky troy.kisky@boundarydevices.com Cc: Tuomas Tynkkynen tuomas.tynkkynen@iki.fi Cc: York Sun york.sun@nxp.com Signed-off-by: Tom Rini trini@konsulko.com
Changes in v2:
- Note that failure to migration may lead to removal.
- Even more Ccs
Apologies for the scattershot CC list here. A problem with this particular migration is we have a number of drivers for older platforms without clear ownership. Please feel free to loop in other people you know that might have interest here. Thanks!
Makefile | 8 ++++++++ doc/driver-model/MIGRATION.txt | 10 ++++++++++ 2 files changed, 18 insertions(+)
Reviewed-by: Simon Glass sjg@chromium.org
Regards, Simon
The biggest part of migration to using CONFIG_BLK is that we need to have the various subsystems migrated first, so reword the plan here to reference the new deadlines.
Reviewed-by: Simon Glass sjg@chromium.org Signed-off-by: Tom Rini trini@konsulko.com --- doc/driver-model/MIGRATION.txt | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/doc/driver-model/MIGRATION.txt b/doc/driver-model/MIGRATION.txt index 6df7e02a63de..6b691338b4e7 100644 --- a/doc/driver-model/MIGRATION.txt +++ b/doc/driver-model/MIGRATION.txt @@ -39,14 +39,12 @@ CONFIG_BLK ----------
Status: In progress -Deadline: 2018.05 - -Maintainers should submit patches for enabling CONFIG_BLK on all boards in -time for inclusion in the 2018.05 release. Boards not converted by this -time may be removed in a subsequent release. +Deadline: 2019.07
-Note that this implies use of driver model for all block devices (e.g. -MMC, USB, SCSI, SATA). +In concert with maintainers migrating their block device usage to the +appropriate DM driver, CONFIG_BLK needs to be set as well. The final deadline +here coincides with the final deadline for migration of the various block +subsystems.
CONFIG_DM_SPI CONFIG_DM_SPI_FLASH
On Thu, 29 Nov 2018 at 12:13, Tom Rini trini@konsulko.com wrote:
Given that at this point the MMC subsystem itself has been migrated along with a number of subsystem drivers, formalize a deadline for migration.
Cc: Simon Glass sjg@chromium.org Cc: Jaehoon Chung jh80.chung@samsung.com Signed-off-by: Tom Rini trini@konsulko.com
Changes in v2:
- Note that failure to migration may lead to removal.
Makefile | 8 ++++++++ doc/driver-model/MIGRATION.txt | 9 +++++++++ 2 files changed, 17 insertions(+)
Reviewed-by: Simon Glass sjg@chromium.org
Would be good to get Marek and a few of the others that didn't notice the migration to ack this.
- Simon
On 29.11.2018 20:12, Tom Rini wrote:
Given that at this point the MMC subsystem itself has been migrated along with a number of subsystem drivers, formalize a deadline for migration.
Cc: Simon Glass sjg@chromium.org Cc: Jaehoon Chung jh80.chung@samsung.com Signed-off-by: Tom Rini trini@konsulko.com
Changes in v2:
- Note that failure to migration may lead to removal.
Makefile | 8 ++++++++ doc/driver-model/MIGRATION.txt | 9 +++++++++ 2 files changed, 17 insertions(+)
diff --git a/Makefile b/Makefile index a4b1d1db5241..0ab48f9ac97f 100644 --- a/Makefile +++ b/Makefile @@ -920,6 +920,14 @@ ifeq ($(CONFIG_DM_I2C_COMPAT)$(CONFIG_SANDBOX),y) @echo "before sending patches to the mailing list." @echo "====================================================" endif +ifneq ($(CONFIG_DM_MMC)$(CONFIG_OF_CONTROL)$(CONFIG_BLK),yyy)
This might not be a too widespread use of U-Boot, but I do have one configuration that boots from FPGA and loads Linux via TFTP. Due to size constraints in FPGA onchip RAM, I have MMC disabled completely. This patch gives me a warning in this case.
I can live with that as I know I have MMC disabled and don't this warning for my other configs though. Just wanted to let you know, as you complained about getting no replies to this thread ;-)
Simon
- @echo "===================== WARNING ======================"
- @echo "This board does not use CONFIG_DM_MMC. Please update"
- @echo "the board to use CONFIG_DM_MMC before the v2019.04 release."
- @echo "Failure to update by the deadline may result in board removal."
- @echo "See doc/driver-model/MIGRATION.txt for more info."
- @echo "===================================================="
+endif @# Check that this build does not use CONFIG options that we do not @# know about unless they are in Kconfig. All the existing CONFIG @# options are whitelisted, so new ones should not be added. diff --git a/doc/driver-model/MIGRATION.txt b/doc/driver-model/MIGRATION.txt index 5ebefd608b99..71c26571828a 100644 --- a/doc/driver-model/MIGRATION.txt +++ b/doc/driver-model/MIGRATION.txt @@ -5,6 +5,15 @@ U-Boot has been migrating to a new driver model since its introduction in 2014. This file describes the schedule for deprecation of pre-driver-model features.
+CONFIG_DM_MMC +-------------
+Status: In progress +Deadline: 2019.04
+The subsystem itself has been converted and maintainers should submit patches +switching over to using CONFIG_DM_MMC and other base driver model options in +time for inclusion in the 2019.04 rerelease.
CONFIG_BLK
On Thu, Nov 29, 2018 at 08:51:17PM +0100, Simon Goldschmidt wrote:
On 29.11.2018 20:12, Tom Rini wrote:
Given that at this point the MMC subsystem itself has been migrated along with a number of subsystem drivers, formalize a deadline for migration.
Cc: Simon Glass sjg@chromium.org Cc: Jaehoon Chung jh80.chung@samsung.com Signed-off-by: Tom Rini trini@konsulko.com
Changes in v2:
- Note that failure to migration may lead to removal.
Makefile | 8 ++++++++ doc/driver-model/MIGRATION.txt | 9 +++++++++ 2 files changed, 17 insertions(+)
diff --git a/Makefile b/Makefile index a4b1d1db5241..0ab48f9ac97f 100644 --- a/Makefile +++ b/Makefile @@ -920,6 +920,14 @@ ifeq ($(CONFIG_DM_I2C_COMPAT)$(CONFIG_SANDBOX),y) @echo "before sending patches to the mailing list." @echo "====================================================" endif +ifneq ($(CONFIG_DM_MMC)$(CONFIG_OF_CONTROL)$(CONFIG_BLK),yyy)
This might not be a too widespread use of U-Boot, but I do have one configuration that boots from FPGA and loads Linux via TFTP. Due to size constraints in FPGA onchip RAM, I have MMC disabled completely. This patch gives me a warning in this case.
I can live with that as I know I have MMC disabled and don't this warning for my other configs though. Just wanted to let you know, as you complained about getting no replies to this thread ;-)
Ah, thanks. That means I should have put a test for CONFIG_MMC in there somewhere. I need to re-work the USB one too I think to confirm CONFIG_USB is set. Thanks! I'll post a v3 once I've given folks a chance in general to chime in with this having re-hit their inbox.
On 29.11.2018 21:02, Tom Rini wrote:
On Thu, Nov 29, 2018 at 08:51:17PM +0100, Simon Goldschmidt wrote:
On 29.11.2018 20:12, Tom Rini wrote:
Given that at this point the MMC subsystem itself has been migrated along with a number of subsystem drivers, formalize a deadline for migration.
Cc: Simon Glass sjg@chromium.org Cc: Jaehoon Chung jh80.chung@samsung.com Signed-off-by: Tom Rini trini@konsulko.com
Changes in v2:
- Note that failure to migration may lead to removal.
Makefile | 8 ++++++++ doc/driver-model/MIGRATION.txt | 9 +++++++++ 2 files changed, 17 insertions(+)
diff --git a/Makefile b/Makefile index a4b1d1db5241..0ab48f9ac97f 100644 --- a/Makefile +++ b/Makefile @@ -920,6 +920,14 @@ ifeq ($(CONFIG_DM_I2C_COMPAT)$(CONFIG_SANDBOX),y) @echo "before sending patches to the mailing list." @echo "====================================================" endif +ifneq ($(CONFIG_DM_MMC)$(CONFIG_OF_CONTROL)$(CONFIG_BLK),yyy)
This might not be a too widespread use of U-Boot, but I do have one configuration that boots from FPGA and loads Linux via TFTP. Due to size constraints in FPGA onchip RAM, I have MMC disabled completely. This patch gives me a warning in this case.
I can live with that as I know I have MMC disabled and don't this warning for my other configs though. Just wanted to let you know, as you complained about getting no replies to this thread ;-)
Ah, thanks. That means I should have put a test for CONFIG_MMC in there somewhere. I need to re-work the USB one too I think to confirm CONFIG_USB is set. Thanks! I'll post a v3 once I've given folks a chance in general to chime in with this having re-hit their inbox.
I would have suggested that, but I hesitated since I can enable CONFIG_DM_MMC without enabling CONFIG_MMC...
Regards, Simon
On Thu, Nov 29, 2018 at 09:04:30PM +0100, Simon Goldschmidt wrote:
On 29.11.2018 21:02, Tom Rini wrote:
On Thu, Nov 29, 2018 at 08:51:17PM +0100, Simon Goldschmidt wrote:
On 29.11.2018 20:12, Tom Rini wrote:
Given that at this point the MMC subsystem itself has been migrated along with a number of subsystem drivers, formalize a deadline for migration.
Cc: Simon Glass sjg@chromium.org Cc: Jaehoon Chung jh80.chung@samsung.com Signed-off-by: Tom Rini trini@konsulko.com
Changes in v2:
- Note that failure to migration may lead to removal.
Makefile | 8 ++++++++ doc/driver-model/MIGRATION.txt | 9 +++++++++ 2 files changed, 17 insertions(+)
diff --git a/Makefile b/Makefile index a4b1d1db5241..0ab48f9ac97f 100644 --- a/Makefile +++ b/Makefile @@ -920,6 +920,14 @@ ifeq ($(CONFIG_DM_I2C_COMPAT)$(CONFIG_SANDBOX),y) @echo "before sending patches to the mailing list." @echo "====================================================" endif +ifneq ($(CONFIG_DM_MMC)$(CONFIG_OF_CONTROL)$(CONFIG_BLK),yyy)
This might not be a too widespread use of U-Boot, but I do have one configuration that boots from FPGA and loads Linux via TFTP. Due to size constraints in FPGA onchip RAM, I have MMC disabled completely. This patch gives me a warning in this case.
I can live with that as I know I have MMC disabled and don't this warning for my other configs though. Just wanted to let you know, as you complained about getting no replies to this thread ;-)
Ah, thanks. That means I should have put a test for CONFIG_MMC in there somewhere. I need to re-work the USB one too I think to confirm CONFIG_USB is set. Thanks! I'll post a v3 once I've given folks a chance in general to chime in with this having re-hit their inbox.
I would have suggested that, but I hesitated since I can enable CONFIG_DM_MMC without enabling CONFIG_MMC...
Ha. I bet it won't work in the end 'tho, we only traverse drivers/mmc/ with CONFIG_MMC=y. Thanks!
On 29.11.2018 21:02, Tom Rini wrote:
On Thu, Nov 29, 2018 at 08:51:17PM +0100, Simon Goldschmidt wrote:
On 29.11.2018 20:12, Tom Rini wrote:
Given that at this point the MMC subsystem itself has been migrated along with a number of subsystem drivers, formalize a deadline for migration.
Cc: Simon Glass sjg@chromium.org Cc: Jaehoon Chung jh80.chung@samsung.com Signed-off-by: Tom Rini trini@konsulko.com
Changes in v2:
- Note that failure to migration may lead to removal.
Makefile | 8 ++++++++ doc/driver-model/MIGRATION.txt | 9 +++++++++ 2 files changed, 17 insertions(+)
diff --git a/Makefile b/Makefile index a4b1d1db5241..0ab48f9ac97f 100644 --- a/Makefile +++ b/Makefile @@ -920,6 +920,14 @@ ifeq ($(CONFIG_DM_I2C_COMPAT)$(CONFIG_SANDBOX),y) @echo "before sending patches to the mailing list." @echo "====================================================" endif +ifneq ($(CONFIG_DM_MMC)$(CONFIG_OF_CONTROL)$(CONFIG_BLK),yyy)
This might not be a too widespread use of U-Boot, but I do have one configuration that boots from FPGA and loads Linux via TFTP. Due to size constraints in FPGA onchip RAM, I have MMC disabled completely. This patch gives me a warning in this case.
I can live with that as I know I have MMC disabled and don't this warning for my other configs though. Just wanted to let you know, as you complained about getting no replies to this thread ;-)
Ah, thanks. That means I should have put a test for CONFIG_MMC in there somewhere. I need to re-work the USB one too I think to confirm CONFIG_USB is set. Thanks! I'll post a v3 once I've given folks a chance in general to chime in with this having re-hit their inbox.
And you're right, I get the same problem for USB, which I have always disabled on our boards. But with CONFIG_USB, it's more clear to be than with CONFIG_MMC. Maybe CONFIG_DM_MMC should depend on CONFIG_MMC?
Simon
On Thu, Nov 29, 2018 at 09:10:50PM +0100, Simon Goldschmidt wrote:
On 29.11.2018 21:02, Tom Rini wrote:
On Thu, Nov 29, 2018 at 08:51:17PM +0100, Simon Goldschmidt wrote:
On 29.11.2018 20:12, Tom Rini wrote:
Given that at this point the MMC subsystem itself has been migrated along with a number of subsystem drivers, formalize a deadline for migration.
Cc: Simon Glass sjg@chromium.org Cc: Jaehoon Chung jh80.chung@samsung.com Signed-off-by: Tom Rini trini@konsulko.com
Changes in v2:
- Note that failure to migration may lead to removal.
Makefile | 8 ++++++++ doc/driver-model/MIGRATION.txt | 9 +++++++++ 2 files changed, 17 insertions(+)
diff --git a/Makefile b/Makefile index a4b1d1db5241..0ab48f9ac97f 100644 --- a/Makefile +++ b/Makefile @@ -920,6 +920,14 @@ ifeq ($(CONFIG_DM_I2C_COMPAT)$(CONFIG_SANDBOX),y) @echo "before sending patches to the mailing list." @echo "====================================================" endif +ifneq ($(CONFIG_DM_MMC)$(CONFIG_OF_CONTROL)$(CONFIG_BLK),yyy)
This might not be a too widespread use of U-Boot, but I do have one configuration that boots from FPGA and loads Linux via TFTP. Due to size constraints in FPGA onchip RAM, I have MMC disabled completely. This patch gives me a warning in this case.
I can live with that as I know I have MMC disabled and don't this warning for my other configs though. Just wanted to let you know, as you complained about getting no replies to this thread ;-)
Ah, thanks. That means I should have put a test for CONFIG_MMC in there somewhere. I need to re-work the USB one too I think to confirm CONFIG_USB is set. Thanks! I'll post a v3 once I've given folks a chance in general to chime in with this having re-hit their inbox.
And you're right, I get the same problem for USB, which I have always disabled on our boards. But with CONFIG_USB, it's more clear to be than with CONFIG_MMC. Maybe CONFIG_DM_MMC should depend on CONFIG_MMC?
I suspect a small re-work to the Kconfig file to turn MMC into a menuconfig so that everything else is grouped under it would help, yes. Thanks!
participants (4)
-
Marek Vasut -
Simon Glass -
Simon Goldschmidt -
Tom Rini