On 5/23/21 9:40 PM, Tom Rini wrote:

On Thu, May 20, 2021 at 05:36:03PM +0200, Heinrich Schuchardt wrote:

...

In cpu_to_be32_array() and be32_to_cpu_array() we should not compare an int counter to a size_t parameter. Correct the type of the counter.

Signed-off-by: Heinrich Schuchardt xypron.glpk@gmx.de

include/linux/byteorder/generic.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/byteorder/generic.h b/include/linux/byteorder/generic.h index 8fae186d1a..bee0ff6033 100644 --- a/include/linux/byteorder/generic.h +++ b/include/linux/byteorder/generic.h @@ -190,7 +190,7 @@ static inline void be64_add_cpu(__be64 *var, u64 val)

static inline void cpu_to_be32_array(__be32 *dst, const u32 *src, size_t len) {

• int i;

• size_t i;

  for (i = 0; i < len; i++) dst[i] = cpu_to_be32(src[i]);

@@ -198,7 +198,7 @@ static inline void cpu_to_be32_array(__be32 *dst, const u32 *src, size_t len)

static inline void be32_to_cpu_array(u32 *dst, const __be32 *src, size_t len) {

• int i;

• size_t i;

  for (i = 0; i < len; i++) dst[i] = be32_to_cpu(src[i]);

This was fixed in what commit from Linux? Thanks!

include/linux/byteorder/generic.h in Linux is equally broken. This should not stop you from merging this patch.

I will create a patch for Linux.

Best regards

Heinrich