[PATCH] cmd: efidebug: fix a wrong handling of arguments

8 May
2020
8 May
'20
7:50 a.m.
Coverity detected a dead code, but actually there is a bug in a check against a number of arguments. So simply fix it.
Signed-off-by: AKASHI Takahiro takahiro.akashi@linaro.org Reported-by: Coverity (CID 300330) --- cmd/efidebug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/cmd/efidebug.c b/cmd/efidebug.c index 70aba446a937..56bf9af77248 100644 --- a/cmd/efidebug.c +++ b/cmd/efidebug.c @@ -606,7 +606,7 @@ static int do_efi_boot_add(cmd_tbl_t *cmdtp, int flag, + sizeof(struct efi_device_path); /* for END */
/* optional data */ - if (argc < 6) + if (argc == 6) lo.optional_data = NULL; else lo.optional_data = (const u8 *)argv[6];
--
2.25.2
1831
Age (days ago)
1831
Last active (days ago)
0 comments
1 participants
participants (1)
-
AKASHI Takahiro