[PATCH v1 0/1] SoCFPGA: Add watchdog mode setting for Agilex 5
From: Muhammad Hazim Izzat Zamri muhammad.hazim.izzat.zamri@intel.com
This patch is to introduce another watchdog mode setting in Agilex 5 as additional watchdog4 has been introduced. This is to enable the debug mode when the CPU is paused by the user.
This patch has been tested on Agilex 5 devkit with QSPI boot (UBI/UBIFS) and RAM boot (TFTP & ARM DS debugger).
Muhammad Hazim Izzat Zamri (1): arm: socfpga:agilex5: Fix system manager watchdog mode setting
arch/arm/mach-socfpga/include/mach/system_manager_soc64.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
From: Muhammad Hazim Izzat Zamri muhammad.hazim.izzat.zamri@intel.com
This commit is to fix the system manager watchdog mode setting to support until mode_4 for Agilex5. This changes can refer to system manager register map on wddbg fields.
Signed-off-by: Muhammad Hazim Izzat Zamri muhammad.hazim.izzat.zamri@intel.com --- arch/arm/mach-socfpga/include/mach/system_manager_soc64.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-socfpga/include/mach/system_manager_soc64.h b/arch/arm/mach-socfpga/include/mach/system_manager_soc64.h index b1ef4a70641..670aa3cc07e 100644 --- a/arch/arm/mach-socfpga/include/mach/system_manager_soc64.h +++ b/arch/arm/mach-socfpga/include/mach/system_manager_soc64.h @@ -182,7 +182,7 @@ void populate_sysmgr_pinmux(void);
#define SYSMGR_DMAPERIPH_ALL_NS 0xFFFFFFFF
-#define SYSMGR_WDDBG_PAUSE_ALL_CPU 0x0F0F0F0F +#define SYSMGR_WDDBG_PAUSE_ALL_CPU 0xFF0F0F0F
#if IS_ENABLED(CONFIG_TARGET_SOCFPGA_N5X) #define SYSMGR_SOC64_DDR_MODE_MSK BIT(0)
Hi Hazim,
-----Original Message----- From: Zamri, Muhammad Hazim Izzat muhammad.hazim.izzat.zamri@intel.com Sent: Thursday, December 5, 2024 11:56 AM To: u-boot@lists.denx.de Cc: Marek marex@denx.de; Simon simon.k.r.goldschmidt@gmail.com; Tom Rini trini@konsulko.com; Chee, Tien Fong tien.fong.chee@intel.com; Meng, Tingting tingting.meng@intel.com; Hea, Kok Kiang kok.kiang.hea@intel.com; Maniyam, Dinesh dinesh.maniyam@intel.com; Ng, Boon Khai boon.khai.ng@intel.com; Yuslaimi, Alif Zakuan alif.zakuan.yuslaimi@intel.com; Zamri, Muhammad Hazim Izzat muhammad.hazim.izzat.zamri@intel.com; Lim, Jit Loon jit.loon.lim@intel.com; Tang, Sieu Mun sieu.mun.tang@intel.com Subject: [PATCH v1 1/1] arm: socfpga:agilex5: Fix system manager watchdog mode setting
From: Muhammad Hazim Izzat Zamri muhammad.hazim.izzat.zamri@intel.com
This commit is to fix the system manager watchdog mode setting to support until mode_4 for Agilex5. This changes can refer to system manager register map on wddbg fields.
You need to improve the commit message, the commit message should contains the description of issue you want to fix such as why no issue in Agilex device, and what / why this solution?
[...]
Regards, Tien Fong
-----Original Message----- From: Chee, Tien Fong tien.fong.chee@intel.com Sent: Thursday, 19 December, 2024 9:51 AM To: Zamri, Muhammad Hazim Izzat muhammad.hazim.izzat.zamri@intel.com; u-boot@lists.denx.de Cc: Marek marex@denx.de; Simon simon.k.r.goldschmidt@gmail.com; Tom Rini trini@konsulko.com; Meng, Tingting tingting.meng@intel.com; Hea, Kok Kiang kok.kiang.hea@intel.com; Maniyam, Dinesh dinesh.maniyam@intel.com; Ng, Boon Khai boon.khai.ng@intel.com; Yuslaimi, Alif Zakuan alif.zakuan.yuslaimi@intel.com; Lim, Jit Loon jit.loon.lim@intel.com; Tang, Sieu Mun sieu.mun.tang@intel.com Subject: RE: [PATCH v1 1/1] arm: socfpga:agilex5: Fix system manager watchdog mode setting
Hi Hazim,
-----Original Message----- From: Zamri, Muhammad Hazim Izzat muhammad.hazim.izzat.zamri@intel.com Sent: Thursday, December 5, 2024 11:56 AM To: u-boot@lists.denx.de Cc: Marek marex@denx.de; Simon
simon.k.r.goldschmidt@gmail.com;
Tom Rini trini@konsulko.com; Chee, Tien Fong tien.fong.chee@intel.com; Meng, Tingting tingting.meng@intel.com; Hea, Kok Kiang kok.kiang.hea@intel.com; Maniyam, Dinesh dinesh.maniyam@intel.com; Ng, Boon Khai boon.khai.ng@intel.com; Yuslaimi, Alif Zakuan alif.zakuan.yuslaimi@intel.com; Zamri, Muhammad Hazim Izzat muhammad.hazim.izzat.zamri@intel.com; Lim,
Jit
Loon jit.loon.lim@intel.com; Tang, Sieu Mun sieu.mun.tang@intel.com Subject: [PATCH v1 1/1] arm: socfpga:agilex5: Fix system manager watchdog mode setting
From: Muhammad Hazim Izzat Zamri muhammad.hazim.izzat.zamri@intel.com
This commit is to fix the system manager watchdog mode setting to support until mode_4 for Agilex5. This changes can refer to system manager register map on wddbg fields.
You need to improve the commit message, the commit message should contains the description of issue you want to fix such as why no issue in Agilex device, and what / why this solution?
[...]
Regards, Tien Fong
Hi Tien Fong,
Okay got it. Will work on improving the commit message.
Thanks, Hazim
participants (3)
-
Chee, Tien Fong -
muhammad.hazim.izzat.zamri＠intel.com -
Zamri, Muhammad Hazim Izzat