[u-boot, v1 0/1] mtd: spi-nor-ids: add STMICRO MT25QL01G flash
Hello Reviewer,
STMICRO MT25QL01G flash is used on AST2600 board, this patch add it in the table.
Please add this update in v2019.04-aspeed-openbmc branch when it is accepted. If I need to submit a separate patch to that branch, please let me know.
Thanks!
Hongwei Zhang (1): mtd: spi-nor-ids: add STMICRO MT25QL01G flash
drivers/mtd/spi/spi-nor-ids.c | 1 + 1 file changed, 1 insertion(+)
Add STMICRO MT25QL01G flash, used on AST2600 board.
Signed-off-by: Hongwei Zhang hongweiz@ami.com --- drivers/mtd/spi/spi-nor-ids.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/mtd/spi/spi-nor-ids.c b/drivers/mtd/spi/spi-nor-ids.c index 09e8196048..6d22b80586 100644 --- a/drivers/mtd/spi/spi-nor-ids.c +++ b/drivers/mtd/spi/spi-nor-ids.c @@ -185,6 +185,7 @@ const struct flash_info spi_nor_ids[] = { { INFO("n25q512ax3", 0x20ba20, 0, 64 * 1024, 1024, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ) }, { INFO("n25q00", 0x20ba21, 0, 64 * 1024, 2048, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ | NO_CHIP_ERASE) }, { INFO("n25q00a", 0x20bb21, 0, 64 * 1024, 2048, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ | NO_CHIP_ERASE) }, + { INFO("mt25ql01g", 0x21ba20, 0, 64 * 1024, 2048, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ | NO_CHIP_ERASE) }, { INFO("mt25qu02g", 0x20bb22, 0, 64 * 1024, 4096, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ | NO_CHIP_ERASE) }, { INFO("mt35xu512aba", 0x2c5b1a, 0, 128 * 1024, 512, USE_FSR | SPI_NOR_OCTAL_READ | SPI_NOR_4B_OPCODES) }, { INFO("mt35xu02g", 0x2c5b1c, 0, 128 * 1024, 2048, USE_FSR | SPI_NOR_OCTAL_READ | SPI_NOR_4B_OPCODES) },
Hi Hongwei
On 12/4/20 11:06 PM, Hongwei Zhang wrote:
Add STMICRO MT25QL01G flash, used on AST2600 board.
MT25QL01G is not a STMicroelectronics flash but a Micron one ;-)
Patrice
Signed-off-by: Hongwei Zhang hongweiz@ami.com
drivers/mtd/spi/spi-nor-ids.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/mtd/spi/spi-nor-ids.c b/drivers/mtd/spi/spi-nor-ids.c index 09e8196048..6d22b80586 100644 --- a/drivers/mtd/spi/spi-nor-ids.c +++ b/drivers/mtd/spi/spi-nor-ids.c @@ -185,6 +185,7 @@ const struct flash_info spi_nor_ids[] = { { INFO("n25q512ax3", 0x20ba20, 0, 64 * 1024, 1024, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ) }, { INFO("n25q00", 0x20ba21, 0, 64 * 1024, 2048, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ | NO_CHIP_ERASE) }, { INFO("n25q00a", 0x20bb21, 0, 64 * 1024, 2048, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ | NO_CHIP_ERASE) },
- { INFO("mt25ql01g", 0x21ba20, 0, 64 * 1024, 2048, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ | NO_CHIP_ERASE) }, { INFO("mt25qu02g", 0x20bb22, 0, 64 * 1024, 4096, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ | NO_CHIP_ERASE) }, { INFO("mt35xu512aba", 0x2c5b1a, 0, 128 * 1024, 512, USE_FSR | SPI_NOR_OCTAL_READ | SPI_NOR_4B_OPCODES) }, { INFO("mt35xu02g", 0x2c5b1c, 0, 128 * 1024, 2048, USE_FSR | SPI_NOR_OCTAL_READ | SPI_NOR_4B_OPCODES) },
Hello Reviewer,
Micron MT25QL01G flash is used on AST2600 board, this patch add it in the table.
Please add this update in v2019.04-aspeed-openbmc branch when it is accepted. If I need to submit a separate patch to that branch, please let me know.
Thanks!
Hongwei Zhang (1): mtd: spi-nor-ids: add Micron MT25QL01G flash
drivers/mtd/spi/spi-nor-ids.c | 1 + 1 file changed, 1 insertion(+)
-- 2.17.1
Add Micron MT25QL01G flash, used on AST2600 board.
Signed-off-by: Hongwei Zhang hongweiz@ami.com --- drivers/mtd/spi/spi-nor-ids.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/mtd/spi/spi-nor-ids.c b/drivers/mtd/spi/spi-nor-ids.c index 09e8196048..6d22b80586 100644 --- a/drivers/mtd/spi/spi-nor-ids.c +++ b/drivers/mtd/spi/spi-nor-ids.c @@ -185,6 +185,7 @@ const struct flash_info spi_nor_ids[] = { { INFO("n25q512ax3", 0x20ba20, 0, 64 * 1024, 1024, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ) }, { INFO("n25q00", 0x20ba21, 0, 64 * 1024, 2048, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ | NO_CHIP_ERASE) }, { INFO("n25q00a", 0x20bb21, 0, 64 * 1024, 2048, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ | NO_CHIP_ERASE) }, + { INFO("mt25ql01g", 0x21ba20, 0, 64 * 1024, 2048, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ | NO_CHIP_ERASE) }, { INFO("mt25qu02g", 0x20bb22, 0, 64 * 1024, 4096, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ | NO_CHIP_ERASE) }, { INFO("mt35xu512aba", 0x2c5b1a, 0, 128 * 1024, 512, USE_FSR | SPI_NOR_OCTAL_READ | SPI_NOR_4B_OPCODES) }, { INFO("mt35xu02g", 0x2c5b1c, 0, 128 * 1024, 2048, USE_FSR | SPI_NOR_OCTAL_READ | SPI_NOR_4B_OPCODES) },
From: Patrice CHOTARD patrice.chotard@foss.st.com
Hi Hongwei
On 12/4/20 11:06 PM, Hongwei Zhang wrote:
Add STMICRO MT25QL01G flash, used on AST2600 board.
MT25QL01G is not a STMicroelectronics flash but a Micron one ;-)
Thanks for the correction, Patrice.
I came back to spi-nor-ids.c, there are two places in the code checking CONFIG_SPI_FLASH_STMICRO define, at line 167 (a lot of Micron flashes included in the block), and at line 239, furthermore, there is no SPI_FLASH_MICRON config menu in Kconfig file. I got confused, why SPI_FLASH_MICRON is not in Kconfig?
Patrice
Signed-off-by: Hongwei Zhang hongweiz@ami.com
drivers/mtd/spi/spi-nor-ids.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/mtd/spi/spi-nor-ids.c b/drivers/mtd/spi/spi-nor-ids.c index 09e8196048..6d22b80586 100644 --- a/drivers/mtd/spi/spi-nor-ids.c +++ b/drivers/mtd/spi/spi-nor-ids.c @@ -185,6 +185,7 @@ const struct flash_info spi_nor_ids[] = { { INFO("n25q512ax3", 0x20ba20, 0, 64 * 1024, 1024, SECT_4K | USE_FSR |
SPI_NOR_QUAD_READ) },
{ INFO("n25q00", 0x20ba21, 0, 64 * 1024, 2048, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ| NO_CHIP_ERASE) },
{ INFO("n25q00a", 0x20bb21, 0, 64 * 1024, 2048, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ| NO_CHIP_ERASE) },
- { INFO("mt25ql01g", 0x21ba20, 0, 64 * 1024, 2048, SECT_4K | USE_FSR |
SPI_NOR_QUAD_READ | NO_CHIP_ERASE) },
{ INFO("mt25qu02g", 0x20bb22, 0, 64 * 1024, 4096, SECT_4K | USE_FSR |SPI_NOR_QUAD_READ | NO_CHIP_ERASE) },
Hi Hongwei
On 12/7/20 11:40 PM, Hongwei Zhang wrote:
From: Patrice CHOTARD patrice.chotard@foss.st.com
Hi Hongwei
On 12/4/20 11:06 PM, Hongwei Zhang wrote:
Add STMICRO MT25QL01G flash, used on AST2600 board.
MT25QL01G is not a STMicroelectronics flash but a Micron one ;-)
Thanks for the correction, Patrice.
I came back to spi-nor-ids.c, there are two places in the code checking CONFIG_SPI_FLASH_STMICRO define, at line 167 (a lot of Micron flashes included in the block), and at line 239, furthermore, there is no SPI_FLASH_MICRON config menu in Kconfig file. I got confused, why SPI_FLASH_MICRON is not in Kconfig?
To sum up, at the beginning, it was STMicroelectronics flashes, since 2010, MICRON acquired this activities. If you want the full history, you will find information here: https://en.wikipedia.org/wiki/Numonyx So the CONFIG_SPI_FLASH_STMICRO compilation flag is historical and didn't get renamed to CONFIG_SPI_FLASH_MICRON.
Patrice
Patrice
Signed-off-by: Hongwei Zhang hongweiz@ami.com
drivers/mtd/spi/spi-nor-ids.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/mtd/spi/spi-nor-ids.c b/drivers/mtd/spi/spi-nor-ids.c index 09e8196048..6d22b80586 100644 --- a/drivers/mtd/spi/spi-nor-ids.c +++ b/drivers/mtd/spi/spi-nor-ids.c @@ -185,6 +185,7 @@ const struct flash_info spi_nor_ids[] = { { INFO("n25q512ax3", 0x20ba20, 0, 64 * 1024, 1024, SECT_4K | USE_FSR |
SPI_NOR_QUAD_READ) },
{ INFO("n25q00", 0x20ba21, 0, 64 * 1024, 2048, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ| NO_CHIP_ERASE) },
{ INFO("n25q00a", 0x20bb21, 0, 64 * 1024, 2048, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ| NO_CHIP_ERASE) },
- { INFO("mt25ql01g", 0x21ba20, 0, 64 * 1024, 2048, SECT_4K | USE_FSR |
SPI_NOR_QUAD_READ | NO_CHIP_ERASE) },
{ INFO("mt25qu02g", 0x20bb22, 0, 64 * 1024, 4096, SECT_4K | USE_FSR |SPI_NOR_QUAD_READ | NO_CHIP_ERASE) },
Hi Jagan,
Please remove the other patch serie: _https://patchwork.ozlabs.org/project/uboot/list/?series=218779
This serie (219106) has the correct flash maker name.
Thanks!
Hi Patrice,
From: Patrice CHOTARD patrice.chotard@foss.st.com Sent: Tuesday, December 8, 2020 2:54 AM
Hi Hongwei
On 12/7/20 11:40 PM, Hongwei Zhang wrote:
From: Patrice CHOTARD patrice.chotard@foss.st.com
Hi Hongwei
On 12/4/20 11:06 PM, Hongwei Zhang wrote:
Add STMICRO MT25QL01G flash, used on AST2600 board.
MT25QL01G is not a STMicroelectronics flash but a Micron one ;-)
Thanks for the correction, Patrice.
I came back to spi-nor-ids.c, there are two places in the code checking CONFIG_SPI_FLASH_STMICRO define, at line 167 (a lot of Micron flashes included in the block), and at line 239, furthermore, there is no SPI_FLASH_MICRON config menu in Kconfig file. I got confused, why SPI_FLASH_MICRON is not in Kconfig?
To sum up, at the beginning, it was STMicroelectronics flashes, since 2010, MICRON acquired this activities. If you want the full history, you will find information here: https://en.wikipedia.org/wiki/Numonyx So the CONFIG_SPI_FLASH_STMICRO compilation flag is historical and didn't get renamed to CONFIG_SPI_FLASH_MICRON.
Thanks for the information, it is an interesting history!
--Hongwei
participants (2)
-
Hongwei Zhang -
Patrice CHOTARD