[U-Boot] [PATCH] dm: scsi: fix callto function with wrong signature

buildman fails for the qemu-x86 with the following error: drivers/ata/ahci-pci.c: In function 'ahci_pci_probe': drivers/ata/ahci-pci.c:21:9: error: too few arguments to function 'ahci_probe_scsi' return ahci_probe_scsi(dev); ^ In file included from drivers/ata/ahci-pci.c:8:0: include/ahci.h:224:5: note: declared here int ahci_probe_scsi(struct udevice *ahci_dev, ulong base);
This changes the function call to call ahci_probe_scsi_pci (which matches the signature and probes for a controller via on a PCI bus).
Signed-off-by: Philipp Tomsich philipp.tomsich@theobroma-systems.com ---
drivers/ata/ahci-pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/ahci-pci.c b/drivers/ata/ahci-pci.c index f46fad8..5a45edc 100644 --- a/drivers/ata/ahci-pci.c +++ b/drivers/ata/ahci-pci.c @@ -18,7 +18,7 @@ static int ahci_pci_bind(struct udevice *dev)
static int ahci_pci_probe(struct udevice *dev) { - return ahci_probe_scsi(dev); + return ahci_probe_scsi_pci(dev); }
static const struct udevice_id ahci_pci_ids[] = {

Hi Philipp,
On Sat, Aug 5, 2017 at 3:11 AM, Philipp Tomsich philipp.tomsich@theobroma-systems.com wrote:
buildman fails for the qemu-x86 with the following error: drivers/ata/ahci-pci.c: In function 'ahci_pci_probe': drivers/ata/ahci-pci.c:21:9: error: too few arguments to function 'ahci_probe_scsi' return ahci_probe_scsi(dev); ^ In file included from drivers/ata/ahci-pci.c:8:0: include/ahci.h:224:5: note: declared here int ahci_probe_scsi(struct udevice *ahci_dev, ulong base);
This changes the function call to call ahci_probe_scsi_pci (which matches the signature and probes for a controller via on a PCI bus).
Signed-off-by: Philipp Tomsich philipp.tomsich@theobroma-systems.com
Thanks for the patch. This is already fixed in the u-boot/master.
Regards, Bin
participants (2)
-
Bin Meng
-
Philipp Tomsich