[PATCH] Makefile: Fix calling make with V=1

Calling 'make V=1 all' on Ubuntu 18.04 with gcc version 9.2.1 and GNU Make version 4.1 fails on error:
scripts/Kbuild.include:220: *** Recursive variable 'echo-cmd' references itself (eventually). Stop.
As a workaround expand 'echo-cmd' variable via 'call' construction instead of expanding it directly.
Signed-off-by: Pali Rohár pali@kernel.org Reported-by: Patrick DELAUNAY patrick.delaunay@st.com --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile index 94feb7d9a5..b90fe8b865 100644 --- a/Makefile +++ b/Makefile @@ -1309,7 +1309,7 @@ init_sp_bss_offset_check: u-boot.dtb FORCE fi endif
-shell_cmd = { $(echo-cmd) $(cmd_$(1)); } +shell_cmd = { $(call echo-cmd,$(1)) $(cmd_$(1)); }
quiet_cmd_objcopy_uboot = OBJCOPY $@ cmd_objcopy_uboot = $(cmd_objcopy) && $(call shell_cmd,static_rela,$<,$@,$(CONFIG_SYS_TEXT_BASE)) || { rm -f $@; false; }

Hi Pali
From: Pali Rohár pali@kernel.org Sent: mercredi 4 novembre 2020 10:35
Calling 'make V=1 all' on Ubuntu 18.04 with gcc version 9.2.1 and GNU Make version 4.1 fails on error:
scripts/Kbuild.include:220: *** Recursive variable 'echo-cmd' references itself
(eventually). Stop.
As a workaround expand 'echo-cmd' variable via 'call' construction instead of expanding it directly.
Signed-off-by: Pali Rohár pali@kernel.org Reported-by: Patrick DELAUNAY patrick.delaunay@st.com
Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Patrick Delaunay patrick.delaunay@st.com
This patch fixe for me (stm32mp15_basic_defconfig or stm32mp15_trusted_defconfig). the issue introduced by previous patch
Fixes: ae897022d7bd ("Makefile: Fix u-boot-nodtb.bin target")
Thanks.
Patrick

On Wed, Nov 04, 2020 at 10:34:35AM +0100, Pali Rohár wrote:
Calling 'make V=1 all' on Ubuntu 18.04 with gcc version 9.2.1 and GNU Make version 4.1 fails on error:
scripts/Kbuild.include:220: *** Recursive variable 'echo-cmd' references itself (eventually). Stop.
As a workaround expand 'echo-cmd' variable via 'call' construction instead of expanding it directly.
Signed-off-by: Pali Rohár pali@kernel.org Reported-by: Patrick DELAUNAY patrick.delaunay@st.com
Applied to u-boot/master, thanks!
participants (3)
-
Pali Rohár
-
Patrick DELAUNAY
-
Tom Rini