[U-Boot] [PATCH v1 1/1] fix: possible overflow when copying the string

Bigger source buffer than dest buffer could overflow when copying strings. Source and destination buffer sizes are same now.
Signed-off-by: Imran Zaman imran.zaman@intel.com --- common/cli_simple.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/cli_simple.c b/common/cli_simple.c index 00a8d2f..d8b40c9 100644 --- a/common/cli_simple.c +++ b/common/cli_simple.c @@ -258,7 +258,7 @@ int cli_simple_run_command(const char *cmd, int flag)
void cli_simple_loop(void) { - static char lastcommand[CONFIG_SYS_CBSIZE] = { 0, }; + static char lastcommand[CONFIG_SYS_CBSIZE + 1] = { 0, };
int len; int flag;

On Mon, Sep 07, 2015 at 11:24:08AM +0300, Imran Zaman wrote:
Bigger source buffer than dest buffer could overflow when copying strings. Source and destination buffer sizes are same now.
Signed-off-by: Imran Zaman imran.zaman@intel.com
Applied to u-boot/master, thanks!
participants (2)
-
Imran Zaman
-
Tom Rini