[U-Boot] [PATCH 00/16] Remove two unused drivers and unused CONFIG options
The first two deletes unused i2c drivers.
The rest of the series delete unreferenced CONFIG options.
Today, I volunteered to delete 20 CONFIGs or so, but probably I will not do this again since it was time-consuming, painful work...
Buildman passed. No code size change.
Masahiro Yamada (16): i2c: adi_i2c: remove left-over Blackfin I2C driver i2c: fti2c010: remove unused/unmaintained driver IMX: novena: remove CONFIG_I2C_MXC omap4: sdp4430: remove CONFIG_4430SDP mpc85xx: freescale: remove CONFIG_ADDR_STREAMING sh7734: remove CONFIG_553MHZ_MODE ARC: remove CONFIG_ARC_UART_BASE SOCFPGA: remove CONFIG_AUTONEG_TIMEOUT omap4: sdp4430: match the #endif comment to #ifdef exynos: remove CONFIG_CORE_COUNT MX28: remove CONFIG_DEFAULT_SPI_CS AM33XX: etamin: remove CONFIG_DFU_MTD mpc85xx: xpedite550x: remove CONFIG_FDT_FIXUP_PCI_IRQ net: remove CONFIG_NET_MULTI exynos: remove CONFIG_LCD_MENU_BOARD AT91: remove CONFIG_PMECC_INDEX_TABLE_OFFSET
board/ti/sdp4430/cmd_bat.c | 2 +- drivers/i2c/Makefile | 2 - drivers/i2c/adi_i2c.c | 309 -------------------------------- drivers/i2c/fti2c010.c | 340 ------------------------------------ drivers/i2c/fti2c010.h | 80 --------- include/configs/C29XPCIE.h | 1 - include/configs/P1010RDB.h | 1 - include/configs/am335x_shc.h | 1 - include/configs/ap_sh4a_4a.h | 1 - include/configs/at91sam9n12ek.h | 1 - include/configs/bg0900.h | 1 - include/configs/blanche.h | 1 - include/configs/cm_t43.h | 1 - include/configs/cyrus.h | 1 - include/configs/etamin.h | 1 - include/configs/exynos5420-common.h | 5 - include/configs/exynos7420-common.h | 3 - include/configs/ls1012aqds.h | 1 - include/configs/ls1012ardb.h | 1 - include/configs/ls1043a_common.h | 1 - include/configs/m28evk.h | 1 - include/configs/novena.h | 1 - include/configs/nsa310s.h | 1 - include/configs/nsim.h | 1 - include/configs/omap4_sdp4430.h | 1 - include/configs/pengwyn.h | 3 - include/configs/r0p7734.h | 1 - include/configs/s5pc210_universal.h | 1 - include/configs/salvator-x.h | 1 - include/configs/socfpga_common.h | 1 - include/configs/trats.h | 1 - include/configs/trats2.h | 1 - include/configs/ulcb.h | 1 - include/configs/xilinx_zynqmp.h | 1 - include/configs/xpedite550x.h | 1 - 35 files changed, 1 insertion(+), 770 deletions(-) delete mode 100644 drivers/i2c/adi_i2c.c delete mode 100644 drivers/i2c/fti2c010.c delete mode 100644 drivers/i2c/fti2c010.h
This driver was used by Blackfin boards, but Blackfin support is gone. There is no user of this driver.
Signed-off-by: Masahiro Yamada yamada.masahiro@socionext.com ---
drivers/i2c/Makefile | 1 - drivers/i2c/adi_i2c.c | 309 -------------------------------------------------- 2 files changed, 310 deletions(-) delete mode 100644 drivers/i2c/adi_i2c.c
diff --git a/drivers/i2c/Makefile b/drivers/i2c/Makefile index e7ade94..121e4e2 100644 --- a/drivers/i2c/Makefile +++ b/drivers/i2c/Makefile @@ -10,7 +10,6 @@ obj-$(CONFIG_DM_I2C_GPIO) += i2c-gpio.o obj-$(CONFIG_$(SPL_)I2C_CROS_EC_TUNNEL) += cros_ec_tunnel.o obj-$(CONFIG_$(SPL_)I2C_CROS_EC_LDO) += cros_ec_ldo.o
-obj-$(CONFIG_SYS_I2C_ADI) += adi_i2c.o obj-$(CONFIG_I2C_MV) += mv_i2c.o obj-$(CONFIG_TSI108_I2C) += tsi108_i2c.o obj-$(CONFIG_SH_SH7734_I2C) += sh_sh7734_i2c.o diff --git a/drivers/i2c/adi_i2c.c b/drivers/i2c/adi_i2c.c deleted file mode 100644 index d340639..0000000 --- a/drivers/i2c/adi_i2c.c +++ /dev/null @@ -1,309 +0,0 @@ -/* - * i2c.c - driver for ADI TWI/I2C - * - * Copyright (c) 2006-2014 Analog Devices Inc. - * - * Licensed under the GPL-2 or later. - * - * NOTE: This driver should be converted to driver model before June 2017. - * Please see doc/driver-model/i2c-howto.txt for instructions. - */ - -#include <common.h> -#include <console.h> -#include <i2c.h> - -#include <asm/clock.h> -#include <asm/twi.h> -#include <asm/io.h> - -static struct twi_regs *i2c_get_base(struct i2c_adapter *adap); - -/* Every register is 32bit aligned, but only 16bits in size */ -#define ureg(name) u16 name; u16 __pad_##name; -struct twi_regs { - ureg(clkdiv); - ureg(control); - ureg(slave_ctl); - ureg(slave_stat); - ureg(slave_addr); - ureg(master_ctl); - ureg(master_stat); - ureg(master_addr); - ureg(int_stat); - ureg(int_mask); - ureg(fifo_ctl); - ureg(fifo_stat); - char __pad[0x50]; - ureg(xmt_data8); - ureg(xmt_data16); - ureg(rcv_data8); - ureg(rcv_data16); -}; -#undef ureg - -#ifdef TWI_CLKDIV -#define TWI0_CLKDIV TWI_CLKDIV -# ifdef CONFIG_SYS_MAX_I2C_BUS -# undef CONFIG_SYS_MAX_I2C_BUS -# endif -#define CONFIG_SYS_MAX_I2C_BUS 1 -#endif - -/* - * The way speed is changed into duty often results in integer truncation - * with 50% duty, so we'll force rounding up to the next duty by adding 1 - * to the max. In practice this will get us a speed of something like - * 385 KHz. The other limit is easy to handle as it is only 8 bits. - */ -#define I2C_SPEED_MAX 400000 -#define I2C_SPEED_TO_DUTY(speed) (5000000 / (speed)) -#define I2C_DUTY_MAX (I2C_SPEED_TO_DUTY(I2C_SPEED_MAX) + 1) -#define I2C_DUTY_MIN 0xff /* 8 bit limited */ -#define SYS_I2C_DUTY I2C_SPEED_TO_DUTY(CONFIG_SYS_I2C_SPEED) -/* Note: duty is inverse of speed, so the comparisons below are correct */ -#if SYS_I2C_DUTY < I2C_DUTY_MAX || SYS_I2C_DUTY > I2C_DUTY_MIN -# error "The I2C hardware can only operate 20KHz - 400KHz" -#endif - -/* All transfers are described by this data structure */ -struct adi_i2c_msg { - u8 flags; -#define I2C_M_COMBO 0x4 -#define I2C_M_STOP 0x2 -#define I2C_M_READ 0x1 - int len; /* msg length */ - u8 *buf; /* pointer to msg data */ - int alen; /* addr length */ - u8 *abuf; /* addr buffer */ -}; - -/* Allow msec timeout per ~byte transfer */ -#define I2C_TIMEOUT 10 - -/** - * wait_for_completion - manage the actual i2c transfer - * @msg: the i2c msg - */ -static int wait_for_completion(struct twi_regs *twi, struct adi_i2c_msg *msg) -{ - u16 int_stat, ctl; - ulong timebase = get_timer(0); - - do { - int_stat = readw(&twi->int_stat); - - if (int_stat & XMTSERV) { - writew(XMTSERV, &twi->int_stat); - if (msg->alen) { - writew(*(msg->abuf++), &twi->xmt_data8); - --msg->alen; - } else if (!(msg->flags & I2C_M_COMBO) && msg->len) { - writew(*(msg->buf++), &twi->xmt_data8); - --msg->len; - } else { - ctl = readw(&twi->master_ctl); - if (msg->flags & I2C_M_COMBO) - writew(ctl | RSTART | MDIR, - &twi->master_ctl); - else - writew(ctl | STOP, &twi->master_ctl); - } - } - if (int_stat & RCVSERV) { - writew(RCVSERV, &twi->int_stat); - if (msg->len) { - *(msg->buf++) = readw(&twi->rcv_data8); - --msg->len; - } else if (msg->flags & I2C_M_STOP) { - ctl = readw(&twi->master_ctl); - writew(ctl | STOP, &twi->master_ctl); - } - } - if (int_stat & MERR) { - writew(MERR, &twi->int_stat); - return msg->len; - } - if (int_stat & MCOMP) { - writew(MCOMP, &twi->int_stat); - if (msg->flags & I2C_M_COMBO && msg->len) { - ctl = readw(&twi->master_ctl); - ctl = (ctl & ~RSTART) | - (min(msg->len, 0xff) << 6) | MEN | MDIR; - writew(ctl, &twi->master_ctl); - } else - break; - } - - /* If we were able to do something, reset timeout */ - if (int_stat) - timebase = get_timer(0); - - } while (get_timer(timebase) < I2C_TIMEOUT); - - return msg->len; -} - -static int i2c_transfer(struct i2c_adapter *adap, uint8_t chip, uint addr, - int alen, uint8_t *buffer, int len, uint8_t flags) -{ - struct twi_regs *twi = i2c_get_base(adap); - int ret; - u16 ctl; - uchar addr_buffer[] = { - (addr >> 0), - (addr >> 8), - (addr >> 16), - }; - struct adi_i2c_msg msg = { - .flags = flags | (len >= 0xff ? I2C_M_STOP : 0), - .buf = buffer, - .len = len, - .abuf = addr_buffer, - .alen = alen, - }; - - /* wait for things to settle */ - while (readw(&twi->master_stat) & BUSBUSY) - if (ctrlc()) - return 1; - - /* Set Transmit device address */ - writew(chip, &twi->master_addr); - - /* Clear the FIFO before starting things */ - writew(XMTFLUSH | RCVFLUSH, &twi->fifo_ctl); - writew(0, &twi->fifo_ctl); - - /* prime the pump */ - if (msg.alen) { - len = (msg.flags & I2C_M_COMBO) ? msg.alen : msg.alen + len; - writew(*(msg.abuf++), &twi->xmt_data8); - --msg.alen; - } else if (!(msg.flags & I2C_M_READ) && msg.len) { - writew(*(msg.buf++), &twi->xmt_data8); - --msg.len; - } - - /* clear int stat */ - writew(-1, &twi->master_stat); - writew(-1, &twi->int_stat); - writew(0, &twi->int_mask); - - /* Master enable */ - ctl = readw(&twi->master_ctl); - ctl = (ctl & FAST) | (min(len, 0xff) << 6) | MEN | - ((msg.flags & I2C_M_READ) ? MDIR : 0); - writew(ctl, &twi->master_ctl); - - /* process the rest */ - ret = wait_for_completion(twi, &msg); - - if (ret) { - ctl = readw(&twi->master_ctl) & ~MEN; - writew(ctl, &twi->master_ctl); - ctl = readw(&twi->control) & ~TWI_ENA; - writew(ctl, &twi->control); - ctl = readw(&twi->control) | TWI_ENA; - writew(ctl, &twi->control); - } - - return ret; -} - -static uint adi_i2c_setspeed(struct i2c_adapter *adap, uint speed) -{ - struct twi_regs *twi = i2c_get_base(adap); - u16 clkdiv = I2C_SPEED_TO_DUTY(speed); - - /* Set TWI interface clock */ - if (clkdiv < I2C_DUTY_MAX || clkdiv > I2C_DUTY_MIN) - return -1; - clkdiv = (clkdiv << 8) | (clkdiv & 0xff); - writew(clkdiv, &twi->clkdiv); - - /* Don't turn it on */ - writew(speed > 100000 ? FAST : 0, &twi->master_ctl); - - return 0; -} - -static void adi_i2c_init(struct i2c_adapter *adap, int speed, int slaveaddr) -{ - struct twi_regs *twi = i2c_get_base(adap); - u16 prescale = ((get_i2c_clk() / 1000 / 1000 + 5) / 10) & 0x7F; - - /* Set TWI internal clock as 10MHz */ - writew(prescale, &twi->control); - - /* Set TWI interface clock as specified */ - i2c_set_bus_speed(speed); - - /* Enable it */ - writew(TWI_ENA | prescale, &twi->control); -} - -static int adi_i2c_read(struct i2c_adapter *adap, uint8_t chip, - uint addr, int alen, uint8_t *buffer, int len) -{ - return i2c_transfer(adap, chip, addr, alen, buffer, - len, alen ? I2C_M_COMBO : I2C_M_READ); -} - -static int adi_i2c_write(struct i2c_adapter *adap, uint8_t chip, - uint addr, int alen, uint8_t *buffer, int len) -{ - return i2c_transfer(adap, chip, addr, alen, buffer, len, 0); -} - -static int adi_i2c_probe(struct i2c_adapter *adap, uint8_t chip) -{ - u8 byte; - return adi_i2c_read(adap, chip, 0, 0, &byte, 1); -} - -static struct twi_regs *i2c_get_base(struct i2c_adapter *adap) -{ - switch (adap->hwadapnr) { -#if CONFIG_SYS_MAX_I2C_BUS > 2 - case 2: - return (struct twi_regs *)TWI2_CLKDIV; -#endif -#if CONFIG_SYS_MAX_I2C_BUS > 1 - case 1: - return (struct twi_regs *)TWI1_CLKDIV; -#endif - case 0: - return (struct twi_regs *)TWI0_CLKDIV; - - default: - printf("wrong hwadapnr: %d\n", adap->hwadapnr); - } - - return NULL; -} - -U_BOOT_I2C_ADAP_COMPLETE(adi_i2c0, adi_i2c_init, adi_i2c_probe, - adi_i2c_read, adi_i2c_write, - adi_i2c_setspeed, - CONFIG_SYS_I2C_SPEED, - 0, - 0) - -#if CONFIG_SYS_MAX_I2C_BUS > 1 -U_BOOT_I2C_ADAP_COMPLETE(adi_i2c1, adi_i2c_init, adi_i2c_probe, - adi_i2c_read, adi_i2c_write, - adi_i2c_setspeed, - CONFIG_SYS_I2C_SPEED, - 0, - 1) -#endif - -#if CONFIG_SYS_MAX_I2C_BUS > 2 -U_BOOT_I2C_ADAP_COMPLETE(adi_i2c2, adi_i2c_init, adi_i2c_probe, - adi_i2c_read, adi_i2c_write, - adi_i2c_setspeed, - CONFIG_SYS_I2C_SPEED, - 0, - 2) -#endif
Hello Masahiro,
Am 26.10.2017 um 14:24 schrieb Masahiro Yamada:
This driver was used by Blackfin boards, but Blackfin support is gone. There is no user of this driver.
Signed-off-by: Masahiro Yamada yamada.masahiro@socionext.com
drivers/i2c/Makefile | 1 - drivers/i2c/adi_i2c.c | 309 -------------------------------------------------- 2 files changed, 310 deletions(-) delete mode 100644 drivers/i2c/adi_i2c.c
Thanks!
Acked-by: Heiko Schocher hs@denx.de
bye, Heiko
On Thu, Oct 26, 2017 at 09:24:16PM +0900, Masahiro Yamada wrote:
This driver was used by Blackfin boards, but Blackfin support is gone. There is no user of this driver.
Signed-off-by: Masahiro Yamada yamada.masahiro@socionext.com Acked-by: Heiko Schocher hs@denx.de
Applied to u-boot/master, thanks!
CONFIG_SYS_I2C_FTI2C010 is not enabled by anyone.
Commit 2852709676c8 ("dm: i2c: Add a note to I2C drivers which need conversion") prompted to convert this driver to DM before June 2017, but not converted yet.
Signed-off-by: Masahiro Yamada yamada.masahiro@socionext.com ---
drivers/i2c/Makefile | 1 - drivers/i2c/fti2c010.c | 340 ------------------------------------------------- drivers/i2c/fti2c010.h | 80 ------------ 3 files changed, 421 deletions(-) delete mode 100644 drivers/i2c/fti2c010.c delete mode 100644 drivers/i2c/fti2c010.h
diff --git a/drivers/i2c/Makefile b/drivers/i2c/Makefile index 121e4e2..3a8c61b 100644 --- a/drivers/i2c/Makefile +++ b/drivers/i2c/Makefile @@ -20,7 +20,6 @@ obj-$(CONFIG_SYS_I2C_CADENCE) += i2c-cdns.o obj-$(CONFIG_SYS_I2C_DAVINCI) += davinci_i2c.o obj-$(CONFIG_SYS_I2C_DW) += designware_i2c.o obj-$(CONFIG_SYS_I2C_FSL) += fsl_i2c.o -obj-$(CONFIG_SYS_I2C_FTI2C010) += fti2c010.o obj-$(CONFIG_SYS_I2C_IHS) += ihs_i2c.o obj-$(CONFIG_SYS_I2C_INTEL) += intel_i2c.o obj-$(CONFIG_SYS_I2C_IMX_LPI2C) += imx_lpi2c.o diff --git a/drivers/i2c/fti2c010.c b/drivers/i2c/fti2c010.c deleted file mode 100644 index 4da959f..0000000 --- a/drivers/i2c/fti2c010.c +++ /dev/null @@ -1,340 +0,0 @@ -/* - * Faraday I2C Controller - * - * (C) Copyright 2010 Faraday Technology - * Dante Su dantesu@faraday-tech.com - * - * SPDX-License-Identifier: GPL-2.0+ - * - * NOTE: This driver should be converted to driver model before June 2017. - * Please see doc/driver-model/i2c-howto.txt for instructions. - */ - -#include <common.h> -#include <asm/io.h> -#include <i2c.h> - -#include "fti2c010.h" - -#ifndef CONFIG_SYS_I2C_SPEED -#define CONFIG_SYS_I2C_SPEED 5000 -#endif - -#ifndef CONFIG_SYS_I2C_SLAVE -#define CONFIG_SYS_I2C_SLAVE 0 -#endif - -#ifndef CONFIG_FTI2C010_CLOCK -#define CONFIG_FTI2C010_CLOCK clk_get_rate("I2C") -#endif - -#ifndef CONFIG_FTI2C010_TIMEOUT -#define CONFIG_FTI2C010_TIMEOUT 10 /* ms */ -#endif - -/* 7-bit dev address + 1-bit read/write */ -#define I2C_RD(dev) ((((dev) << 1) & 0xfe) | 1) -#define I2C_WR(dev) (((dev) << 1) & 0xfe) - -struct fti2c010_chip { - struct fti2c010_regs *regs; -}; - -static struct fti2c010_chip chip_list[] = { - { - .regs = (struct fti2c010_regs *)CONFIG_FTI2C010_BASE, - }, -#ifdef CONFIG_FTI2C010_BASE1 - { - .regs = (struct fti2c010_regs *)CONFIG_FTI2C010_BASE1, - }, -#endif -#ifdef CONFIG_FTI2C010_BASE2 - { - .regs = (struct fti2c010_regs *)CONFIG_FTI2C010_BASE2, - }, -#endif -#ifdef CONFIG_FTI2C010_BASE3 - { - .regs = (struct fti2c010_regs *)CONFIG_FTI2C010_BASE3, - }, -#endif -}; - -static int fti2c010_reset(struct fti2c010_chip *chip) -{ - ulong ts; - int ret = -1; - struct fti2c010_regs *regs = chip->regs; - - writel(CR_I2CRST, ®s->cr); - for (ts = get_timer(0); get_timer(ts) < CONFIG_FTI2C010_TIMEOUT; ) { - if (!(readl(®s->cr) & CR_I2CRST)) { - ret = 0; - break; - } - } - - if (ret) - printf("fti2c010: reset timeout\n"); - - return ret; -} - -static int fti2c010_wait(struct fti2c010_chip *chip, uint32_t mask) -{ - int ret = -1; - uint32_t stat, ts; - struct fti2c010_regs *regs = chip->regs; - - for (ts = get_timer(0); get_timer(ts) < CONFIG_FTI2C010_TIMEOUT; ) { - stat = readl(®s->sr); - if ((stat & mask) == mask) { - ret = 0; - break; - } - } - - return ret; -} - -static unsigned int set_i2c_bus_speed(struct fti2c010_chip *chip, - unsigned int speed) -{ - struct fti2c010_regs *regs = chip->regs; - unsigned int clk = CONFIG_FTI2C010_CLOCK; - unsigned int gsr = 0; - unsigned int tsr = 32; - unsigned int div, rate; - - for (div = 0; div < 0x3ffff; ++div) { - /* SCLout = PCLK/(2*(COUNT + 2) + GSR) */ - rate = clk / (2 * (div + 2) + gsr); - if (rate <= speed) - break; - } - - writel(TGSR_GSR(gsr) | TGSR_TSR(tsr), ®s->tgsr); - writel(CDR_DIV(div), ®s->cdr); - - return rate; -} - -/* - * Initialization, must be called once on start up, may be called - * repeatedly to change the speed and slave addresses. - */ -static void fti2c010_init(struct i2c_adapter *adap, int speed, int slaveaddr) -{ - struct fti2c010_chip *chip = chip_list + adap->hwadapnr; - - if (adap->init_done) - return; - -#ifdef CONFIG_SYS_I2C_INIT_BOARD - /* Call board specific i2c bus reset routine before accessing the - * environment, which might be in a chip on that bus. For details - * about this problem see doc/I2C_Edge_Conditions. - */ - i2c_init_board(); -#endif - - /* master init */ - - fti2c010_reset(chip); - - set_i2c_bus_speed(chip, speed); - - /* slave init, don't care */ -} - -/* - * Probe the given I2C chip address. Returns 0 if a chip responded, - * not 0 on failure. - */ -static int fti2c010_probe(struct i2c_adapter *adap, u8 dev) -{ - struct fti2c010_chip *chip = chip_list + adap->hwadapnr; - struct fti2c010_regs *regs = chip->regs; - int ret; - - /* 1. Select slave device (7bits Address + 1bit R/W) */ - writel(I2C_WR(dev), ®s->dr); - writel(CR_ENABLE | CR_TBEN | CR_START, ®s->cr); - ret = fti2c010_wait(chip, SR_DT); - if (ret) - return ret; - - /* 2. Select device register */ - writel(0, ®s->dr); - writel(CR_ENABLE | CR_TBEN, ®s->cr); - ret = fti2c010_wait(chip, SR_DT); - - return ret; -} - -static void to_i2c_addr(u8 *buf, uint32_t addr, int alen) -{ - int i, shift; - - if (!buf || alen <= 0) - return; - - /* MSB first */ - i = 0; - shift = (alen - 1) * 8; - while (alen-- > 0) { - buf[i] = (u8)(addr >> shift); - shift -= 8; - } -} - -static int fti2c010_read(struct i2c_adapter *adap, - u8 dev, uint addr, int alen, uchar *buf, int len) -{ - struct fti2c010_chip *chip = chip_list + adap->hwadapnr; - struct fti2c010_regs *regs = chip->regs; - int ret, pos; - uchar paddr[4] = { 0 }; - - to_i2c_addr(paddr, addr, alen); - - /* - * Phase A. Set register address - */ - - /* A.1 Select slave device (7bits Address + 1bit R/W) */ - writel(I2C_WR(dev), ®s->dr); - writel(CR_ENABLE | CR_TBEN | CR_START, ®s->cr); - ret = fti2c010_wait(chip, SR_DT); - if (ret) - return ret; - - /* A.2 Select device register */ - for (pos = 0; pos < alen; ++pos) { - uint32_t ctrl = CR_ENABLE | CR_TBEN; - - writel(paddr[pos], ®s->dr); - writel(ctrl, ®s->cr); - ret = fti2c010_wait(chip, SR_DT); - if (ret) - return ret; - } - - /* - * Phase B. Get register data - */ - - /* B.1 Select slave device (7bits Address + 1bit R/W) */ - writel(I2C_RD(dev), ®s->dr); - writel(CR_ENABLE | CR_TBEN | CR_START, ®s->cr); - ret = fti2c010_wait(chip, SR_DT); - if (ret) - return ret; - - /* B.2 Get register data */ - for (pos = 0; pos < len; ++pos) { - uint32_t ctrl = CR_ENABLE | CR_TBEN; - uint32_t stat = SR_DR; - - if (pos == len - 1) { - ctrl |= CR_NAK | CR_STOP; - stat |= SR_ACK; - } - writel(ctrl, ®s->cr); - ret = fti2c010_wait(chip, stat); - if (ret) - break; - buf[pos] = (uchar)(readl(®s->dr) & 0xFF); - } - - return ret; -} - -static int fti2c010_write(struct i2c_adapter *adap, - u8 dev, uint addr, int alen, u8 *buf, int len) -{ - struct fti2c010_chip *chip = chip_list + adap->hwadapnr; - struct fti2c010_regs *regs = chip->regs; - int ret, pos; - uchar paddr[4] = { 0 }; - - to_i2c_addr(paddr, addr, alen); - - /* - * Phase A. Set register address - * - * A.1 Select slave device (7bits Address + 1bit R/W) - */ - writel(I2C_WR(dev), ®s->dr); - writel(CR_ENABLE | CR_TBEN | CR_START, ®s->cr); - ret = fti2c010_wait(chip, SR_DT); - if (ret) - return ret; - - /* A.2 Select device register */ - for (pos = 0; pos < alen; ++pos) { - uint32_t ctrl = CR_ENABLE | CR_TBEN; - - writel(paddr[pos], ®s->dr); - writel(ctrl, ®s->cr); - ret = fti2c010_wait(chip, SR_DT); - if (ret) - return ret; - } - - /* - * Phase B. Set register data - */ - for (pos = 0; pos < len; ++pos) { - uint32_t ctrl = CR_ENABLE | CR_TBEN; - - if (pos == len - 1) - ctrl |= CR_STOP; - writel(buf[pos], ®s->dr); - writel(ctrl, ®s->cr); - ret = fti2c010_wait(chip, SR_DT); - if (ret) - break; - } - - return ret; -} - -static unsigned int fti2c010_set_bus_speed(struct i2c_adapter *adap, - unsigned int speed) -{ - struct fti2c010_chip *chip = chip_list + adap->hwadapnr; - int ret; - - fti2c010_reset(chip); - ret = set_i2c_bus_speed(chip, speed); - - return ret; -} - -/* - * Register i2c adapters - */ -U_BOOT_I2C_ADAP_COMPLETE(i2c_0, fti2c010_init, fti2c010_probe, fti2c010_read, - fti2c010_write, fti2c010_set_bus_speed, - CONFIG_SYS_I2C_SPEED, CONFIG_SYS_I2C_SLAVE, - 0) -#ifdef CONFIG_FTI2C010_BASE1 -U_BOOT_I2C_ADAP_COMPLETE(i2c_1, fti2c010_init, fti2c010_probe, fti2c010_read, - fti2c010_write, fti2c010_set_bus_speed, - CONFIG_SYS_I2C_SPEED, CONFIG_SYS_I2C_SLAVE, - 1) -#endif -#ifdef CONFIG_FTI2C010_BASE2 -U_BOOT_I2C_ADAP_COMPLETE(i2c_2, fti2c010_init, fti2c010_probe, fti2c010_read, - fti2c010_write, fti2c010_set_bus_speed, - CONFIG_SYS_I2C_SPEED, CONFIG_SYS_I2C_SLAVE, - 2) -#endif -#ifdef CONFIG_FTI2C010_BASE3 -U_BOOT_I2C_ADAP_COMPLETE(i2c_3, fti2c010_init, fti2c010_probe, fti2c010_read, - fti2c010_write, fti2c010_set_bus_speed, - CONFIG_SYS_I2C_SPEED, CONFIG_SYS_I2C_SLAVE, - 3) -#endif diff --git a/drivers/i2c/fti2c010.h b/drivers/i2c/fti2c010.h deleted file mode 100644 index b9d0eb7..0000000 --- a/drivers/i2c/fti2c010.h +++ /dev/null @@ -1,80 +0,0 @@ -/* - * Faraday I2C Controller - * - * (C) Copyright 2010 Faraday Technology - * Dante Su dantesu@faraday-tech.com - * - * SPDX-License-Identifier: GPL-2.0+ - */ - -#ifndef __FTI2C010_H -#define __FTI2C010_H - -/* - * FTI2C010 registers - */ -struct fti2c010_regs { - uint32_t cr; /* 0x00: control register */ - uint32_t sr; /* 0x04: status register */ - uint32_t cdr; /* 0x08: clock division register */ - uint32_t dr; /* 0x0c: data register */ - uint32_t sar; /* 0x10: slave address register */ - uint32_t tgsr;/* 0x14: time & glitch suppression register */ - uint32_t bmr; /* 0x18: bus monitor register */ - uint32_t rsvd[5]; - uint32_t revr;/* 0x30: revision register */ -}; - -/* - * control register - */ -#define CR_ALIRQ 0x2000 /* arbitration lost interrupt (master) */ -#define CR_SAMIRQ 0x1000 /* slave address match interrupt (slave) */ -#define CR_STOPIRQ 0x800 /* stop condition interrupt (slave) */ -#define CR_NAKRIRQ 0x400 /* NACK response interrupt (master) */ -#define CR_DRIRQ 0x200 /* rx interrupt (both) */ -#define CR_DTIRQ 0x100 /* tx interrupt (both) */ -#define CR_TBEN 0x80 /* tx enable (both) */ -#define CR_NAK 0x40 /* NACK (both) */ -#define CR_STOP 0x20 /* stop (master) */ -#define CR_START 0x10 /* start (master) */ -#define CR_GCEN 0x8 /* general call support (slave) */ -#define CR_SCLEN 0x4 /* enable clock out (master) */ -#define CR_I2CEN 0x2 /* enable I2C (both) */ -#define CR_I2CRST 0x1 /* reset I2C (both) */ -#define CR_ENABLE \ - (CR_ALIRQ | CR_NAKRIRQ | CR_DRIRQ | CR_DTIRQ | CR_SCLEN | CR_I2CEN) - -/* - * status register - */ -#define SR_CLRAL 0x400 /* clear arbitration lost */ -#define SR_CLRGC 0x200 /* clear general call */ -#define SR_CLRSAM 0x100 /* clear slave address match */ -#define SR_CLRSTOP 0x80 /* clear stop */ -#define SR_CLRNAKR 0x40 /* clear NACK respond */ -#define SR_DR 0x20 /* rx ready */ -#define SR_DT 0x10 /* tx done */ -#define SR_BB 0x8 /* bus busy */ -#define SR_BUSY 0x4 /* chip busy */ -#define SR_ACK 0x2 /* ACK/NACK received */ -#define SR_RW 0x1 /* set when master-rx or slave-tx mode */ - -/* - * clock division register - */ -#define CDR_DIV(n) ((n) & 0x3ffff) - -/* - * time & glitch suppression register - */ -#define TGSR_GSR(n) (((n) & 0x7) << 10) -#define TGSR_TSR(n) ((n) & 0x3ff) - -/* - * bus monitor register - */ -#define BMR_SCL 0x2 /* SCL is pull-up */ -#define BMR_SDA 0x1 /* SDA is pull-up */ - -#endif /* __FTI2C010_H */
Hello Masahiro,
Am 26.10.2017 um 14:24 schrieb Masahiro Yamada:
CONFIG_SYS_I2C_FTI2C010 is not enabled by anyone.
Commit 2852709676c8 ("dm: i2c: Add a note to I2C drivers which need conversion") prompted to convert this driver to DM before June 2017, but not converted yet.
Signed-off-by: Masahiro Yamada yamada.masahiro@socionext.com
drivers/i2c/Makefile | 1 - drivers/i2c/fti2c010.c | 340 ------------------------------------------------- drivers/i2c/fti2c010.h | 80 ------------ 3 files changed, 421 deletions(-) delete mode 100644 drivers/i2c/fti2c010.c delete mode 100644 drivers/i2c/fti2c010.h
Thanks!
Acked-by: Heiko Schocher hs@denx.de
bye, Heiko
On Thu, Oct 26, 2017 at 09:24:17PM +0900, Masahiro Yamada wrote:
CONFIG_SYS_I2C_FTI2C010 is not enabled by anyone.
Commit 2852709676c8 ("dm: i2c: Add a note to I2C drivers which need conversion") prompted to convert this driver to DM before June 2017, but not converted yet.
Signed-off-by: Masahiro Yamada yamada.masahiro@socionext.com Acked-by: Heiko Schocher hs@denx.de
Applied to u-boot/master, thanks!
This macro is defined, but not referenced by anyone.
I did not touch config_whitelist.txt - the CONFIG will be dropped by the next re-sync.
Signed-off-by: Masahiro Yamada yamada.masahiro@socionext.com ---
include/configs/novena.h | 1 - 1 file changed, 1 deletion(-)
diff --git a/include/configs/novena.h b/include/configs/novena.h index ac00975..3acc8c6 100644 --- a/include/configs/novena.h +++ b/include/configs/novena.h @@ -80,7 +80,6 @@ #define CONFIG_SYS_I2C_MXC_I2C2 /* enable I2C bus 2 */ #define CONFIG_SYS_I2C_MXC_I2C3 /* enable I2C bus 3 */ #define CONFIG_I2C_MULTI_BUS -#define CONFIG_I2C_MXC #define CONFIG_SYS_I2C_SPEED 100000 #define CONFIG_SYS_SPD_BUS_NUM 0
Hello Masahiro,
Am 26.10.2017 um 14:24 schrieb Masahiro Yamada:
This macro is defined, but not referenced by anyone.
I did not touch config_whitelist.txt - the CONFIG will be dropped by the next re-sync.
Signed-off-by: Masahiro Yamada yamada.masahiro@socionext.com
include/configs/novena.h | 1 - 1 file changed, 1 deletion(-)
Thanks!
Acked-by: Heiko Schocherhs@denx.de
bye, Heiko
On Thu, Oct 26, 2017 at 09:24:18PM +0900, Masahiro Yamada wrote:
This macro is defined, but not referenced by anyone.
I did not touch config_whitelist.txt - the CONFIG will be dropped by the next re-sync.
Signed-off-by: Masahiro Yamada yamada.masahiro@socionext.com Acked-by: Heiko Schocherhs@denx.de
Applied to u-boot/master, thanks!
This macro is defined, but not referenced by anyone.
I did not touch config_whitelist.txt - the CONFIG will be dropped by the next re-sync.
Signed-off-by: Masahiro Yamada yamada.masahiro@socionext.com ---
include/configs/omap4_sdp4430.h | 1 - 1 file changed, 1 deletion(-)
diff --git a/include/configs/omap4_sdp4430.h b/include/configs/omap4_sdp4430.h index c89bd13..c7f7131 100644 --- a/include/configs/omap4_sdp4430.h +++ b/include/configs/omap4_sdp4430.h @@ -16,7 +16,6 @@ /* * High Level Configuration Options */ -#define CONFIG_4430SDP 1 /* working with SDP */ #define CONFIG_MACH_TYPE MACH_TYPE_OMAP_4430SDP
#include <configs/ti_omap4_common.h>
On Thu, Oct 26, 2017 at 09:24:19PM +0900, Masahiro Yamada wrote:
This macro is defined, but not referenced by anyone.
I did not touch config_whitelist.txt - the CONFIG will be dropped by the next re-sync.
Signed-off-by: Masahiro Yamada yamada.masahiro@socionext.com
Applied to u-boot/master, thanks!
This macro is defined, but not referenced by anyone.
I did not touch config_whitelist.txt - the CONFIG will be dropped by the next re-sync.
Signed-off-by: Masahiro Yamada yamada.masahiro@socionext.com ---
include/configs/C29XPCIE.h | 1 - include/configs/P1010RDB.h | 1 - 2 files changed, 2 deletions(-)
diff --git a/include/configs/C29XPCIE.h b/include/configs/C29XPCIE.h index d6982d3..7e805ec 100644 --- a/include/configs/C29XPCIE.h +++ b/include/configs/C29XPCIE.h @@ -109,7 +109,6 @@ #define CONFIG_L2_CACHE /* toggle L2 cache */ #define CONFIG_BTB /* toggle branch predition */
-#define CONFIG_ADDR_STREAMING /* toggle addr streaming */
#define CONFIG_ENABLE_36BIT_PHYS
diff --git a/include/configs/P1010RDB.h b/include/configs/P1010RDB.h index 13edd0a..adb4a18 100644 --- a/include/configs/P1010RDB.h +++ b/include/configs/P1010RDB.h @@ -205,7 +205,6 @@ #define CONFIG_L2_CACHE /* toggle L2 cache */ #define CONFIG_BTB /* toggle branch predition */
-#define CONFIG_ADDR_STREAMING /* toggle addr streaming */
#define CONFIG_ENABLE_36BIT_PHYS
On 10/26/2017 05:26 AM, Masahiro Yamada wrote:
This macro is defined, but not referenced by anyone.
I did not touch config_whitelist.txt - the CONFIG will be dropped by the next re-sync.
Signed-off-by: Masahiro Yamada yamada.masahiro@socionext.com
include/configs/C29XPCIE.h | 1 - include/configs/P1010RDB.h | 1 - 2 files changed, 2 deletions(-)
diff --git a/include/configs/C29XPCIE.h b/include/configs/C29XPCIE.h index d6982d3..7e805ec 100644 --- a/include/configs/C29XPCIE.h +++ b/include/configs/C29XPCIE.h @@ -109,7 +109,6 @@ #define CONFIG_L2_CACHE /* toggle L2 cache */ #define CONFIG_BTB /* toggle branch predition */
-#define CONFIG_ADDR_STREAMING /* toggle addr streaming */
#define CONFIG_ENABLE_36BIT_PHYS
diff --git a/include/configs/P1010RDB.h b/include/configs/P1010RDB.h index 13edd0a..adb4a18 100644 --- a/include/configs/P1010RDB.h +++ b/include/configs/P1010RDB.h @@ -205,7 +205,6 @@ #define CONFIG_L2_CACHE /* toggle L2 cache */ #define CONFIG_BTB /* toggle branch predition */
-#define CONFIG_ADDR_STREAMING /* toggle addr streaming */
#define CONFIG_ENABLE_36BIT_PHYS
Reviewed-by: York Sun york.sun@nxp.com
On Thu, Oct 26, 2017 at 09:24:20PM +0900, Masahiro Yamada wrote:
This macro is defined, but not referenced by anyone.
I did not touch config_whitelist.txt - the CONFIG will be dropped by the next re-sync.
Signed-off-by: Masahiro Yamada yamada.masahiro@socionext.com Reviewed-by: York Sun york.sun@nxp.com
Applied to u-boot/master, thanks!
This macro only appears in commented-out lines. It is not referenced by anyone.
I did not touch config_whitelist.txt - the CONFIG will be dropped by the next re-sync.
Signed-off-by: Masahiro Yamada yamada.masahiro@socionext.com ---
include/configs/ap_sh4a_4a.h | 1 - include/configs/r0p7734.h | 1 - 2 files changed, 2 deletions(-)
diff --git a/include/configs/ap_sh4a_4a.h b/include/configs/ap_sh4a_4a.h index ab3d40c..717ec80 100644 --- a/include/configs/ap_sh4a_4a.h +++ b/include/configs/ap_sh4a_4a.h @@ -12,7 +12,6 @@ #define CONFIG_CPU_SH7734 1 #define CONFIG_AP_SH4A_4A 1 #define CONFIG_400MHZ_MODE 1 -/* #define CONFIG_533MHZ_MODE 1 */
#define CONFIG_SYS_TEXT_BASE 0x8BFC0000
diff --git a/include/configs/r0p7734.h b/include/configs/r0p7734.h index a31c6e2..1fef8b5 100644 --- a/include/configs/r0p7734.h +++ b/include/configs/r0p7734.h @@ -12,7 +12,6 @@ #define CONFIG_CPU_SH7734 1 #define CONFIG_R0P7734 1 #define CONFIG_400MHZ_MODE 1 -/* #define CONFIG_533MHZ_MODE 1 */
#define CONFIG_SYS_TEXT_BASE 0x8FFC0000
On Thu, Oct 26, 2017 at 09:24:21PM +0900, Masahiro Yamada wrote:
This macro only appears in commented-out lines. It is not referenced by anyone.
I did not touch config_whitelist.txt - the CONFIG will be dropped by the next re-sync.
Signed-off-by: Masahiro Yamada yamada.masahiro@socionext.com
Applied to u-boot/master, thanks!
This macro is defined, but not referenced by anyone.
I did not touch config_whitelist.txt - the CONFIG will be dropped by the next re-sync.
Signed-off-by: Masahiro Yamada yamada.masahiro@socionext.com ---
include/configs/nsim.h | 1 - 1 file changed, 1 deletion(-)
diff --git a/include/configs/nsim.h b/include/configs/nsim.h index c086de6..c4775e5 100644 --- a/include/configs/nsim.h +++ b/include/configs/nsim.h @@ -30,7 +30,6 @@ * */ #define CONFIG_ARC_SERIAL -#define CONFIG_ARC_UART_BASE 0xC0FC1000
/* * Command line configuration
On Thu, Oct 26, 2017 at 09:24:22PM +0900, Masahiro Yamada wrote:
This macro is defined, but not referenced by anyone.
I did not touch config_whitelist.txt - the CONFIG will be dropped by the next re-sync.
Signed-off-by: Masahiro Yamada yamada.masahiro@socionext.com
Applied to u-boot/master, thanks!
This macro is defined, but not referenced by anyone.
I did not touch config_whitelist.txt - the CONFIG will be dropped by the next re-sync.
Signed-off-by: Masahiro Yamada yamada.masahiro@socionext.com ---
include/configs/socfpga_common.h | 1 - 1 file changed, 1 deletion(-)
diff --git a/include/configs/socfpga_common.h b/include/configs/socfpga_common.h index 7b5417a..7281bda 100644 --- a/include/configs/socfpga_common.h +++ b/include/configs/socfpga_common.h @@ -94,7 +94,6 @@ #if defined(CONFIG_CMD_NET) && !defined(CONFIG_SOCFPGA_VIRTUAL_TARGET) #define CONFIG_DW_ALTDESCRIPTOR #define CONFIG_MII -#define CONFIG_AUTONEG_TIMEOUT (15 * CONFIG_SYS_HZ) #endif
/*
On Thu, Oct 26, 2017 at 09:24:23PM +0900, Masahiro Yamada wrote:
This macro is defined, but not referenced by anyone.
I did not touch config_whitelist.txt - the CONFIG will be dropped by the next re-sync.
Signed-off-by: Masahiro Yamada yamada.masahiro@socionext.com
Applied to u-boot/master, thanks!
This comment creates a wrong entry in config_whitelist.txt.
I did not touch config_whitelist.txt - the CONFIG will be dropped by the next re-sync.
Signed-off-by: Masahiro Yamada yamada.masahiro@socionext.com ---
board/ti/sdp4430/cmd_bat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/board/ti/sdp4430/cmd_bat.c b/board/ti/sdp4430/cmd_bat.c index 7e8dbb1..4c7beeb 100644 --- a/board/ti/sdp4430/cmd_bat.c +++ b/board/ti/sdp4430/cmd_bat.c @@ -39,4 +39,4 @@ U_BOOT_CMD( "bat startcharge - start charging via USB\n" "bat stopcharge - stop charging\n" ); -#endif /* CONFIG_BAT_CMD */ +#endif /* CONFIG_CMD_BAT */
On Thu, Oct 26, 2017 at 09:24:24PM +0900, Masahiro Yamada wrote:
This comment creates a wrong entry in config_whitelist.txt.
I did not touch config_whitelist.txt - the CONFIG will be dropped by the next re-sync.
Signed-off-by: Masahiro Yamada yamada.masahiro@socionext.com
Applied to u-boot/master, thanks!
This macro is defined, but not referenced by anyone.
I did not touch config_whitelist.txt - the CONFIG will be dropped by the next re-sync.
Signed-off-by: Masahiro Yamada yamada.masahiro@socionext.com ---
include/configs/exynos5420-common.h | 5 ----- include/configs/exynos7420-common.h | 3 --- 2 files changed, 8 deletions(-)
diff --git a/include/configs/exynos5420-common.h b/include/configs/exynos5420-common.h index 79e6d13..ae9ead5 100644 --- a/include/configs/exynos5420-common.h +++ b/include/configs/exynos5420-common.h @@ -43,11 +43,6 @@ #define CONFIG_LOWPOWER_FLAG 0x02020028 #define CONFIG_LOWPOWER_ADDR 0x0202002C
-/* - * Number of CPUs available - */ -#define CONFIG_CORE_COUNT 0x8 - #define CONFIG_USB_XHCI_EXYNOS
#endif /* __CONFIG_EXYNOS5420_H */ diff --git a/include/configs/exynos7420-common.h b/include/configs/exynos7420-common.h index 0aeec39..4e10471 100644 --- a/include/configs/exynos7420-common.h +++ b/include/configs/exynos7420-common.h @@ -43,9 +43,6 @@ #define CONFIG_IRAM_END (CONFIG_IRAM_BASE + CONFIG_IRAM_SIZE) #define CPU_RELEASE_ADDR secondary_boot_addr
-/* Number of CPUs available */ -#define CONFIG_CORE_COUNT 0x8 - /* select serial console configuration */
#define CONFIG_SYS_LOAD_ADDR (CONFIG_SYS_SDRAM_BASE + 0x3E00000)
On 26/10/17 21:24, Masahiro Yamada wrote:
This macro is defined, but not referenced by anyone.
I did not touch config_whitelist.txt - the CONFIG will be dropped by the next re-sync.
Signed-off-by: Masahiro Yamada yamada.masahiro@socionext.com
include/configs/exynos5420-common.h | 5 ----- include/configs/exynos7420-common.h | 3 --- 2 files changed, 8 deletions(-)
diff --git a/include/configs/exynos5420-common.h b/include/configs/exynos5420-common.h index 79e6d13..ae9ead5 100644 --- a/include/configs/exynos5420-common.h +++ b/include/configs/exynos5420-common.h @@ -43,11 +43,6 @@ #define CONFIG_LOWPOWER_FLAG 0x02020028 #define CONFIG_LOWPOWER_ADDR 0x0202002C
-/*
- Number of CPUs available
- */
-#define CONFIG_CORE_COUNT 0x8
#define CONFIG_USB_XHCI_EXYNOS
#endif /* __CONFIG_EXYNOS5420_H */ diff --git a/include/configs/exynos7420-common.h b/include/configs/exynos7420-common.h index 0aeec39..4e10471 100644 --- a/include/configs/exynos7420-common.h +++ b/include/configs/exynos7420-common.h @@ -43,9 +43,6 @@ #define CONFIG_IRAM_END (CONFIG_IRAM_BASE + CONFIG_IRAM_SIZE) #define CPU_RELEASE_ADDR secondary_boot_addr
-/* Number of CPUs available */ -#define CONFIG_CORE_COUNT 0x8
/* select serial console configuration */
#define CONFIG_SYS_LOAD_ADDR (CONFIG_SYS_SDRAM_BASE + 0x3E00000)
Acked-by: Minkyu Kang mk7.kang@samsung.com
Thanks, Minkyu Kang.
On Thu, Oct 26, 2017 at 09:24:25PM +0900, Masahiro Yamada wrote:
This macro is defined, but not referenced by anyone.
I did not touch config_whitelist.txt - the CONFIG will be dropped by the next re-sync.
Signed-off-by: Masahiro Yamada yamada.masahiro@socionext.com Acked-by: Minkyu Kang mk7.kang@samsung.com
Applied to u-boot/master, thanks!
This macro is defined, but not referenced by anyone.
I did not touch config_whitelist.txt - the CONFIG will be dropped by the next re-sync.
Signed-off-by: Masahiro Yamada yamada.masahiro@socionext.com ---
include/configs/bg0900.h | 1 - include/configs/m28evk.h | 1 - 2 files changed, 2 deletions(-)
diff --git a/include/configs/bg0900.h b/include/configs/bg0900.h index 3b65416..03700b0 100644 --- a/include/configs/bg0900.h +++ b/include/configs/bg0900.h @@ -27,7 +27,6 @@ /* SPI */ #ifdef CONFIG_CMD_SPI #define CONFIG_DEFAULT_SPI_BUS 2 -#define CONFIG_DEFAULT_SPI_CS 0 #define CONFIG_DEFAULT_SPI_MODE SPI_MODE_0
/* SPI FLASH */ diff --git a/include/configs/m28evk.h b/include/configs/m28evk.h index 4fcf480..b5ba6b4 100644 --- a/include/configs/m28evk.h +++ b/include/configs/m28evk.h @@ -72,7 +72,6 @@ /* SPI */ #ifdef CONFIG_CMD_SPI #define CONFIG_DEFAULT_SPI_BUS 2 -#define CONFIG_DEFAULT_SPI_CS 0 #define CONFIG_DEFAULT_SPI_MODE SPI_MODE_0
/* SPI FLASH */
On Thu, Oct 26, 2017 at 09:24:26PM +0900, Masahiro Yamada wrote:
This macro is defined, but not referenced by anyone.
I did not touch config_whitelist.txt - the CONFIG will be dropped by the next re-sync.
Signed-off-by: Masahiro Yamada yamada.masahiro@socionext.com
Applied to u-boot/master, thanks!
This macro is defined, but not referenced by anyone.
I did not touch config_whitelist.txt - the CONFIG will be dropped by the next re-sync.
Signed-off-by: Masahiro Yamada yamada.masahiro@socionext.com ---
include/configs/etamin.h | 1 - 1 file changed, 1 deletion(-)
diff --git a/include/configs/etamin.h b/include/configs/etamin.h index c9584ad..7bd2c4a 100644 --- a/include/configs/etamin.h +++ b/include/configs/etamin.h @@ -120,7 +120,6 @@
-#define CONFIG_DFU_MTD #undef COMMON_ENV_DFU_ARGS #define COMMON_ENV_DFU_ARGS "dfu_args=run bootargs_defaults;" \ "setenv bootargs ${bootargs};" \
On Thu, Oct 26, 2017 at 09:24:27PM +0900, Masahiro Yamada wrote:
This macro is defined, but not referenced by anyone.
I did not touch config_whitelist.txt - the CONFIG will be dropped by the next re-sync.
Signed-off-by: Masahiro Yamada yamada.masahiro@socionext.com
Applied to u-boot/master, thanks!
This macro is defined, but not referenced by anyone.
I did not touch config_whitelist.txt - the CONFIG will be dropped by the next re-sync.
Signed-off-by: Masahiro Yamada yamada.masahiro@socionext.com ---
include/configs/xpedite550x.h | 1 - 1 file changed, 1 deletion(-)
diff --git a/include/configs/xpedite550x.h b/include/configs/xpedite550x.h index b433224..6c0981b 100644 --- a/include/configs/xpedite550x.h +++ b/include/configs/xpedite550x.h @@ -204,7 +204,6 @@ extern unsigned long get_board_ddr_clk(unsigned long dummy); #define CONFIG_LOADS_ECHO 1 /* echo on for serial download */ #define CONFIG_SYS_LOADS_BAUD_CHANGE 1 /* allow baudrate change */
-#define CONFIG_FDT_FIXUP_PCI_IRQ 1
/* * I2C
On Thu, Oct 26, 2017 at 09:24:28PM +0900, Masahiro Yamada wrote:
This macro is defined, but not referenced by anyone.
I did not touch config_whitelist.txt - the CONFIG will be dropped by the next re-sync.
Signed-off-by: Masahiro Yamada yamada.masahiro@socionext.com
Applied to u-boot/master, thanks!
This macro is defined, but not referenced by anyone.
I did not touch config_whitelist.txt - the CONFIG will be dropped by the next re-sync.
Signed-off-by: Masahiro Yamada yamada.masahiro@socionext.com ---
include/configs/am335x_shc.h | 1 - include/configs/blanche.h | 1 - include/configs/cm_t43.h | 1 - include/configs/cyrus.h | 1 - include/configs/ls1012aqds.h | 1 - include/configs/ls1012ardb.h | 1 - include/configs/ls1043a_common.h | 1 - include/configs/nsa310s.h | 1 - include/configs/pengwyn.h | 3 --- include/configs/salvator-x.h | 1 - include/configs/ulcb.h | 1 - include/configs/xilinx_zynqmp.h | 1 - 12 files changed, 14 deletions(-)
diff --git a/include/configs/am335x_shc.h b/include/configs/am335x_shc.h index 2eeb3d1..32439f5 100644 --- a/include/configs/am335x_shc.h +++ b/include/configs/am335x_shc.h @@ -266,7 +266,6 @@ #define CONFIG_BOOTP_GATEWAY #define CONFIG_BOOTP_SUBNETMASK #define CONFIG_NET_RETRY_COUNT 10 -#define CONFIG_NET_MULTI #define CONFIG_PHY_ADDR 0 #define CONFIG_PHY_SMSC
diff --git a/include/configs/blanche.h b/include/configs/blanche.h index 2b18033..ce7c716 100755 --- a/include/configs/blanche.h +++ b/include/configs/blanche.h @@ -65,7 +65,6 @@ #undef CONFIG_CMD_SPI #endif
-#define CONFIG_NET_MULTI
/* Board Clock */ #define RMOBILE_XTAL_CLK 20000000u diff --git a/include/configs/cm_t43.h b/include/configs/cm_t43.h index 7012a95..a222491 100644 --- a/include/configs/cm_t43.h +++ b/include/configs/cm_t43.h @@ -50,7 +50,6 @@ #define CONFIG_BOOTP_DEFAULT #define CONFIG_BOOTP_SEND_HOSTNAME #define CONFIG_BOOTP_GATEWAY -#define CONFIG_NET_MULTI #define CONFIG_PHY_ATHEROS #define CONFIG_SYS_RX_ETH_BUFFER 64
diff --git a/include/configs/cyrus.h b/include/configs/cyrus.h index 13e7c71..1b20d85 100644 --- a/include/configs/cyrus.h +++ b/include/configs/cyrus.h @@ -370,7 +370,6 @@
#ifdef CONFIG_PCI #define CONFIG_PCI_INDIRECT_BRIDGE -#define CONFIG_NET_MULTI
#define CONFIG_PCI_SCAN_SHOW /* show pci devices on startup */ #endif /* CONFIG_PCI */ diff --git a/include/configs/ls1012aqds.h b/include/configs/ls1012aqds.h index b3121d2..2899ff1 100644 --- a/include/configs/ls1012aqds.h +++ b/include/configs/ls1012aqds.h @@ -146,7 +146,6 @@
#define CONFIG_PCIE1 /* PCIE controller 1 */
-#define CONFIG_NET_MULTI #define CONFIG_PCI_SCAN_SHOW
#define CONFIG_CMD_MEMINFO diff --git a/include/configs/ls1012ardb.h b/include/configs/ls1012ardb.h index e9edcd2..c720a8d 100644 --- a/include/configs/ls1012ardb.h +++ b/include/configs/ls1012ardb.h @@ -62,7 +62,6 @@
#define CONFIG_PCIE1 /* PCIE controller 1 */
-#define CONFIG_NET_MULTI #define CONFIG_PCI_SCAN_SHOW
#define CONFIG_CMD_MEMINFO diff --git a/include/configs/ls1043a_common.h b/include/configs/ls1043a_common.h index a297134..a24d006 100644 --- a/include/configs/ls1043a_common.h +++ b/include/configs/ls1043a_common.h @@ -165,7 +165,6 @@ #define CONFIG_PCIE3 /* PCIE controller 3 */
#ifdef CONFIG_PCI -#define CONFIG_NET_MULTI #define CONFIG_PCI_SCAN_SHOW #endif #endif diff --git a/include/configs/nsa310s.h b/include/configs/nsa310s.h index 896c329..9c84acc 100644 --- a/include/configs/nsa310s.h +++ b/include/configs/nsa310s.h @@ -67,7 +67,6 @@ /* Ethernet driver configuration */ #ifdef CONFIG_CMD_NET #define CONFIG_NETCONSOLE -#define CONFIG_NET_MULTI #define CONFIG_MVGBE_PORTS {1, 0} /* enable port 0 only */ #define CONFIG_PHY_BASE_ADR 1 #define CONFIG_RESET_PHY_R diff --git a/include/configs/pengwyn.h b/include/configs/pengwyn.h index 570c375..2fa280e 100644 --- a/include/configs/pengwyn.h +++ b/include/configs/pengwyn.h @@ -182,9 +182,6 @@ /* Disable CPSW SPL support so we fit within the 101KiB limit. */ #endif
-/* CPSW ethernet */ -#define CONFIG_NET_MULTI - /* Network */ #define CONFIG_PHY_RESET 1 #define CONFIG_PHY_NATSEMI diff --git a/include/configs/salvator-x.h b/include/configs/salvator-x.h index 5bf5731..77a12de 100644 --- a/include/configs/salvator-x.h +++ b/include/configs/salvator-x.h @@ -25,7 +25,6 @@ /* use to RPC(SPI Multi I/O Bus Controller) */
/* Ethernet RAVB */ -#define CONFIG_NET_MULTI #define CONFIG_BITBANGMII #define CONFIG_BITBANGMII_MULTI
diff --git a/include/configs/ulcb.h b/include/configs/ulcb.h index cce2456..b54e63c 100644 --- a/include/configs/ulcb.h +++ b/include/configs/ulcb.h @@ -33,7 +33,6 @@ /* use to RPC(SPI Multi I/O Bus Controller) */
/* Ethernet RAVB */ -#define CONFIG_NET_MULTI #define CONFIG_PHY_MICREL #define CONFIG_BITBANGMII #define CONFIG_BITBANGMII_MULTI diff --git a/include/configs/xilinx_zynqmp.h b/include/configs/xilinx_zynqmp.h index 1399dfd..8526ba0 100644 --- a/include/configs/xilinx_zynqmp.h +++ b/include/configs/xilinx_zynqmp.h @@ -131,7 +131,6 @@
/* Ethernet driver */ #if defined(CONFIG_ZYNQ_GEM) -# define CONFIG_NET_MULTI # define CONFIG_MII # define CONFIG_SYS_FAULT_ECHO_LINK_DOWN # define CONFIG_PHY_MARVELL
On 10/26/2017 05:27 AM, Masahiro Yamada wrote:
This macro is defined, but not referenced by anyone.
I did not touch config_whitelist.txt - the CONFIG will be dropped by the next re-sync.
Signed-off-by: Masahiro Yamada yamada.masahiro@socionext.com
include/configs/am335x_shc.h | 1 - include/configs/blanche.h | 1 - include/configs/cm_t43.h | 1 - include/configs/cyrus.h | 1 - include/configs/ls1012aqds.h | 1 - include/configs/ls1012ardb.h | 1 - include/configs/ls1043a_common.h | 1 - include/configs/nsa310s.h | 1 - include/configs/pengwyn.h | 3 --- include/configs/salvator-x.h | 1 - include/configs/ulcb.h | 1 - include/configs/xilinx_zynqmp.h | 1 - 12 files changed, 14 deletions(-)
Reviewed-by: York Sun york.sun@nxp.com
On Thu, Oct 26, 2017 at 09:24:29PM +0900, Masahiro Yamada wrote:
This macro is defined, but not referenced by anyone.
I did not touch config_whitelist.txt - the CONFIG will be dropped by the next re-sync.
Signed-off-by: Masahiro Yamada yamada.masahiro@socionext.com Reviewed-by: York Sun york.sun@nxp.com
Applied to u-boot/master, thanks!
This macro is defined, but not referenced by anyone.
I did not touch config_whitelist.txt - the CONFIG will be dropped by the next re-sync.
Signed-off-by: Masahiro Yamada yamada.masahiro@socionext.com ---
include/configs/s5pc210_universal.h | 1 - include/configs/trats.h | 1 - include/configs/trats2.h | 1 - 3 files changed, 3 deletions(-)
diff --git a/include/configs/s5pc210_universal.h b/include/configs/s5pc210_universal.h index 9859f30..7ecaefb 100644 --- a/include/configs/s5pc210_universal.h +++ b/include/configs/s5pc210_universal.h @@ -170,7 +170,6 @@ int universal_spi_read(void);
/* Download menu - Samsung common */ #define CONFIG_LCD_MENU -#define CONFIG_LCD_MENU_BOARD
/* Download menu - definitions for check keys */ #ifndef __ASSEMBLY__ diff --git a/include/configs/trats.h b/include/configs/trats.h index 5b33a3b..a34c349 100644 --- a/include/configs/trats.h +++ b/include/configs/trats.h @@ -180,7 +180,6 @@
/* Download menu - Samsung common */ #define CONFIG_LCD_MENU -#define CONFIG_LCD_MENU_BOARD
/* Download menu - definitions for check keys */ #ifndef __ASSEMBLY__ diff --git a/include/configs/trats2.h b/include/configs/trats2.h index 95c011f..6b371f4 100644 --- a/include/configs/trats2.h +++ b/include/configs/trats2.h @@ -162,7 +162,6 @@
/* Download menu - Samsung common */ #define CONFIG_LCD_MENU -#define CONFIG_LCD_MENU_BOARD
/* Download menu - definitions for check keys */ #ifndef __ASSEMBLY__
On 26/10/17 21:24, Masahiro Yamada wrote:
This macro is defined, but not referenced by anyone.
I did not touch config_whitelist.txt - the CONFIG will be dropped by the next re-sync.
Signed-off-by: Masahiro Yamada yamada.masahiro@socionext.com
include/configs/s5pc210_universal.h | 1 - include/configs/trats.h | 1 - include/configs/trats2.h | 1 - 3 files changed, 3 deletions(-)
diff --git a/include/configs/s5pc210_universal.h b/include/configs/s5pc210_universal.h index 9859f30..7ecaefb 100644 --- a/include/configs/s5pc210_universal.h +++ b/include/configs/s5pc210_universal.h @@ -170,7 +170,6 @@ int universal_spi_read(void);
/* Download menu - Samsung common */ #define CONFIG_LCD_MENU -#define CONFIG_LCD_MENU_BOARD
/* Download menu - definitions for check keys */ #ifndef __ASSEMBLY__ diff --git a/include/configs/trats.h b/include/configs/trats.h index 5b33a3b..a34c349 100644 --- a/include/configs/trats.h +++ b/include/configs/trats.h @@ -180,7 +180,6 @@
/* Download menu - Samsung common */ #define CONFIG_LCD_MENU -#define CONFIG_LCD_MENU_BOARD
/* Download menu - definitions for check keys */ #ifndef __ASSEMBLY__ diff --git a/include/configs/trats2.h b/include/configs/trats2.h index 95c011f..6b371f4 100644 --- a/include/configs/trats2.h +++ b/include/configs/trats2.h @@ -162,7 +162,6 @@
/* Download menu - Samsung common */ #define CONFIG_LCD_MENU -#define CONFIG_LCD_MENU_BOARD
/* Download menu - definitions for check keys */ #ifndef __ASSEMBLY__
Acked-by: Minkyu Kang mk7.kang@samsung.com
Thanks, Minkyu Kang.
On Thu, Oct 26, 2017 at 09:24:30PM +0900, Masahiro Yamada wrote:
This macro is defined, but not referenced by anyone.
I did not touch config_whitelist.txt - the CONFIG will be dropped by the next re-sync.
Signed-off-by: Masahiro Yamada yamada.masahiro@socionext.com Acked-by: Minkyu Kang mk7.kang@samsung.com
Applied to u-boot/master, thanks!
This macro is defined, but not referenced by anyone.
I did not touch config_whitelist.txt - the CONFIG will be dropped by the next re-sync.
Signed-off-by: Masahiro Yamada yamada.masahiro@socionext.com ---
include/configs/at91sam9n12ek.h | 1 - 1 file changed, 1 deletion(-)
diff --git a/include/configs/at91sam9n12ek.h b/include/configs/at91sam9n12ek.h index 111a7dc..67115f9 100644 --- a/include/configs/at91sam9n12ek.h +++ b/include/configs/at91sam9n12ek.h @@ -72,7 +72,6 @@ #define CONFIG_ATMEL_NAND_HW_PMECC #define CONFIG_PMECC_CAP 2 #define CONFIG_PMECC_SECTOR_SIZE 512 -#define CONFIG_PMECC_INDEX_TABLE_OFFSET 0x8000
#define CONFIG_MTD_PARTITIONS #define CONFIG_MTD_DEVICE
On Thu, Oct 26, 2017 at 09:24:31PM +0900, Masahiro Yamada wrote:
This macro is defined, but not referenced by anyone.
I did not touch config_whitelist.txt - the CONFIG will be dropped by the next re-sync.
Signed-off-by: Masahiro Yamada yamada.masahiro@socionext.com
Applied to u-boot/master, thanks!
On Thu, Oct 26, 2017 at 09:24:15PM +0900, Masahiro Yamada wrote:
The first two deletes unused i2c drivers.
The rest of the series delete unreferenced CONFIG options.
Today, I volunteered to delete 20 CONFIGs or so, but probably I will not do this again since it was time-consuming, painful work...
It is hard work, thanks for doing it!
Heiko, do you want to take the first 3 or just ack them and I'll take the series? Thanks!
Hello Tom,
Am 26.10.2017 um 16:20 schrieb Tom Rini:
On Thu, Oct 26, 2017 at 09:24:15PM +0900, Masahiro Yamada wrote:
The first two deletes unused i2c drivers.
The rest of the series delete unreferenced CONFIG options.
Today, I volunteered to delete 20 CONFIGs or so, but probably I will not do this again since it was time-consuming, painful work...
It is hard work, thanks for doing it!
Heiko, do you want to take the first 3 or just ack them and I'll take the series? Thanks!
I acked them, so please pick them up when you pick up the hole series, thanks!
bye, Heiko
2017-10-26 23:20 GMT+09:00 Tom Rini trini@konsulko.com:
On Thu, Oct 26, 2017 at 09:24:15PM +0900, Masahiro Yamada wrote:
The first two deletes unused i2c drivers.
The rest of the series delete unreferenced CONFIG options.
Today, I volunteered to delete 20 CONFIGs or so, but probably I will not do this again since it was time-consuming, painful work...
It is hard work, thanks for doing it!
Heiko, do you want to take the first 3 or just ack them and I'll take the series? Thanks!
Probably it will be possible to write a script to generate a list of unreferenced CONFIGs.
I tried to do that today, but I ended up with a crappy scripts that produces various false positives. (at least, I see hundreds of _suspicious_ options.)
Finally, I double-checked with my eyes and buildman.
participants (5)
-
Heiko Schocher -
Masahiro Yamada -
Minkyu Kang -
Tom Rini -
York Sun