Dear Kyungmin Park & Minkyu Kang,
"onenand_ipl/board/apollon/config.mk" and "onenand_ipl/board/vpac270/config.mk" define CONFIG_SYS_TEXT_BASE; do you think it is possible to move these definitions into the respective board config files and remove the then empty "config.mk" files?
Best regards,
Wolfgang Denk
Dear Wolfgang,
On 29 November 2010 05:14, Wolfgang Denk wd@denx.de wrote:
Dear Kyungmin Park & Minkyu Kang,
"onenand_ipl/board/apollon/config.mk" and "onenand_ipl/board/vpac270/config.mk" define CONFIG_SYS_TEXT_BASE; do you think it is possible to move these definitions into the respective board config files and remove the then empty "config.mk" files?
It is hard to move into board config file, because of usually use different TEXT_BASE on IPL. I think, it can be moved into Makefile directly. Then we can remove config.mk. How you think?
Thanks Minkyu Kang
Dear Minkyu Kang,
In message AANLkTik64Heh+ooov9K10pixh9h=GdxqRQYyS8Er-c-1@mail.gmail.com you wrote:
"onenand_ipl/board/apollon/config.mk" and "onenand_ipl/board/vpac270/config.mk" define CONFIG_SYS_TEXT_BASE; do you think it is possible to move these definitions into the respective board config files and remove the then empty "config.mk" files?
It is hard to move into board config file, because of usually use different TEXT_BASE on IPL.
Well, we can probably use #ifdef's, like we do for boards that boot from NAND flash, which have essentially the same situation.
I think, it can be moved into Makefile directly.
No, that's not a good idea. Makefiles should not contain configuration data. I want to move as much of this as possible into the board config files, so we have it all in a single place.
Best regards,
Wolfgang Denk
participants (2)
-
Minkyu Kang -
Wolfgang Denk