[U-Boot-Users] Bug in at91rm9200_ether.c

18 Oct
2003
18 Oct
'03
6:19 p.m.
Hi there,
I think there's terrible bug in the U-Boot ethernet driver for AT91RM9200 cpus.
The function at91rm9200_EmacWritePhy() does not write the correct data. Attached patch fixes that.
Thanks,
--
Steven Scholz
imc Measurement & Control imc Meßsysteme GmbH
Voltastr. 5 Voltastr. 5
13355 Berlin 13355 Berlin
Germany Deutschland
fon: +49 30 467090-0 Tel: 030 / 467090-0
fax: +49 30 4631576 fax: 030 / 4631576
+ diff -u ./cpu/at91rm9200/at91rm9200_ether.c.orig ./cpu/at91rm9200/at91rm9200_ether.c
--- ./cpu/at91rm9200/at91rm9200_ether.c.orig Sat Oct 18 18:14:46 2003
+++ ./cpu/at91rm9200/at91rm9200_ether.c Sat Oct 18 18:15:33 2003
@@ -341,7 +341,8 @@
{
p_mac->EMAC_MAN = (AT91C_EMAC_HIGH & ~AT91C_EMAC_LOW) |
AT91C_EMAC_CODE_802_3 | AT91C_EMAC_RW_W |
- (RegisterAddress << 18);
+ (RegisterAddress << 18) |
+ (*pOutput);
udelay (10000);

20 Oct
20 Oct
1:19 a.m.
Dear Steven,
in message 3F91682B.8010006@imc-berlin.de you wrote:
I think there's terrible bug in the U-Boot ethernet driver for AT91RM9200= cpus.
The function at91rm9200_EmacWritePhy() does not write the correct data. Attached patch fixes that.
Thanks, added. Will show up on CVS "soon".
Best regards,
Wolfgang Denk
--
Software Engineering: Embedded and Realtime Systems, Embedded Linux
Phone: (+49)-8142-4596-87 Fax: (+49)-8142-4596-88 Email: wd@denx.de
Eschew obfuscation.
7870
Age (days ago)
7871
Last active (days ago)
1 comments
2 participants
participants (2)
-
Steven Scholz
-
Wolfgang Denk