Re: [U-Boot] Regression in bootcmd handling in v2015.04-rc3?
On Wed, Mar 11, 2015 at 10:48:25PM +0100, Karsten Merker wrote:
On Wed, Mar 11, 2015 at 03:35:02PM -0600, Stephen Warren wrote:
On 03/11/2015 03:21 PM, Karsten Merker wrote:
As a result I will need to update the Debian installation documentation. As I would like to do it right this time ;-), I just would like to get the confirmation that the device-specific commands, such as "run bootcmd_usb0", are an "official" interface that is going to stay in future u-boot versions, or - if they are not - get the information what is the offical method for booting from a specific device at the prompt.
We don't actually have an official specification of that at present. doc/README.distro should probably cover this but doesn't.
Suffice to say, I use those macros all the time, and I intended them to be used this way when I wrote the boot scripts. So, if I notice a change that stops them from working without extremely good reason, I'll complain.
Thanks, I'll update the Debian docs accordingly.
So then we're settled on "run bootcmd_usb" was unintended but "run bootcmd_usb0" is and must remain so if anything a slight update to doc/README.distro would be expected and we're good, right? Thanks guys!
Tom Rini trini@konsulko.com wrote:
So then we're settled on "run bootcmd_usb" was unintended but "run bootcmd_usb0" is and must remain so if anything a slight update to doc/README.distro would be expected and we're good, right? Thanks guys!
Following is a patch to add such a description to doc/README.distro.
Regards, Karsten
Karsten Merker (1): Document config_distro_bootcmd environment variables for interactive booting.
doc/README.distro | 17 +++++++++++++++++ 1 file changed, 17 insertions(+)
Signed-off-by: Karsten Merker merker@debian.org --- doc/README.distro | 17 +++++++++++++++++ 1 file changed, 17 insertions(+)
diff --git a/doc/README.distro b/doc/README.distro index dd0f1c7..5150eda 100644 --- a/doc/README.distro +++ b/doc/README.distro @@ -1,6 +1,7 @@ /* * (C) Copyright 2014 Red Hat Inc. * Copyright (c) 2014-2015, NVIDIA CORPORATION. All rights reserved. + * Copyright (c) 2015 K. Merker merker@debian.org * * SPDX-License-Identifier: GPL-2.0+ */ @@ -339,3 +340,19 @@ scan_dev_for_scripts:
If you want to disable boot.scr on all disks, set the value to something innocuous, e.g. setenv scan_dev_for_scripts true. + + +Interactively booting from a specific device at the u-boot prompt +================================================================= + +For interactively booting from a user-selected device at the u-boot command +prompt, the environment provides predefined bootcmd_<target> variables for +every target defined in boot_targets, which can be run be the user. + +Examples: + + - run bootcmd_usb0 + boots from the first USB mass storage device + + - run bootcmd_mmc1 + boots from the second MMC device
On 03/19/2015 01:41 PM, Karsten Merker wrote:
A brief description would be nice.
diff --git a/doc/README.distro b/doc/README.distro
+Interactively booting from a specific device at the u-boot prompt +=================================================================
+For interactively booting from a user-selected device at the u-boot command +prompt, the environment provides predefined bootcmd_<target> variables for +every target defined in boot_targets, which can be run be the user.
+Examples:
- run bootcmd_usb0
- boots from the first USB mass storage device
- run bootcmd_mmc1
- boots from the second MMC device
Should we enumerate all the possible device types, e.g. include bootcmd_sata0, bootcmd_ide0, ...?
We should definitely mention that bootcmd_usb is an internal implementation detail even though bootcmd_usb0 is a command that we intend users to run. In the text, perhaps rephrase bootcmd_<target> as bootcmd_<devtype><devnum>, and note that <devnum> is not optional in the command name?
participants (3)
-
Karsten Merker -
Stephen Warren -
Tom Rini