[U-Boot] [PATCH v3] mmc: display mmc list information like mmc_legacy type
From: Xu Ziyuan xzy.xu@rock-chips.com
It's nicer to see this:
=> mmc list dwmmc@ff0c0000: 0 dwmmc@ff0f0000: 1 (eMMC)
than this:
=> mmc list dwmmc@ff0c0000: 0dwmmc@ff0f0000: 1 (eMMC)
With the former, it's much clearer which mmc devices are on.
Signed-off-by: Ziyuan Xu xzy.xu@rock-chips.com
---
Changes in v3: - Fix nits
Changes in v2: - Update commit from Jaehoon
drivers/mmc/mmc-uclass.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/mmc-uclass.c b/drivers/mmc/mmc-uclass.c index 38ced41..beebc70 100644 --- a/drivers/mmc/mmc-uclass.c +++ b/drivers/mmc/mmc-uclass.c @@ -169,7 +169,7 @@ void print_mmc_devices(char separator)
for (uclass_first_device(UCLASS_MMC, &dev); dev; - uclass_next_device(&dev)) { + uclass_next_device(&dev), first = false) { struct mmc *m = mmc_get_mmc_dev(dev);
if (!first) {
On 22 July 2016 at 21:11, Ziyuan Xu xzy.xu@rock-chips.com wrote:
From: Xu Ziyuan xzy.xu@rock-chips.com
It's nicer to see this:
=> mmc list dwmmc@ff0c0000: 0 dwmmc@ff0f0000: 1 (eMMC)
than this:
=> mmc list dwmmc@ff0c0000: 0dwmmc@ff0f0000: 1 (eMMC)
With the former, it's much clearer which mmc devices are on.
Signed-off-by: Ziyuan Xu xzy.xu@rock-chips.com
Changes in v3:
- Fix nits
Changes in v2:
- Update commit from Jaehoon
drivers/mmc/mmc-uclass.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Simon Glass sjg@chromium.org
On 07/25/2016 11:07 AM, Simon Glass wrote:
On 22 July 2016 at 21:11, Ziyuan Xu xzy.xu@rock-chips.com wrote:
From: Xu Ziyuan xzy.xu@rock-chips.com
It's nicer to see this:
=> mmc list dwmmc@ff0c0000: 0 dwmmc@ff0f0000: 1 (eMMC)
than this:
=> mmc list dwmmc@ff0c0000: 0dwmmc@ff0f0000: 1 (eMMC)
With the former, it's much clearer which mmc devices are on.
Signed-off-by: Ziyuan Xu xzy.xu@rock-chips.com
Changes in v3:
- Fix nits
Changes in v2:
- Update commit from Jaehoon
drivers/mmc/mmc-uclass.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Simon Glass sjg@chromium.org
Reviewed-by: Jaehoon Chung jh80.chung@samsung.com Tested-by: Jaehoon Chung jh80.chung@samsung.com
On 07/23/2016 12:11 PM, Xu Ziyuan wrote:
From: Xu Ziyuan xzy.xu@rock-chips.com
It's nicer to see this:
=> mmc list dwmmc@ff0c0000: 0 dwmmc@ff0f0000: 1 (eMMC)
than this:
=> mmc list dwmmc@ff0c0000: 0dwmmc@ff0f0000: 1 (eMMC)
With the former, it's much clearer which mmc devices are on.
Signed-off-by: Ziyuan Xu xzy.xu@rock-chips.com Acked-by: Simon Glass sjg@chromium.org Reviewed-by: Jaehoon Chung jh80.chung@samsung.com Tested-by: Jaehoon Chung jh80.chung@samsung.com
Applied on u-boot-mmc. Thanks!
Best Regards, Jaehoon Chung
Changes in v3:
- Fix nits
Changes in v2:
- Update commit from Jaehoon
drivers/mmc/mmc-uclass.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/mmc-uclass.c b/drivers/mmc/mmc-uclass.c index 38ced41..beebc70 100644 --- a/drivers/mmc/mmc-uclass.c +++ b/drivers/mmc/mmc-uclass.c @@ -169,7 +169,7 @@ void print_mmc_devices(char separator)
for (uclass_first_device(UCLASS_MMC, &dev); dev;
uclass_next_device(&dev)) {
uclass_next_device(&dev), first = false) {struct mmc *m = mmc_get_mmc_dev(dev);
if (!first) {
participants (3)
-
Jaehoon Chung -
Simon Glass -
Ziyuan Xu