[U-Boot] [RESEND] [PATCH] fastboot: Proper download gadget unregister and clear when cable is missing

newer
[U-Boot] [PATCH v3 1/3] ARM: mx6:...

Paul Kocialkowski

28 Mar 2015 28 Mar '15

6:22 p.m.

Signed-off-by: Paul Kocialkowski contact@paulk.fr --- common/cmd_fastboot.c | 2 ++ 1 file changed, 2 insertions(+)

diff --git a/common/cmd_fastboot.c b/common/cmd_fastboot.c index 346ab80..7956a5b 100644 --- a/common/cmd_fastboot.c +++ b/common/cmd_fastboot.c @@ -23,6 +23,8 @@ static int do_fastboot(cmd_tbl_t *cmdtp, int flag, int argc, char *const argv[]) if (!g_dnl_board_usb_cable_connected()) { puts("\rUSB cable not detected.\n" \ "Command exit.\n"); + g_dnl_unregister(); + g_dnl_clear_detach(); return CMD_RET_FAILURE; }

-- 1.9.1

Show replies by date

Lukasz Majewski

30 Mar 30 Mar

10:06 a.m.

New subject: [U-Boot] [RESEND] [PATCH] fastboot: Proper download gadget unregister and clear when cable is missing

Hi Paul,

...

Signed-off-by: Paul Kocialkowski contact@paulk.fr

common/cmd_fastboot.c | 2 ++ 1 file changed, 2 insertions(+)

diff --git a/common/cmd_fastboot.c b/common/cmd_fastboot.c index 346ab80..7956a5b 100644 --- a/common/cmd_fastboot.c +++ b/common/cmd_fastboot.c @@ -23,6 +23,8 @@ static int do_fastboot(cmd_tbl_t *cmdtp, int flag, int argc, char *const argv[]) if (!g_dnl_board_usb_cable_connected()) { puts("\rUSB cable not detected.\n" \ "Command exit.\n");
g_dnl_unregister();
g_dnl_clear_detach();
return CMD_RET_FAILURE; }

This is just a minor comment - in your future patches please add some commit message even for this very short patch.

Despite that,

Acked-by: Lukasz Majewski l.majewski@samsung.com

If other (Marek, Tom) don't mind I will take this through -dfu tree.

-- Best regards, Lukasz Majewski Samsung R&D Institute Poland (SRPOL) | Linux Platform Group

Paul Kocialkowski

3:28 p.m.

New subject: [U-Boot] [RESEND] [PATCH] fastboot: Proper download gadget unregister and clear when cable is missing

Le lundi 30 mars 2015 à 10:06 +0200, Lukasz Majewski a écrit :

...

Hi Paul,

...
Signed-off-by: Paul Kocialkowski contact@paulk.fr

common/cmd_fastboot.c | 2 ++ 1 file changed, 2 insertions(+)

diff --git a/common/cmd_fastboot.c b/common/cmd_fastboot.c index 346ab80..7956a5b 100644 --- a/common/cmd_fastboot.c +++ b/common/cmd_fastboot.c @@ -23,6 +23,8 @@ static int do_fastboot(cmd_tbl_t *cmdtp, int flag, int argc, char *const argv[]) if (!g_dnl_board_usb_cable_connected()) { puts("\rUSB cable not detected.\n" \ "Command exit.\n");
g_dnl_unregister();
g_dnl_clear_detach();
return CMD_RET_FAILURE; }
This is just a minor comment - in your future patches please add some commit message even for this very short patch.

Understood.

...

Despite that,

Acked-by: Lukasz Majewski l.majewski@samsung.com

If other (Marek, Tom) don't mind I will take this through -dfu tree.

Thanks!

-- Paul Kocialkowski, Replicant developer Replicant is a fully free Android distribution running on several devices, a free software mobile operating system putting the emphasis on freedom and privacy/security. Website: http://www.replicant.us/ Blog: http://blog.replicant.us/ Wiki/tracker/forums: http://redmine.replicant.us/

Marek Vasut

2 Apr 2 Apr

7:11 p.m.

On Monday, March 30, 2015 at 10:06:13 AM, Lukasz Majewski wrote:

...

Hi Paul,

...
Signed-off-by: Paul Kocialkowski contact@paulk.fr

common/cmd_fastboot.c | 2 ++ 1 file changed, 2 insertions(+)

diff --git a/common/cmd_fastboot.c b/common/cmd_fastboot.c index 346ab80..7956a5b 100644 --- a/common/cmd_fastboot.c +++ b/common/cmd_fastboot.c @@ -23,6 +23,8 @@ static int do_fastboot(cmd_tbl_t *cmdtp, int flag, int argc, char *const argv[]) if (!g_dnl_board_usb_cable_connected()) { puts("\rUSB cable not detected.\n" \
     "Command exit.\n");
g_dnl_unregister();
g_dnl_clear_detach();
return CMD_RET_FAILURE;

}
This is just a minor comment - in your future patches please add some commit message even for this very short patch.

Despite that,

Acked-by: Lukasz Majewski l.majewski@samsung.com

If other (Marek, Tom) don't mind I will take this through -dfu tree.

Please do, thanks!

btw. is this for current or next release ?

Best regards, Marek Vasut

Lukasz Majewski

3 Apr 3 Apr

9:35 a.m.

New subject: [U-Boot] [RESEND] [PATCH] fastboot: Proper download gadget unregister and clear when cable is missing

Hi Marek,

...

On Monday, March 30, 2015 at 10:06:13 AM, Lukasz Majewski wrote:

...
Hi Paul,

...
Signed-off-by: Paul Kocialkowski contact@paulk.fr

common/cmd_fastboot.c | 2 ++ 1 file changed, 2 insertions(+)

diff --git a/common/cmd_fastboot.c b/common/cmd_fastboot.c index 346ab80..7956a5b 100644 --- a/common/cmd_fastboot.c +++ b/common/cmd_fastboot.c @@ -23,6 +23,8 @@ static int do_fastboot(cmd_tbl_t *cmdtp, int flag, int argc, char *const argv[]) if (!g_dnl_board_usb_cable_connected()) { puts("\rUSB cable not detected.\n" \
     "Command exit.\n");
g_dnl_unregister();
g_dnl_clear_detach();
return CMD_RET_FAILURE;

}
This is just a minor comment - in your future patches please add some commit message even for this very short patch.

Despite that,

Acked-by: Lukasz Majewski l.majewski@samsung.com

If other (Marek, Tom) don't mind I will take this through -dfu tree.
Please do, thanks!

btw. is this for current or next release ?

Best regards, Marek Vasut

I thought to add this code in the next merge window, since now we have -rc5.

The v2015.04 is scheduled for 13.04.

-- Best regards, Lukasz Majewski Samsung R&D Institute Poland (SRPOL) | Linux Platform Group

Marek Vasut

10:09 a.m.

On Friday, April 03, 2015 at 09:35:00 AM, Lukasz Majewski wrote:

...

Hi Marek,

...
On Monday, March 30, 2015 at 10:06:13 AM, Lukasz Majewski wrote:

...
Hi Paul,

...
Signed-off-by: Paul Kocialkowski contact@paulk.fr

common/cmd_fastboot.c | 2 ++ 1 file changed, 2 insertions(+)

diff --git a/common/cmd_fastboot.c b/common/cmd_fastboot.c index 346ab80..7956a5b 100644 --- a/common/cmd_fastboot.c +++ b/common/cmd_fastboot.c @@ -23,6 +23,8 @@ static int do_fastboot(cmd_tbl_t *cmdtp, int flag, int argc, char *const argv[]) if (!g_dnl_board_usb_cable_connected()) { puts("\rUSB cable not detected.\n" \
     "Command exit.\n");
g_dnl_unregister();
g_dnl_clear_detach();
return CMD_RET_FAILURE;

}
This is just a minor comment - in your future patches please add some commit message even for this very short patch.

Despite that,

Acked-by: Lukasz Majewski l.majewski@samsung.com

If other (Marek, Tom) don't mind I will take this through -dfu tree.
Please do, thanks!

btw. is this for current or next release ?

Best regards, Marek Vasut
I thought to add this code in the next merge window, since now we have -rc5.

The v2015.04 is scheduled for 13.04.

Roger that, thanks!

Best regards, Marek Vasut

Lukasz Majewski

8 Apr 8 Apr

11:01 a.m.

New subject: [U-Boot] [RESEND] [PATCH] fastboot: Proper download gadget unregister and clear when cable is missing

Hi Paul,

...

Signed-off-by: Paul Kocialkowski contact@paulk.fr

common/cmd_fastboot.c | 2 ++ 1 file changed, 2 insertions(+)

diff --git a/common/cmd_fastboot.c b/common/cmd_fastboot.c index 346ab80..7956a5b 100644 --- a/common/cmd_fastboot.c +++ b/common/cmd_fastboot.c @@ -23,6 +23,8 @@ static int do_fastboot(cmd_tbl_t *cmdtp, int flag, int argc, char *const argv[]) if (!g_dnl_board_usb_cable_connected()) { puts("\rUSB cable not detected.\n" \ "Command exit.\n");
g_dnl_unregister();
g_dnl_clear_detach();
return CMD_RET_FAILURE; }

Applied to u-boot-dfu branch.

Thanks!

-- Best regards, Lukasz Majewski Samsung R&D Institute Poland (SRPOL) | Linux Platform Group

3686

Age (days ago)

3697

Last active (days ago)

List overview

Download

6 comments

3 participants

tags (0)

participants (3)

Lukasz Majewski
Marek Vasut
Paul Kocialkowski