[PATCH 0/2] Fixes i.MX93 11x11 EVK boot failures

This series fixes i.MX93 11x11 EVK boot failures.
Sébastien Szymanski (2): arm: dts: imx93-11x11-evk: add bootph-some-ram property dm: adc: imx93-adc depends on ADC (fix boot)
arch/arm/dts/imx93-11x11-evk-u-boot.dtsi | 20 ++++++++++++++++++++ configs/imx93_11x11_evk_defconfig | 1 + drivers/adc/Kconfig | 1 + 3 files changed, 22 insertions(+)

i.MX93 11x11 EVK fails to boot:
U-Boot SPL 2023.10-00558-g65b9b3462bec-dirty (Oct 03 2023 - 17:40:10 +0200) SOC: 0xa0009300 LC: 0x40010 M33 prepare ok Normal Boot Trying to boot from BOOTROM Boot Stage: Primary boot image offset 0x8000, pagesize 0x200, ivt offset 0x0 Load image from 0x44400 by ROM_API NOTICE: BL31: v2.8(release):android-13.0.0_2.0.0-0-ge4b2dbfa52f5 NOTICE: BL31: Built : 17:52:46, Sep 28 2023
That's because commit 9e644284ab81 ("dm: core: Report bootph-pre-ram/sram node as pre-reloc after relocation"):
"[This] changes behavior of what nodes are bound in the U-Boot proper pre-relocation phase. Change to bootph-all or add bootph-some-ram prop to restore prior behavior."
Fix this by adding bootph-some-ram prop as suggested by the commit above.
Fixes: 9e644284ab81 ("dm: core: Report bootph-pre-ram/sram node as pre-reloc after relocation") Signed-off-by: Sébastien Szymanski sebastien.szymanski@armadeus.com --- arch/arm/dts/imx93-11x11-evk-u-boot.dtsi | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+)
diff --git a/arch/arm/dts/imx93-11x11-evk-u-boot.dtsi b/arch/arm/dts/imx93-11x11-evk-u-boot.dtsi index 5b465e2dbd9d..2d9c9618ce2d 100644 --- a/arch/arm/dts/imx93-11x11-evk-u-boot.dtsi +++ b/arch/arm/dts/imx93-11x11-evk-u-boot.dtsi @@ -8,6 +8,7 @@ compatible = "wdt-reboot"; wdt = <&wdog3>; bootph-pre-ram; + bootph-some-ram; };
firmware { @@ -30,19 +31,23 @@
&aips2 { bootph-pre-ram; + bootph-some-ram; };
&aips3 { bootph-pre-ram; + bootph-some-ram; };
&iomuxc { bootph-pre-ram; + bootph-some-ram; };
®_usdhc2_vmmc { u-boot,off-on-delay-us = <20000>; bootph-pre-ram; + bootph-some-ram; };
&pinctrl_reg_usdhc2_vmmc { @@ -51,59 +56,73 @@
&pinctrl_uart1 { bootph-pre-ram; + bootph-some-ram; };
&pinctrl_usdhc2_gpio { bootph-pre-ram; + bootph-some-ram; };
&pinctrl_usdhc2 { bootph-pre-ram; + bootph-some-ram; };
&gpio1 { bootph-pre-ram; + bootph-some-ram; };
&gpio2 { bootph-pre-ram; + bootph-some-ram; };
&gpio3 { bootph-pre-ram; + bootph-some-ram; };
&gpio4 { bootph-pre-ram; + bootph-some-ram; };
&lpuart1 { bootph-pre-ram; + bootph-some-ram; };
&usdhc1 { bootph-pre-ram; + bootph-some-ram; };
&usdhc2 { bootph-pre-ram; + bootph-some-ram; fsl,signal-voltage-switch-extra-delay-ms = <8>; };
&lpi2c2 { bootph-pre-ram; + bootph-some-ram; };
&{/soc@0/bus@44000000/i2c@44350000/pmic@25} { bootph-pre-ram; + bootph-some-ram; };
&{/soc@0/bus@44000000/i2c@44350000/pmic@25/regulators} { bootph-pre-ram; + bootph-some-ram; };
&pinctrl_lpi2c2 { bootph-pre-ram; + bootph-some-ram; };
&fec { @@ -124,5 +143,6 @@
&s4muap { bootph-pre-ram; + bootph-some-ram; status = "okay"; };

On Wed, Oct 4, 2023 at 6:09 AM Sébastien Szymanski sebastien.szymanski@armadeus.com wrote:
i.MX93 11x11 EVK fails to boot:
U-Boot SPL 2023.10-00558-g65b9b3462bec-dirty (Oct 03 2023 - 17:40:10 +0200) SOC: 0xa0009300 LC: 0x40010 M33 prepare ok Normal Boot Trying to boot from BOOTROM Boot Stage: Primary boot image offset 0x8000, pagesize 0x200, ivt offset 0x0 Load image from 0x44400 by ROM_API NOTICE: BL31: v2.8(release):android-13.0.0_2.0.0-0-ge4b2dbfa52f5 NOTICE: BL31: Built : 17:52:46, Sep 28 2023
That's because commit 9e644284ab81 ("dm: core: Report bootph-pre-ram/sram node as pre-reloc after relocation"):
"[This] changes behavior of what nodes are bound in the U-Boot proper pre-relocation phase. Change to bootph-all or add bootph-some-ram prop to restore prior behavior."
Fix this by adding bootph-some-ram prop as suggested by the commit above.
Fixes: 9e644284ab81 ("dm: core: Report bootph-pre-ram/sram node as pre-reloc after relocation") Signed-off-by: Sébastien Szymanski sebastien.szymanski@armadeus.com
Yes, it is getting harder and harder to keep track of all these boot properties.
Thanks for fixing it:
Reviewed-by: Fabio Estevam festevam@gmail.com

The i.MX93 11x11 EVK fails to boot with following error:
Model: NXP i.MX93 11X11 EVK board DRAM: 2 GiB Error binding driver 'imx93-adc': -96 Some drivers failed to bind Error binding driver 'simple_bus': -96 Some drivers failed to bind Error binding driver 'simple_bus': -96 Some drivers failed to bind initcall sequence 00000000fffb8f28 failed at call 000000008021e0d4 (err=-96) ### ERROR ### Please RESET the board ###
That's because since commit e7ff54d96303 ("imx93_evk: defconfig: add adc support") CONFIG_ADC_IMX93 is enabled but CONFIG_ADC is not. Fix this by enabling CONFIG_ADC in imx93_11x11_evk_defconfig.
Make sure this situation won't happen again in future i.MX93 defconfig by making CONFIG_ADC_IMX93 depend on CONFIG_ADC.
Signed-off-by: Sébastien Szymanski sebastien.szymanski@armadeus.com --- configs/imx93_11x11_evk_defconfig | 1 + drivers/adc/Kconfig | 1 + 2 files changed, 2 insertions(+)
diff --git a/configs/imx93_11x11_evk_defconfig b/configs/imx93_11x11_evk_defconfig index 89130c437d6d..7a7978c280a5 100644 --- a/configs/imx93_11x11_evk_defconfig +++ b/configs/imx93_11x11_evk_defconfig @@ -81,6 +81,7 @@ CONFIG_NET_RANDOM_ETHADDR=y CONFIG_SPL_DM=y CONFIG_REGMAP=y CONFIG_SYSCON=y +CONFIG_ADC=y CONFIG_ADC_IMX93=y CONFIG_CPU=y CONFIG_CPU_IMX=y diff --git a/drivers/adc/Kconfig b/drivers/adc/Kconfig index 4336732dee56..a01d73846b74 100644 --- a/drivers/adc/Kconfig +++ b/drivers/adc/Kconfig @@ -66,6 +66,7 @@ config STM32_ADC
config ADC_IMX93 bool "Enable NXP IMX93 ADC driver" + depends on ADC help This enables basic driver for NXP IMX93 ADC. It provides:

On Wed, Oct 4, 2023 at 6:09 AM Sébastien Szymanski sebastien.szymanski@armadeus.com wrote:
The i.MX93 11x11 EVK fails to boot with following error:
Model: NXP i.MX93 11X11 EVK board DRAM: 2 GiB Error binding driver 'imx93-adc': -96 Some drivers failed to bind Error binding driver 'simple_bus': -96 Some drivers failed to bind Error binding driver 'simple_bus': -96 Some drivers failed to bind initcall sequence 00000000fffb8f28 failed at call 000000008021e0d4 (err=-96) ### ERROR ### Please RESET the board ###
That's because since commit e7ff54d96303 ("imx93_evk: defconfig: add adc support") CONFIG_ADC_IMX93 is enabled but CONFIG_ADC is not. Fix this by enabling CONFIG_ADC in imx93_11x11_evk_defconfig.
Make sure this situation won't happen again in future i.MX93 defconfig by making CONFIG_ADC_IMX93 depend on CONFIG_ADC.
Signed-off-by: Sébastien Szymanski sebastien.szymanski@armadeus.com
Reviewed-by: Fabio Estevam festevam@gmail.com
participants (2)
-
Fabio Estevam
-
Sébastien Szymanski