[U-Boot] [PATCH] drivers/net/fec: phy_init: remove redundant logic

The phy_connect_dev(...) function from phy.c does all the handling (inclusive catching fixed-link).
So we drop here the single steps and call just phy_connect_dev(...).
Signed-off-by: Hannes Schmelzer hannes.schmelzer@br-automation.com
---
drivers/net/fec_mxc.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c index 1a59026..3e75fba 100644 --- a/drivers/net/fec_mxc.c +++ b/drivers/net/fec_mxc.c @@ -1284,22 +1284,16 @@ static int fec_phy_init(struct fec_priv *priv, struct udevice *dev) { struct phy_device *phydev; int addr; - int mask = 0xffffffff;
addr = device_get_phy_addr(dev); - if (addr >= 0) - mask = 1 << addr; - #ifdef CONFIG_FEC_MXC_PHYADDR - mask = 1 << CONFIG_FEC_MXC_PHYADDR; + addr = CONFIG_FEC_MXC_PHYADDR; #endif
- phydev = phy_find_by_mask(priv->bus, mask, priv->interface); + phydev = phy_connect(priv->bus, addr, dev, priv->interface); if (!phydev) return -ENODEV;
- phy_connect_dev(phydev, dev); - priv->phydev = phydev; phy_config(phydev);

On Fri, Feb 15, 2019 at 3:30 AM Hannes Schmelzer hannes.schmelzer@br-automation.com wrote:
The phy_connect_dev(...) function from phy.c does all the handling (inclusive catching fixed-link).
So we drop here the single steps and call just phy_connect_dev(...).
Signed-off-by: Hannes Schmelzer hannes.schmelzer@br-automation.com
Acked-by: Joe Hershberger joe.hershberger@ni.com
participants (2)
-
Hannes Schmelzer
-
Joe Hershberger