[U-Boot] [PATCH v1] colibri_imx7: provide proper node name to pmic_get
From: Igor Opaniuk igor.opaniuk@toradex.com
Implementation of pmic_get() uses uclass_find_device_by_name(), which behaviour was changed in 4213609cc7 ("drivers: core: use strcmp when find device by name"). Now we have to supply full node name with unit address.
Fixes boot issue: U-Boot 2019.07-00788-g0ef6e69a1e-dirty (Jul 19 2019 - 15:27:02 +0300)
CPU: Freescale i.MX7D rev1.3 1000 MHz (running at 792 MHz) CPU: Extended Commercial temperature grade (-20C to 105C) at 41C Reset cause: POR DRAM: 512 MiB initcall sequence 9ffd3a4c failed at call 87803c61 (err=-19) ERROR Please RESET the board
Fixes: 4213609cc7("drivers: core: use strcmp when find device by name") Signed-off-by: Igor Opaniuk igor.opaniuk@toradex.com ---
board/toradex/colibri_imx7/colibri_imx7.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/board/toradex/colibri_imx7/colibri_imx7.c b/board/toradex/colibri_imx7/colibri_imx7.c index 0eb83474c4..c001316591 100644 --- a/board/toradex/colibri_imx7/colibri_imx7.c +++ b/board/toradex/colibri_imx7/colibri_imx7.c @@ -274,7 +274,7 @@ int power_init_board(void) int ret;
- ret = pmic_get("rn5t567", &dev); + ret = pmic_get("rn5t567@33", &dev); if (ret) return ret; ver = pmic_reg_read(dev, RN5T567_LSIVER); @@ -308,7 +308,7 @@ void reset_cpu(ulong addr) { struct udevice *dev;
- pmic_get("rn5t567", &dev); + pmic_get("rn5t567@33", &dev);
/* Use PMIC to reset, set REPWRTIM to 0 and REPWRON to 1 */ pmic_reg_write(dev, RN5T567_REPCNT, 0x1);
On Mon, Jul 22, 2019 at 12:46 PM Igor Opaniuk igor.opaniuk@gmail.com wrote:
From: Igor Opaniuk igor.opaniuk@toradex.com
Implementation of pmic_get() uses uclass_find_device_by_name(), which behaviour was changed in 4213609cc7 ("drivers: core: use strcmp when find device by name"). Now we have to supply full node name with unit address.
Fixes boot issue: U-Boot 2019.07-00788-g0ef6e69a1e-dirty (Jul 19 2019 - 15:27:02 +0300)
CPU: Freescale i.MX7D rev1.3 1000 MHz (running at 792 MHz) CPU: Extended Commercial temperature grade (-20C to 105C) at 41C Reset cause: POR DRAM: 512 MiB initcall sequence 9ffd3a4c failed at call 87803c61 (err=-19) ERROR Please RESET the board
Fixes: 4213609cc7("drivers: core: use strcmp when find device by name") Signed-off-by: Igor Opaniuk igor.opaniuk@toradex.com
Reviewed-by: Oleksandr Suvorov oleksandr.suvorov@toradex.com
board/toradex/colibri_imx7/colibri_imx7.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/board/toradex/colibri_imx7/colibri_imx7.c b/board/toradex/colibri_imx7/colibri_imx7.c index 0eb83474c4..c001316591 100644 --- a/board/toradex/colibri_imx7/colibri_imx7.c +++ b/board/toradex/colibri_imx7/colibri_imx7.c @@ -274,7 +274,7 @@ int power_init_board(void) int ret;
ret = pmic_get("rn5t567", &dev);
ret = pmic_get("rn5t567@33", &dev); if (ret) return ret; ver = pmic_reg_read(dev, RN5T567_LSIVER);@@ -308,7 +308,7 @@ void reset_cpu(ulong addr) { struct udevice *dev;
pmic_get("rn5t567", &dev);
pmic_get("rn5t567@33", &dev); /* Use PMIC to reset, set REPWRTIM to 0 and REPWRON to 1 */ pmic_reg_write(dev, RN5T567_REPCNT, 0x1);-- 2.17.1
U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
participants (2)
-
Igor Opaniuk -
Oleksandr Suvorov