Re: [U-Boot] [PATCH 10/10] dm: Select CONFIG_SPL_GPIO_SUPPORT on OMAP
Dear Otavio Salvador,
On Sat, Jul 21, 2012 at 12:02 PM, Marek Vasut marex@denx.de wrote:
This fixes the breakage with SPL on most OMAP boards after the GPIO driver was moved.
It seems logical this to be merged on the GPIO move patch. Any reason to not do that?
This is rather a fix, maybe it should have been ordered before the GPIO move patch even.
Best regards, Marek Vasut
On Sat, Jul 21, 2012 at 2:50 PM, Marek Vasut marex@denx.de wrote:
Dear Otavio Salvador,
On Sat, Jul 21, 2012 at 12:02 PM, Marek Vasut marex@denx.de wrote:
This fixes the breakage with SPL on most OMAP boards after the GPIO driver was moved.
It seems logical this to be merged on the GPIO move patch. Any reason to not do that?
This is rather a fix, maybe it should have been ordered before the GPIO move patch even.
If it were working before it is not a fix ... but a required change for it to work.
I usually prefer to have changes that allow for bisect to run fine and this might cause a build failure, as far as I can see...
Dear Otavio Salvador,
On Sat, Jul 21, 2012 at 2:50 PM, Marek Vasut marex@denx.de wrote:
Dear Otavio Salvador,
On Sat, Jul 21, 2012 at 12:02 PM, Marek Vasut marex@denx.de wrote:
This fixes the breakage with SPL on most OMAP boards after the GPIO driver was moved.
It seems logical this to be merged on the GPIO move patch. Any reason to not do that?
This is rather a fix, maybe it should have been ordered before the GPIO move patch even.
If it were working before it is not a fix ... but a required change for it to work.
I usually prefer to have changes that allow for bisect to run fine and this might cause a build failure, as far as I can see...
So let's reorder those patches so this goes before the GPIO move patch and be done with it.
Best regards, Marek Vasut
On Sat, Jul 21, 2012 at 2:58 PM, Marek Vasut marex@denx.de wrote:
On Sat, Jul 21, 2012 at 2:50 PM, Marek Vasut marex@denx.de wrote:
Dear Otavio Salvador,
On Sat, Jul 21, 2012 at 12:02 PM, Marek Vasut marex@denx.de wrote:
This fixes the breakage with SPL on most OMAP boards after the GPIO driver was moved.
It seems logical this to be merged on the GPIO move patch. Any reason to not do that?
This is rather a fix, maybe it should have been ordered before the GPIO move patch even.
If it were working before it is not a fix ... but a required change for it to work.
I usually prefer to have changes that allow for bisect to run fine and this might cause a build failure, as far as I can see...
So let's reorder those patches so this goes before the GPIO move patch and be done with it.
Works for me. :-)
participants (2)
-
Marek Vasut -
Otavio Salvador