Re: [U-Boot] [PATCH v3 4/8] armv8: Add workaround for USB erratum A-009007
On 02/16/2017 01:12 PM, york.sun@nxp.com wrote:
On 02/03/2017 06:08 AM, Suresh Gupta wrote:
<snip>
+static void erratum_a009007(void) +{ +/* TODO:implement the out_be16 instead of writew which is taking +little endian style */
Did you mean to remind yourself to finish this before sending this patch? You know we already have out_be16(), don't you?
Suresh,
Are you going to send an update?
York
Hi York,
It is not good idea to change the values of all macro at this time as the code tested on different platforms. If required, I will remove the TODO statement.
What you say.
Thanks SuresH
-----Original Message----- From: york sun Sent: Thursday, February 23, 2017 11:18 PM To: Suresh Gupta suresh.gupta@nxp.com Cc: u-boot@lists.denx.de; Scott Wood scott.wood@nxp.com; Leo Li leoyang.li@nxp.com; Sriram Dash sriram.dash@nxp.com; Rajesh Bhagat rajesh.bhagat@nxp.com Subject: Re: [PATCH v3 4/8] armv8: Add workaround for USB erratum A-009007
On 02/16/2017 01:12 PM, mailto:york.sun@nxp.com wrote:
On 02/03/2017 06:08 AM, Suresh Gupta wrote:
<snip>
+static void erratum_a009007(void) +{ +/* TODO:implement the out_be16 instead of writew which is taking +little endian style */
Did you mean to remind yourself to finish this before sending this patch? You know we already have out_be16(), don't you?
Suresh,
Are you going to send an update?
York
On 02/23/2017 11:19 PM, Suresh Gupta wrote:
Hi York,
It is not good idea to change the values of all macro at this time as the code tested on different platforms.
I am not talking about any value change. You are using writew. Why not using out_be16 as you thought?
York
-----Original Message----- From: york sun Sent: Friday, February 24, 2017 10:31 PM To: Suresh Gupta suresh.gupta@nxp.com Cc: u-boot@lists.denx.de; Scott Wood scott.wood@nxp.com; Leo Li leoyang.li@nxp.com; Sriram Dash sriram.dash@nxp.com; Rajesh Bhagat rajesh.bhagat@nxp.com Subject: Re: [PATCH v3 4/8] armv8: Add workaround for USB erratum A-009007
On 02/23/2017 11:19 PM, Suresh Gupta wrote:
Hi York,
It is not good idea to change the values of all macro at this time as the code
tested on different platforms.
I am not talking about any value change. You are using writew. Why not using out_be16 as you thought?
For now all values in macro (like USB_PHY_RX_EQ_VAL_2) are swapped and if I want to use out_be16, then I need to change values of all macros, which intern require testing on all platform. That's the reason, I don't want to make such changes and break the working USB
York
On 02/28/2017 02:52 AM, Suresh Gupta wrote:
-----Original Message----- From: york sun Sent: Friday, February 24, 2017 10:31 PM To: Suresh Gupta suresh.gupta@nxp.com Cc: u-boot@lists.denx.de; Scott Wood scott.wood@nxp.com; Leo Li leoyang.li@nxp.com; Sriram Dash sriram.dash@nxp.com; Rajesh Bhagat rajesh.bhagat@nxp.com Subject: Re: [PATCH v3 4/8] armv8: Add workaround for USB erratum A-009007
On 02/23/2017 11:19 PM, Suresh Gupta wrote:
Hi York,
It is not good idea to change the values of all macro at this time as the code
tested on different platforms.
I am not talking about any value change. You are using writew. Why not using out_be16 as you thought?
For now all values in macro (like USB_PHY_RX_EQ_VAL_2) are swapped and if I want to use out_be16, then I need to change values of all macros, which intern require testing on all platform. That’s the reason, I don’t want to make such changes and break the working USB
Suresh,
This erratum only applies to LS1043A, LS1046A, LS2080A. It wouldn't be too much trouble to verify all of them. I'd rather we do it right at the first place than coming back to fix it. Are you in a rush to get this patch out?
Another thing, please drop defined(CONFIG_ARCH_LS2085A) for all the patches. We only use CONFIG_ARCH_LS2080A.
York
OK York, will send new patch..
-----Original Message----- From: york sun Sent: Tuesday, February 28, 2017 9:56 PM To: Suresh Gupta suresh.gupta@nxp.com Cc: u-boot@lists.denx.de; Scott Wood scott.wood@nxp.com; Leo Li leoyang.li@nxp.com; Sriram Dash sriram.dash@nxp.com; Rajesh Bhagat rajesh.bhagat@nxp.com Subject: Re: [PATCH v3 4/8] armv8: Add workaround for USB erratum A-009007
On 02/28/2017 02:52 AM, Suresh Gupta wrote:
-----Original Message----- From: york sun Sent: Friday, February 24, 2017 10:31 PM To: Suresh Gupta suresh.gupta@nxp.com Cc: u-boot@lists.denx.de; Scott Wood scott.wood@nxp.com; Leo Li leoyang.li@nxp.com; Sriram Dash sriram.dash@nxp.com; Rajesh Bhagat rajesh.bhagat@nxp.com Subject: Re: [PATCH v3 4/8] armv8: Add workaround for USB erratum A-009007
On 02/23/2017 11:19 PM, Suresh Gupta wrote:
Hi York,
It is not good idea to change the values of all macro at this time as the code
tested on different platforms.
I am not talking about any value change. You are using writew. Why not using out_be16 as you thought?
For now all values in macro (like USB_PHY_RX_EQ_VAL_2) are swapped and if I want to use out_be16, then I need to change values of all macros, which intern require testing on all platform. That's the reason, I don't want to make such changes and break the working USB
Suresh,
This erratum only applies to LS1043A, LS1046A, LS2080A. It wouldn't be too much trouble to verify all of them. I'd rather we do it right at the first place than coming back to fix it. Are you in a rush to get this patch out?
Another thing, please drop defined(CONFIG_ARCH_LS2085A) for all the patches. We only use CONFIG_ARCH_LS2080A.
York
participants (3)
-
Suresh Gupta -
York Sun -
york sun