[U-Boot] [PATCH 0/2] cm-t3x: minor config updates and cleanups
Remove OneNAND and flash related defines. Increase the MAXARGS value.
Igor Grinberg (2): cm-t35: clean unused defines from config cm-t35: increase the MAXARGS
include/configs/cm_t35.h | 14 ++------------ 1 files changed, 2 insertions(+), 12 deletions(-)
Neither cm-t35, nor cm-t3730 is using OneNAND or flash. Remove the related defines from config file.
Signed-off-by: Igor Grinberg grinberg@compulab.co.il --- include/configs/cm_t35.h | 12 +----------- 1 files changed, 1 insertions(+), 11 deletions(-)
diff --git a/include/configs/cm_t35.h b/include/configs/cm_t35.h index 46c556d..8e28fbc 100644 --- a/include/configs/cm_t35.h +++ b/include/configs/cm_t35.h @@ -289,25 +289,15 @@ */
/* **** PISMO SUPPORT *** */ - /* Configure the PISMO */ #define PISMO1_NAND_SIZE GPMC_SIZE_128M -#define PISMO1_ONEN_SIZE GPMC_SIZE_128M - -#define CONFIG_SYS_MONITOR_LEN (256 << 10) /* Reserve 2 sectors */ - -#if defined(CONFIG_CMD_NAND) -#define CONFIG_SYS_FLASH_BASE PISMO1_NAND_BASE -#endif
/* Monitor at start of flash */ #define CONFIG_SYS_MONITOR_BASE CONFIG_SYS_FLASH_BASE -#define CONFIG_SYS_ONENAND_BASE ONENAND_MAP +#define CONFIG_SYS_MONITOR_LEN (256 << 10) /* Reserve 2 sectors */
#define CONFIG_ENV_IS_IN_NAND -#define ONENAND_ENV_OFFSET 0x260000 /* environment starts here */ #define SMNAND_ENV_OFFSET 0x260000 /* environment starts here */ - #define CONFIG_ENV_OFFSET SMNAND_ENV_OFFSET #define CONFIG_ENV_ADDR SMNAND_ENV_OFFSET
On Sun, Oct 07, 2012 at 01:17:34PM +0200, Igor Grinberg wrote:
Neither cm-t35, nor cm-t3730 is using OneNAND or flash. Remove the related defines from config file.
Signed-off-by: Igor Grinberg grinberg@compulab.co.il
Applied to u-boot-ti/master, thanks!
Increase the MAXARGS to support more than 16 arguments.
Signed-off-by: Igor Grinberg grinberg@compulab.co.il --- include/configs/cm_t35.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/configs/cm_t35.h b/include/configs/cm_t35.h index 8e28fbc..e18fb5a 100644 --- a/include/configs/cm_t35.h +++ b/include/configs/cm_t35.h @@ -256,7 +256,7 @@ /* Print Buffer Size */ #define CONFIG_SYS_PBSIZE (CONFIG_SYS_CBSIZE + \ sizeof(CONFIG_SYS_PROMPT) + 16) -#define CONFIG_SYS_MAXARGS 16 /* max number of command args */ +#define CONFIG_SYS_MAXARGS 32 /* max number of command args */ /* Boot Argument Buffer Size */ #define CONFIG_SYS_BARGSIZE (CONFIG_SYS_CBSIZE)
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 10/07/12 04:17, Igor Grinberg wrote:
Increase the MAXARGS to support more than 16 arguments.
Signed-off-by: Igor Grinberg grinberg@compulab.co.il --- include/configs/cm_t35.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/configs/cm_t35.h b/include/configs/cm_t35.h index 8e28fbc..e18fb5a 100644 --- a/include/configs/cm_t35.h +++ b/include/configs/cm_t35.h @@ -256,7 +256,7 @@ /* Print Buffer Size */ #define CONFIG_SYS_PBSIZE (CONFIG_SYS_CBSIZE + \ sizeof(CONFIG_SYS_PROMPT) + 16) -#define CONFIG_SYS_MAXARGS 16 /* max number of command args */ +#define CONFIG_SYS_MAXARGS 32 /* max number of command args */ /* Boot Argument Buffer Size */ #define CONFIG_SYS_BARGSIZE (CONFIG_SYS_CBSIZE)
Why? This is the max number of arguments to a command in U-Boot not the size of the command line arguments.
- -- Tom
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 10/08/12 17:39, Tom Rini wrote:
On 10/07/12 04:17, Igor Grinberg wrote:
Increase the MAXARGS to support more than 16 arguments.
Signed-off-by: Igor Grinberg grinberg@compulab.co.il --- include/configs/cm_t35.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/configs/cm_t35.h b/include/configs/cm_t35.h index 8e28fbc..e18fb5a 100644 --- a/include/configs/cm_t35.h +++ b/include/configs/cm_t35.h @@ -256,7 +256,7 @@ /* Print Buffer Size */ #define CONFIG_SYS_PBSIZE (CONFIG_SYS_CBSIZE + \ sizeof(CONFIG_SYS_PROMPT) + 16) -#define CONFIG_SYS_MAXARGS 16 /* max number of command args */ +#define CONFIG_SYS_MAXARGS 32 /* max number of command args */ /* Boot Argument Buffer Size */ #define CONFIG_SYS_BARGSIZE (CONFIG_SYS_CBSIZE)
Why? This is the max number of arguments to a command in U-Boot not the size of the command line arguments.
Yes, I know that, but for some reason I was mislead by one of our engineers that we need to increase it. After checking the issue, I've came to a conclusion, that there was a missing quote(s) and we don't really need to increase the MAXARGS.
Thanks for bringing my attention to this. You can drop this patch.
- -- Regards, Igor.
participants (2)
-
Igor Grinberg -
Tom Rini