[U-Boot] [PATCH] ARM: make timer variables in gt_t available for all ARM platforms
After ARM relocation, any code executed directly or indirectly by board_init_f() have global (BSS) variables need to be fixed. mostly timer.c needs to fix on most of the ARM platforms.
This patch makes timer related variables in gd_t available for all ARM implementation
Signed-off-by: Prafulla Wadaskar prafulla@marvell.com --- arch/arm/include/asm/global_data.h | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/arch/arm/include/asm/global_data.h b/arch/arm/include/asm/global_data.h index ada3fbb..efb502e 100644 --- a/arch/arm/include/asm/global_data.h +++ b/arch/arm/include/asm/global_data.h @@ -55,7 +55,9 @@ typedef struct global_data { unsigned long plla_rate_hz; unsigned long pllb_rate_hz; unsigned long at91_pllb_usb_init; - /* "static data" needed by at91's timer.c */ +#endif +#ifdef CONFIG_ARM + /* "static data" needed by most of timer.c on ARM platforms */ unsigned long timer_rate_hz; unsigned long tbl; unsigned long tbu;
On 01/12/10 12:16, Prafulla Wadaskar wrote:
After ARM relocation, any code executed directly or indirectly by board_init_f() have global (BSS) variables need to be fixed. mostly timer.c needs to fix on most of the ARM platforms.
This patch makes timer related variables in gd_t available for all ARM implementation
Signed-off-by: Prafulla Wadaskar prafulla@marvell.com
arch/arm/include/asm/global_data.h | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/arch/arm/include/asm/global_data.h b/arch/arm/include/asm/global_data.h index ada3fbb..efb502e 100644 --- a/arch/arm/include/asm/global_data.h +++ b/arch/arm/include/asm/global_data.h @@ -55,7 +55,9 @@ typedef struct global_data { unsigned long plla_rate_hz; unsigned long pllb_rate_hz; unsigned long at91_pllb_usb_init;
- /* "static data" needed by at91's timer.c */
+#endif +#ifdef CONFIG_ARM
- /* "static data" needed by most of timer.c on ARM platforms */ unsigned long timer_rate_hz; unsigned long tbl; unsigned long tbu;
This file is ARM specific. Doesn't this mean CONFIG_ARM is always defined here?
Regards, Nick.
-----Original Message----- From: Prafulla Wadaskar [mailto:prafulla@marvell.com] Sent: Wednesday, December 01, 2010 5:47 PM To: u-boot@lists.denx.de Cc: Manas Saksena; Prabhanjan Sarnaik; Ashish Karkare; Prafulla Wadaskar Subject: [PATCH] ARM: make timer variables in gt_t available for all ARM platforms
After ARM relocation, any code executed directly or indirectly by board_init_f() have global (BSS) variables need to be fixed. mostly timer.c needs to fix on most of the ARM platforms.
This patch makes timer related variables in gd_t available for all ARM implementation
Signed-off-by: Prafulla Wadaskar prafulla@marvell.com
arch/arm/include/asm/global_data.h | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/arch/arm/include/asm/global_data.h b/arch/arm/include/asm/global_data.h index ada3fbb..efb502e 100644 --- a/arch/arm/include/asm/global_data.h +++ b/arch/arm/include/asm/global_data.h @@ -55,7 +55,9 @@ typedef struct global_data { unsigned long plla_rate_hz; unsigned long pllb_rate_hz; unsigned long at91_pllb_usb_init;
- /* "static data" needed by at91's timer.c */
+#endif +#ifdef CONFIG_ARM
- /* "static data" needed by most of timer.c on ARM platforms */ unsigned long timer_rate_hz; unsigned long tbl; unsigned long tbu;
--
Applied to u-boot-marvell.git master branch
Regards.. Prafulla ..
Dear Prafulla Wadaskar,
In message F766E4F80769BD478052FB6533FA745D19A948E86B@SC-VEXCH4.marvell.com you wrote:
This patch makes timer related variables in gd_t available for all ARM implementation
---^^^^^^^^^
Applied to u-boot-marvell.git master branch
Thisis NOT a Marvell specific commit. It is not supposed to go through the Marvell repository. It is a common ARM patch and should go through the ARM repo.
Thanks.
Best regards,
Wolfgang Denk
Dear Prafulla Wadaskar,
In message 1291205812-5491-1-git-send-email-prafulla@marvell.com you wrote:
After ARM relocation, any code executed directly or indirectly by board_init_f() have global (BSS) variables need to be fixed. mostly timer.c needs to fix on most of the ARM platforms.
This patch makes timer related variables in gd_t available for all ARM implementation
Signed-off-by: Prafulla Wadaskar prafulla@marvell.com
arch/arm/include/asm/global_data.h | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
participants (3)
-
Nick Thompson -
Prafulla Wadaskar -
Wolfgang Denk