[U-Boot] Fwd: [PATCH 1/6] exynos_fb: Remove usage of static defines
Hi Simon,
On Wed, Oct 16, 2013 at 10:04 PM, Simon Glass sjg@chromium.org wrote:
Hi Ajay,
[once more from the right address]
On Mon, Sep 30, 2013 at 5:20 AM, Ajay Kumar <ajaykumar.rs@samsung.com
wrote:
Previously, we used to statically assign values for vl_col, vl_row and vl_bpix using #defines like LCD_XRES, LCD_YRES and LCD_COLOR16.
Introducing the function exynos_lcd_early_init() would take care of this assignment on the fly by parsing FIMD DT properties, thereby allowing us to remove LCD_XRES and LCD_YRES from the main config file.
Signed-off-by: Ajay Kumar ajaykumar.rs@samsung.com
Acked-by: Simon Glass sjg@chromium.org
I can't test this on Pit at present - any chance of a series at some point to enable that?
Should wait till Rajeshwari sends a patch for peach-pit dts.
I pushed my branch to u-boot-x86.git branch try-5420b.
As a general comment, it would be nice to follow up with a series to fully enable device tree for the GPIOs also. At the moment these are hard-coded.
Ok. I will do this for exynos video driver.
Regards,
Simon
U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Thanks and regards, Ajay Kumar
On Oct 23, 2013 9:28 AM, "Ajay kumar" ajaynumb@gmail.com wrote:
Hi Simon,
On Wed, Oct 16, 2013 at 10:04 PM, Simon Glass sjg@chromium.org wrote:
Hi Ajay,
[once more from the right address]
On Mon, Sep 30, 2013 at 5:20 AM, Ajay Kumar <ajaykumar.rs@samsung.com
wrote:
Previously, we used to statically assign values for vl_col, vl_row and vl_bpix using #defines like LCD_XRES, LCD_YRES and LCD_COLOR16.
Introducing the function exynos_lcd_early_init() would take care of
this
assignment on the fly by parsing FIMD DT properties, thereby allowing
us
to remove LCD_XRES and LCD_YRES from the main config file.
Signed-off-by: Ajay Kumar ajaykumar.rs@samsung.com
Acked-by: Simon Glass sjg@chromium.org
I can't test this on Pit at present - any chance of a series at some
point
to enable that?
Should wait till Rajeshwari sends a patch for peach-pit dts.
I pushed my branch to u-boot-x86.git branch try-5420b.
As a general comment, it would be nice to follow up with a series to
fully
enable device tree for the GPIOs also. At the moment these are
hard-coded.
Ok. I will do this for exynos video driver.
Sounds good on both counts, thank you.
Regards, Simon
U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Thanks and regards, Ajay Kumar
participants (2)
-
Ajay kumar -
Simon Glass