[U-Boot] [PATCH] dm: serial: Initialize serial console only when it wasn't already configured
It may happen that the MXC serial IP block is performing some ongoing transmission (started at e.g. board_init()) when the "initr_serial" is called.
As a result the serial port IP block is reset, so transmitted data is corrupted:
I2C: ready DRAM: 1 GiB jSS('HH��SL_SDHC: 04 rev 0x0
This patch prevents from this situation, by avoiding re-initialization of serial IP block (and execution of the same code twice).
I2C: ready DRAM: 1 GiB ID: unit type 0x4 rev 0x0
This patch is a follow up of following discussions: http://patchwork.ozlabs.org/patch/820824/ http://patchwork.ozlabs.org/patch/830957/
Signed-off-by: Lukasz Majewski lukma@denx.de
---
drivers/serial/serial-uclass.c | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/drivers/serial/serial-uclass.c b/drivers/serial/serial-uclass.c index 2e5116f7ce..c345578b36 100644 --- a/drivers/serial/serial-uclass.c +++ b/drivers/serial/serial-uclass.c @@ -129,6 +129,9 @@ static void serial_find_console_or_panic(void) /* Called prior to relocation */ int serial_init(void) { + if (gd->flags & GD_FLG_SERIAL_READY) + return 0; + serial_find_console_or_panic(); gd->flags |= GD_FLG_SERIAL_READY;
On 25.01.2018 18:24, Lukasz Majewski wrote:
It may happen that the MXC serial IP block is performing some ongoing transmission (started at e.g. board_init()) when the "initr_serial" is called.
As a result the serial port IP block is reset, so transmitted data is corrupted:
I2C: ready DRAM: 1 GiB jSS('HH��SL_SDHC: 04 rev 0x0
This patch prevents from this situation, by avoiding re-initialization of serial IP block (and execution of the same code twice).
I2C: ready DRAM: 1 GiB ID: unit type 0x4 rev 0x0
This patch is a follow up of following discussions: http://patchwork.ozlabs.org/patch/820824/ http://patchwork.ozlabs.org/patch/830957/
Signed-off-by: Lukasz Majewski lukma@denx.de
Reviewed-by: Stefan Roese sr@denx.de
Thanks, Stefan
Dear All,
It may happen that the MXC serial IP block is performing some ongoing transmission (started at e.g. board_init()) when the "initr_serial" is called.
As a result the serial port IP block is reset, so transmitted data is corrupted:
I2C: ready DRAM: 1 GiB jSS('HH��SL_SDHC: 04 rev 0x0
This patch prevents from this situation, by avoiding re-initialization of serial IP block (and execution of the same code twice).
I2C: ready DRAM: 1 GiB ID: unit type 0x4 rev 0x0
This patch is a follow up of following discussions: http://patchwork.ozlabs.org/patch/820824/ http://patchwork.ozlabs.org/patch/830957/
Signed-off-by: Lukasz Majewski lukma@denx.de
After some excessive testing it turned out that this patch is not behaving as expected.
Please drop it. I will find another, better solution for this issue.
Sorry for trouble.
drivers/serial/serial-uclass.c | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/drivers/serial/serial-uclass.c b/drivers/serial/serial-uclass.c index 2e5116f7ce..c345578b36 100644 --- a/drivers/serial/serial-uclass.c +++ b/drivers/serial/serial-uclass.c @@ -129,6 +129,9 @@ static void serial_find_console_or_panic(void) /* Called prior to relocation */ int serial_init(void) {
- if (gd->flags & GD_FLG_SERIAL_READY)
return 0;- serial_find_console_or_panic(); gd->flags |= GD_FLG_SERIAL_READY;
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
participants (2)
-
Lukasz Majewski -
Stefan Roese