[PATCH 0/2] x86: Minor nits from previous reviews
I found a few nits in my queue that were not addressed at the time. This series fixes them.
Simon Glass (2): x86: pinctrl: Fix 'relatove' typo x86: Drop nhlt_serialise()
arch/x86/include/asm/acpi_nhlt.h | 8 -------- drivers/pinctrl/intel/Kconfig | 2 +- 2 files changed, 1 insertion(+), 9 deletions(-)
Fix this typo in the Kconfig help.
Signed-off-by: Simon Glass sjg@chromium.org Suggested-by: Wolfgang Wallner wolfgang.wallner@br-automation.com ---
drivers/pinctrl/intel/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/intel/Kconfig b/drivers/pinctrl/intel/Kconfig index 1acc5dabb01..316a8fe27fd 100644 --- a/drivers/pinctrl/intel/Kconfig +++ b/drivers/pinctrl/intel/Kconfig @@ -22,7 +22,7 @@ config INTEL_PINCTRL_MULTI_ACPI_DEVICES Enable this if the pinctrl devices are modelled as multiple, separate ACPI devices in the ACPI tables. If enabled, the ACPI devices match the U-Boot pinctrl devices and the pin 'offset' is - relatove to a particular pinctrl device. If disabled, there is a + relative to a particular pinctrl device. If disabled, there is a single ACPI pinctrl device which includes all U-Boot pinctrl devices and the pin 'offset' is in effect a global pin number.
On Sun, Aug 30, 2020 at 5:23 AM Simon Glass sjg@chromium.org wrote:
Fix this typo in the Kconfig help.
Signed-off-by: Simon Glass sjg@chromium.org Suggested-by: Wolfgang Wallner wolfgang.wallner@br-automation.com
drivers/pinctrl/intel/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/intel/Kconfig b/drivers/pinctrl/intel/Kconfig index 1acc5dabb01..316a8fe27fd 100644 --- a/drivers/pinctrl/intel/Kconfig +++ b/drivers/pinctrl/intel/Kconfig @@ -22,7 +22,7 @@ config INTEL_PINCTRL_MULTI_ACPI_DEVICES Enable this if the pinctrl devices are modelled as multiple, separate ACPI devices in the ACPI tables. If enabled, the ACPI devices match the U-Boot pinctrl devices and the pin 'offset' is
relatove to a particular pinctrl device. If disabled, there is a
relative to a particular pinctrl device. If disabled, there is a single ACPI pinctrl device which includes all U-Boot pinctrl devices and the pin 'offset' is in effect a global pin number.--
Reviewed-by: Bin Meng bmeng.cn@gmail.com
On Tue, Sep 1, 2020 at 1:45 PM Bin Meng bmeng.cn@gmail.com wrote:
On Sun, Aug 30, 2020 at 5:23 AM Simon Glass sjg@chromium.org wrote:
Fix this typo in the Kconfig help.
Signed-off-by: Simon Glass sjg@chromium.org Suggested-by: Wolfgang Wallner wolfgang.wallner@br-automation.com
drivers/pinctrl/intel/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/intel/Kconfig b/drivers/pinctrl/intel/Kconfig index 1acc5dabb01..316a8fe27fd 100644 --- a/drivers/pinctrl/intel/Kconfig +++ b/drivers/pinctrl/intel/Kconfig @@ -22,7 +22,7 @@ config INTEL_PINCTRL_MULTI_ACPI_DEVICES Enable this if the pinctrl devices are modelled as multiple, separate ACPI devices in the ACPI tables. If enabled, the ACPI devices match the U-Boot pinctrl devices and the pin 'offset' is
relatove to a particular pinctrl device. If disabled, there is a
relative to a particular pinctrl device. If disabled, there is a single ACPI pinctrl device which includes all U-Boot pinctrl devices and the pin 'offset' is in effect a global pin number.--
Reviewed-by: Bin Meng bmeng.cn@gmail.com
applied to u-boot-x86, thanks!
This function is not actually used in U-Boot. Drop it.
Suggested-by: Bin Meng bmeng.cn@gmail.com
Signed-off-by: Simon Glass sjg@chromium.org ---
arch/x86/include/asm/acpi_nhlt.h | 8 -------- 1 file changed, 8 deletions(-)
diff --git a/arch/x86/include/asm/acpi_nhlt.h b/arch/x86/include/asm/acpi_nhlt.h index 47203213818..2c44196317b 100644 --- a/arch/x86/include/asm/acpi_nhlt.h +++ b/arch/x86/include/asm/acpi_nhlt.h @@ -137,14 +137,6 @@ int nhlt_endpoint_add_formats(struct nhlt_endpoint *endpoint, */ void nhlt_next_instance(struct nhlt *nhlt, int link_type);
-/* - * Serialize NHLT object to ACPI table. Take in the beginning address of where - * the table will reside and return the address of the next ACPI table. On - * error 0 will be returned. The NHLT object is no longer valid after this - * function is called. - */ -uintptr_t nhlt_serialise(struct nhlt *nhlt, uintptr_t acpi_addr); - /* * Serialize NHLT object to ACPI table. Take in the beginning address of where * the table will reside oem_id and oem_table_id and return the address of the
On Sun, Aug 30, 2020 at 5:23 AM Simon Glass sjg@chromium.org wrote:
This function is not actually used in U-Boot. Drop it.
Suggested-by: Bin Meng bmeng.cn@gmail.com
Signed-off-by: Simon Glass sjg@chromium.org
arch/x86/include/asm/acpi_nhlt.h | 8 -------- 1 file changed, 8 deletions(-)
Reviewed-by: Bin Meng bmeng.cn@gmail.com
On Tue, Sep 1, 2020 at 1:45 PM Bin Meng bmeng.cn@gmail.com wrote:
On Sun, Aug 30, 2020 at 5:23 AM Simon Glass sjg@chromium.org wrote:
This function is not actually used in U-Boot. Drop it.
Suggested-by: Bin Meng bmeng.cn@gmail.com
Signed-off-by: Simon Glass sjg@chromium.org
arch/x86/include/asm/acpi_nhlt.h | 8 -------- 1 file changed, 8 deletions(-)
Reviewed-by: Bin Meng bmeng.cn@gmail.com
applied to u-boot-x86, thanks!
participants (2)
-
Bin Meng -
Simon Glass