[U-Boot] [PATCH 0/2] mtd: nand: atmel: use another functions to set/get gpio value
The purpose of the patch set is to use another functions to set or get the gpio value for the atmel nand driver.
Wenyou Yang (2): ARM: at91: gpio: fix at91_set/get_gpio_value() mtd: nand: atmel: change another functions to set/get gpio value
arch/arm/mach-at91/include/mach/gpio.h | 12 +++++------- drivers/mtd/nand/atmel_nand.c | 5 +++-- 2 files changed, 8 insertions(+), 9 deletions(-)
There is no implementation on at91_set_pio_value() with two arguments. at91_get_pio_value() with one argument.
Signed-off-by: Wenyou Yang wenyou.yang@atmel.com ---
arch/arm/mach-at91/include/mach/gpio.h | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/arch/arm/mach-at91/include/mach/gpio.h b/arch/arm/mach-at91/include/mach/gpio.h index 5a32bdba8d..df0f71975a 100644 --- a/arch/arm/mach-at91/include/mach/gpio.h +++ b/arch/arm/mach-at91/include/mach/gpio.h @@ -223,15 +223,13 @@ static inline unsigned pin_to_mask(unsigned pin) at91_set_pio_output((x - PIN_BASE) / 32,(x % 32), y) #define at91_set_gpio_input(x, y) \ at91_set_pio_input((x - PIN_BASE) / 32,(x % 32), y) -#define at91_set_gpio_value(x, y) \ - at91_set_pio_value((x - PIN_BASE) / 32,(x % 32), y) -#define at91_get_gpio_value(x) \ - at91_get_pio_value((x - PIN_BASE) / 32,(x % 32)) -#else -#define at91_set_gpio_value(x, y) at91_set_pio_value(x, y) -#define at91_get_gpio_value(x) at91_get_pio_value(x) #endif
+#define at91_set_gpio_value(x, y) \ + at91_set_pio_value((x / 32), (x % 32), y) +#define at91_get_gpio_value(x) \ + at91_get_pio_value((x / 32), (x % 32)) + #define GPIO_PIOA_BASE (0) #define GPIO_PIOB_BASE (GPIO_PIOA_BASE + 32) #define GPIO_PIOC_BASE (GPIO_PIOB_BASE + 32)
Hi Wenyou,
On 22 February 2017 at 03:07, Wenyou Yang wenyou.yang@atmel.com wrote:
There is no implementation on at91_set_pio_value() with two arguments. at91_get_pio_value() with one argument.
Signed-off-by: Wenyou Yang wenyou.yang@atmel.com
arch/arm/mach-at91/include/mach/gpio.h | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-)
I cannot make sense of this commit message. It should explain what the commit does.
Regards, Simon
Because there is no implementation of gpio_set/get_value() function after the at91 gpio driver is converted to support DM, use at91_set/get_gpio_value().
Signed-off-by: Wenyou Yang wenyou.yang@atmel.com ---
drivers/mtd/nand/atmel_nand.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c index 8669432deb..21d5d0e70d 100644 --- a/drivers/mtd/nand/atmel_nand.c +++ b/drivers/mtd/nand/atmel_nand.c @@ -1222,7 +1222,8 @@ static void at91_nand_hwcontrol(struct mtd_info *mtd, IO_ADDR_W |= CONFIG_SYS_NAND_MASK_ALE;
#ifdef CONFIG_SYS_NAND_ENABLE_PIN - gpio_set_value(CONFIG_SYS_NAND_ENABLE_PIN, !(ctrl & NAND_NCE)); + at91_set_gpio_value(CONFIG_SYS_NAND_ENABLE_PIN, + !(ctrl & NAND_NCE)); #endif this->IO_ADDR_W = (void *) IO_ADDR_W; } @@ -1234,7 +1235,7 @@ static void at91_nand_hwcontrol(struct mtd_info *mtd, #ifdef CONFIG_SYS_NAND_READY_PIN static int at91_nand_ready(struct mtd_info *mtd) { - return gpio_get_value(CONFIG_SYS_NAND_READY_PIN); + return at91_get_gpio_value(CONFIG_SYS_NAND_READY_PIN); } #endif
On 22 February 2017 at 03:07, Wenyou Yang wenyou.yang@atmel.com wrote:
Because there is no implementation of gpio_set/get_value() function after the at91 gpio driver is converted to support DM, use at91_set/get_gpio_value().
Signed-off-by: Wenyou Yang wenyou.yang@atmel.com
drivers/mtd/nand/atmel_nand.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
Reviewed-by: Simon Glass sjg@chromium.org
At some point this should change to use driver model, right?
Hi Simon,
-----Original Message----- From: sjg@google.com [mailto:sjg@google.com] On Behalf Of Simon Glass Sent: 2017年3月3日 12:52 To: Wenyou Yang - A41535 Wenyou.Yang@microchip.com Cc: U-Boot Mailing List u-boot@lists.denx.de; Andreas Bießmann andreas@biessmann.org; Scott Wood scottwood@freescale.com; Wenyou Yang - A41535 Wenyou.Yang@microchip.com Subject: Re: [PATCH 2/2] mtd: nand: atmel: change another functions to set/get gpio value
On 22 February 2017 at 03:07, Wenyou Yang wenyou.yang@atmel.com wrote:
Because there is no implementation of gpio_set/get_value() function after the at91 gpio driver is converted to support DM, use at91_set/get_gpio_value().
Signed-off-by: Wenyou Yang wenyou.yang@atmel.com
drivers/mtd/nand/atmel_nand.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
Reviewed-by: Simon Glass sjg@chromium.org
At some point this should change to use driver model, right?
Yes, after the NAND uclass Implementation patches are accepted by main-line, Atmel nand driver will be converted to support driver model.
Best Regards, Wenyou Yang
participants (3)
-
Simon Glass -
Wenyou Yang -
Wenyou.Yang＠microchip.com