[U-Boot] [PATCH] dm: pinctrl: fix for introduce PINCONF_RECURSIVE option
Correct the name of the define used in CONFIG_IS_ENABLED(): it is not align with Kconfig name= CONFIG_$(SPL_)PINCONF_RECURSIVE.
This correct a regression introduced by commit c20851b3d850 ("dm: pinctrl: introduce PINCONF_RECURSIVE option")
Signed-off-by: Patrick Delaunay patrick.delaunay@st.com ---
drivers/pinctrl/pinctrl-uclass.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/pinctrl-uclass.c b/drivers/pinctrl/pinctrl-uclass.c index 0b1eb7fab4..dc2340b779 100644 --- a/drivers/pinctrl/pinctrl-uclass.c +++ b/drivers/pinctrl/pinctrl-uclass.c @@ -157,7 +157,7 @@ static int pinconfig_post_bind(struct udevice *dev)
UCLASS_DRIVER(pinconfig) = { .id = UCLASS_PINCONFIG, -#if CONFIG_IS_ENABLED(PINCONFIG_RECURSIVE) +#if CONFIG_IS_ENABLED(PINCONF_RECURSIVE) .post_bind = pinconfig_post_bind, #endif .name = "pinconfig",
On Fri, 18 Oct 2019 20:29:22 +0200 Patrick Delaunay patrick.delaunay@st.com wrote:
Correct the name of the define used in CONFIG_IS_ENABLED(): it is not align with Kconfig name= CONFIG_$(SPL_)PINCONF_RECURSIVE.
This correct a regression introduced by commit c20851b3d850 ("dm: pinctrl: introduce PINCONF_RECURSIVE option")
Signed-off-by: Patrick Delaunay patrick.delaunay@st.com
drivers/pinctrl/pinctrl-uclass.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/pinctrl-uclass.c b/drivers/pinctrl/pinctrl-uclass.c index 0b1eb7fab4..dc2340b779 100644 --- a/drivers/pinctrl/pinctrl-uclass.c +++ b/drivers/pinctrl/pinctrl-uclass.c @@ -157,7 +157,7 @@ static int pinconfig_post_bind(struct udevice *dev) UCLASS_DRIVER(pinconfig) = { .id = UCLASS_PINCONFIG, -#if CONFIG_IS_ENABLED(PINCONFIG_RECURSIVE) +#if CONFIG_IS_ENABLED(PINCONF_RECURSIVE) .post_bind = pinconfig_post_bind, #endif .name = "pinconfig",
Reviewed-by: Lukasz Majewski lukma@denx.de
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de
On Fri, 18 Oct 2019 20:29:22 +0200 Patrick Delaunay patrick.delaunay@st.com wrote:
Correct the name of the define used in CONFIG_IS_ENABLED(): it is not align with Kconfig name= CONFIG_$(SPL_)PINCONF_RECURSIVE.
This correct a regression introduced by commit c20851b3d850 ("dm: pinctrl: introduce PINCONF_RECURSIVE option")
Signed-off-by: Patrick Delaunay patrick.delaunay@st.com
Reviewed-by: Anatolij Gustschin agust@denx.de
Hi Tom,
On Fri, 18 Oct 2019 20:29:22 +0200 Patrick Delaunay patrick.delaunay@st.com wrote: ...
This correct a regression introduced by commit c20851b3d850 ("dm: pinctrl: introduce PINCONF_RECURSIVE option")
Could you please apply this patch ASAP? It fixes broken eMMC, Ethernet, I2C, GPIO, etc. on i.MX8QXP MEK board.
Many other boards are affected, too.
Thanks!
-- Anatolij
Hi Anatolij and Tom,
From: Anatolij Gustschin agust@denx.de Sent: samedi 19 octobre 2019 22:02
Hi Tom,
On Fri, 18 Oct 2019 20:29:22 +0200 Patrick Delaunay patrick.delaunay@st.com wrote: ...
This correct a regression introduced by commit c20851b3d850 ("dm: pinctrl: introduce PINCONF_RECURSIVE option")
Could you please apply this patch ASAP? It fixes broken eMMC, Ethernet, I2C, GPIO, etc. on i.MX8QXP MEK board.
Many other boards are affected, too.
Thanks!
I check deeper today the root cause of the issue and I have a clean solution with v2 patch: http://patchwork.ozlabs.org/patch/1180575/
The friday patch wasn't enough at least for my board, but ok for sandbox.
And a minor correction of the Kconfig (not blocking) http://patchwork.ozlabs.org/patch/1180576/
-- Anatolij
Sorry for disturbance.
Patrick
Hi Patrick,
On Mon, 21 Oct 2019 17:10:21 +0000 Patrick DELAUNAY patrick.delaunay@st.com wrote: ...
I check deeper today the root cause of the issue and I have a clean solution with v2 patch: http://patchwork.ozlabs.org/patch/1180575/
The friday patch wasn't enough at least for my board, but ok for sandbox.
OK, thanks for fixing it!
-- Anatolij
participants (4)
-
Anatolij Gustschin -
Lukasz Majewski -
Patrick DELAUNAY -
Patrick Delaunay