[U-Boot] [PATCH] usb: Fix compile warning of r8a66597-hcd
Signed-off-by: Nobuhiro Iwamatsu iwamatsu@nigauri.org --- drivers/usb/r8a66597-hcd.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/r8a66597-hcd.c b/drivers/usb/r8a66597-hcd.c index 0d3931e..a2e1fff 100644 --- a/drivers/usb/r8a66597-hcd.c +++ b/drivers/usb/r8a66597-hcd.c @@ -530,7 +530,7 @@ static int check_usb_device_connecting(struct r8a66597 *r8a66597)
/* based on usb_ohci.c */ #define min_t(type, x, y) \ - ({ type __x = (x); type __y = (y); __x < __y ? __x: __y; }) + ({ type __x = (x); type __y = (y); __x < __y ? __x : __y; }) /*-------------------------------------------------------------------------* * Virtual Root Hub *-------------------------------------------------------------------------*/ @@ -794,7 +794,7 @@ static int r8a66597_submit_rh_msg(struct usb_device *dev, unsigned long pipe, case RH_SET_CONFIGURATION: break; default: - dbg("unsupported root hub command"); + R8A66597_DPRINT("unsupported root hub command"); stat = USB_ST_STALLED; }
Dear Nobuhiro,
On Thu, Sep 18, 2008 at 08:13:08PM +0900, Nobuhiro Iwamatsu wrote:
Signed-off-by: Nobuhiro Iwamatsu iwamatsu@nigauri.org
drivers/usb/r8a66597-hcd.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/r8a66597-hcd.c b/drivers/usb/r8a66597-hcd.c index 0d3931e..a2e1fff 100644
Your patch is line wrapped.
--- a/drivers/usb/r8a66597-hcd.c +++ b/drivers/usb/r8a66597-hcd.c @@ -530,7 +530,7 @@ static int check_usb_device_connecting(struct r8a66597 *r8a66597)
and here.
/* based on usb_ohci.c */ #define min_t(type, x, y) \
({ type __x = (x); type __y = (y); __x < __y ? __x: __y; })
({ type __x = (x); type __y = (y); __x < __y ? __x : __y; })/*-------------------------------------------------------------------------*
- Virtual Root Hub
*-------------------------------------------------------------------------*/ @@ -794,7 +794,7 @@ static int r8a66597_submit_rh_msg(struct usb_device *dev, unsigned long pipe, case RH_SET_CONFIGURATION: break; default:
dbg("unsupported root hub command");
R8A66597_DPRINT("unsupported root hub command");
Please fix your mailer next time.
Applied to USB repo.
Thanks!
Markus
Dear "Nobuhiro Iwamatsu",
In message 29ab51dc0809180413p44fec384mb918c144a42fff66@mail.gmail.com you wrote:
Signed-off-by: Nobuhiro Iwamatsu iwamatsu@nigauri.org
drivers/usb/r8a66597-hcd.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/r8a66597-hcd.c b/drivers/usb/r8a66597-hcd.c index 0d3931e..a2e1fff 100644 --- a/drivers/usb/r8a66597-hcd.c +++ b/drivers/usb/r8a66597-hcd.c @@ -530,7 +530,7 @@ static int check_usb_device_connecting(struct r8a66597 *r8a66597)
^^^^^^^^^^^^^^^^^^^^^^
/* based on usb_ohci.c */ #define min_t(type, x, y) \
({ type __x = (x); type __y = (y); __x < __y ? __x: __y; })
({ type __x = (x); type __y = (y); __x < __y ? __x : __y; })/*-------------------------------------------------------------------------*
- Virtual Root Hub
*-------------------------------------------------------------------------*/ @@ -794,7 +794,7 @@ static int r8a66597_submit_rh_msg(struct usb_device *dev, unsigned long pipe,
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Just for the record: your patches are corrupted because your mailer wraps long lines.
Please fix.
Best regards,
Wolfgang Denk
participants (3)
-
Markus Klotzbücher -
Nobuhiro Iwamatsu -
Wolfgang Denk