[U-Boot] [PATCH] OMAP4: quick image loading & memory init on Pandaboard
Improved default config for OMAP4 Pandaboard for faster boot: -reduced environment size to speed up memory initialization; -tweaked blob load address to avoid image relocation (according to default uImage load address);
Signed-off-by: Sergiy Kibrik sergiy.kibrik@globallogic.com --- include/configs/omap4_panda.h | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/configs/omap4_panda.h b/include/configs/omap4_panda.h index 74defab..5a2df35 100644 --- a/include/configs/omap4_panda.h +++ b/include/configs/omap4_panda.h @@ -62,10 +62,10 @@
/* * Size of malloc() pool - * Total Size Environment - 256k + * Total Size Environment - 2k * Malloc - add 256k */ -#define CONFIG_ENV_SIZE (256 << 10) +#define CONFIG_ENV_SIZE (256 << 4) #define CONFIG_SYS_MALLOC_LEN (CONFIG_ENV_SIZE + (256 << 10)) /* initial data */ /* Vector Base */ @@ -146,7 +146,7 @@ #define CONFIG_ENV_OVERWRITE
#define CONFIG_EXTRA_ENV_SETTINGS \ - "loadaddr=0x82000000\0" \ + "loadaddr=0x80007FC0\0" \ "console=ttyS2,115200n8\0" \ "usbtty=cdc_acm\0" \ "vram=16M\0" \
Dear Sergiy Kibrik,
In message 4CD4377B.2020500@globallogic.com you wrote:
Improved default config for OMAP4 Pandaboard for faster boot: -reduced environment size to speed up memory initialization; -tweaked blob load address to avoid image relocation (according to default uImage load address);
Signed-off-by: Sergiy Kibrik sergiy.kibrik@globallogic.com
include/configs/omap4_panda.h | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/configs/omap4_panda.h b/include/configs/omap4_panda.h index 74defab..5a2df35 100644 --- a/include/configs/omap4_panda.h +++ b/include/configs/omap4_panda.h @@ -62,10 +62,10 @@
/*
- Size of malloc() pool
- Total Size Environment - 256k
- Total Size Environment - 2k
An environment size of 2 kB seems way to small for amost practical purposes. I agree that 256 kB might be overkill, but why not chose a more reasonable size like 16 kB, or say 8 kB if you are really trying to squeeze any microsecond?
- Malloc - add 256k
*/ -#define CONFIG_ENV_SIZE (256 << 10) +#define CONFIG_ENV_SIZE (256 << 4)
256 << 4 ? Who is supposed to easily read and understand this?
If you mean 2 KiB, you could use either 2048 or (2 << 10).
In any case - please reconside rif 16 KiB is nt more reasonable. The time difference should be minimal (did you measure it?).
Best regards,
Wolfgang Denk
On 11/07/2010 11:36 PM, Wolfgang Denk wrote:
Dear Sergiy Kibrik,
In message 4CD4377B.2020500@globallogic.com you wrote:
Improved default config for OMAP4 Pandaboard for faster boot: -reduced environment size to speed up memory initialization; -tweaked blob load address to avoid image relocation (according to default uImage load address);
Signed-off-by: Sergiy Kibrik sergiy.kibrik@globallogic.com
include/configs/omap4_panda.h | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/configs/omap4_panda.h b/include/configs/omap4_panda.h index 74defab..5a2df35 100644 --- a/include/configs/omap4_panda.h +++ b/include/configs/omap4_panda.h @@ -62,10 +62,10 @@
/*
- Size of malloc() pool
- Total Size Environment - 256k
- Total Size Environment - 2k
An environment size of 2 kB seems way to small for amost practical purposes. I agree that 256 kB might be overkill, but why not chose a more reasonable size like 16 kB, or say 8 kB if you are really trying to squeeze any microsecond?
- Malloc - add 256k
*/ -#define CONFIG_ENV_SIZE (256 << 10) +#define CONFIG_ENV_SIZE (256 << 4)
256 << 4 ? Who is supposed to easily read and understand this?
If you mean 2 KiB, you could use either 2048 or (2 << 10).
sorry, I just used the way it was done before (besides those lines were commented)
In any case - please reconside rif 16 KiB is nt more reasonable. The time difference should be minimal (did you measure it?).
sure, 16k is a reasonable tradeoff. Thanks for your comments, I'll resubmit the patch.
Best regards,
Wolfgang Denk
Improved default config for OMAP4 Pandaboard for faster boot: -reduced environment size to speed up memory initialization; -tweaked blob load address to avoid image relocation (according to default uImage load address);
Signed-off-by: Sergiy Kibrik sergiy.kibrik@globallogic.com --- include/configs/omap4_panda.h | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/configs/omap4_panda.h b/include/configs/omap4_panda.h index 74defab..1a87acf 100644 --- a/include/configs/omap4_panda.h +++ b/include/configs/omap4_panda.h @@ -62,10 +62,10 @@
/* * Size of malloc() pool - * Total Size Environment - 256k + * Total Size Environment - 16k * Malloc - add 256k */ -#define CONFIG_ENV_SIZE (256 << 10) +#define CONFIG_ENV_SIZE (16 << 10) #define CONFIG_SYS_MALLOC_LEN (CONFIG_ENV_SIZE + (256 << 10)) /* initial data */ /* Vector Base */ @@ -146,7 +146,7 @@ #define CONFIG_ENV_OVERWRITE
#define CONFIG_EXTRA_ENV_SETTINGS \ - "loadaddr=0x82000000\0" \ + "loadaddr=0x80007FC0\0" \ "console=ttyS2,115200n8\0" \ "usbtty=cdc_acm\0" \ "vram=16M\0" \
On 11/08/2010 03:37 PM, Sergiy Kibrik wrote:
Improved default config for OMAP4 Pandaboard for faster boot: -reduced environment size to speed up memory initialization; -tweaked blob load address to avoid image relocation (according to default uImage load address);
Signed-off-by: Sergiy Kibrik sergiy.kibrik@globallogic.com
include/configs/omap4_panda.h | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/configs/omap4_panda.h b/include/configs/omap4_panda.h index 74defab..1a87acf 100644 --- a/include/configs/omap4_panda.h +++ b/include/configs/omap4_panda.h @@ -62,10 +62,10 @@
/*
- Size of malloc() pool
- Total Size Environment - 256k
*/
- Total Size Environment - 16k
- Malloc - add 256k
-#define CONFIG_ENV_SIZE (256 << 10) +#define CONFIG_ENV_SIZE (16 << 10) #define CONFIG_SYS_MALLOC_LEN (CONFIG_ENV_SIZE + (256 << 10)) /* initial data */ /* Vector Base */ @@ -146,7 +146,7 @@ #define CONFIG_ENV_OVERWRITE
#define CONFIG_EXTRA_ENV_SETTINGS \
- "loadaddr=0x82000000\0" \
- "loadaddr=0x80007FC0\0" \ "console=ttyS2,115200n8\0" \ "usbtty=cdc_acm\0" \ "vram=16M\0" \
Ping?
participants (2)
-
Sergiy Kibrik -
Wolfgang Denk