From: Auer, Lukas [mailto:lukas.auer@aisec.fraunhofer.de] Sent: Saturday, June 01, 2019 12:13 AM To: padmarao.begari@microchip.com; u-boot@lists.denx.de Cc: Rick Jian-Zhi Chen(陳建志); cyril.jean@microchip.com; bmeng.cn@gmail.com; anup.patel@wdc.com; lewis.hanly@microchip.com Subject: Re: [PATCH v4] riscv: Add Microchip MPFS Icicle board support

On Tue, 2019-05-28 at 15:47 +0530, Padmarao Begari wrote:

...

This patch adds Microchip MPFS Icicle board support. For now, NS16550 serial driver is only enabled. The Microchip MPFS Icicle defconfig by default builds U-Boot for M-Mode with SMP support.

Signed-off-by: Padmarao Begari padmarao.begari@microchip.com Reviewed-by: Bin Meng bmeng.cn@gmail.com

---

Changes in V4

• Remove CONFIG_DISTRO_DEFAULTS from microchip_mpfs_icicle_defconfig

Changes in v3

• Fix some typos
• Remove CONFIG_DM, CONFIG_DM_SERIAL, CONFIG_BAUDRATE, CONFIG_SYS_NS16550, CONFIG_SYS_TEXT_BASE and

CONFIG_NR_DRAM_BANKS

...

from microchip_mpfs_icicle_defconfig

• Add config SYS_TEXT_BASE in board kconfig
• Imply SYS_NS16550 in BOARD_SPECIFIC_OPTIONS
• select BOARD_EARLY_INIT_F in BOARD_SPECIFIC_OPTIONS

Changes in v2

• Fix some typos
• Rename target board to TARGET_MICROCHIP_ICICLE
• select CONFIG_BOARD_EARLY_INIT_F in BOARD_SPECIFIC_OPTIONS
• Remove #ifdef CONFIG_BOARD_EARLY_INIT_F

---

arch/riscv/Kconfig | 4 ++ board/microchip/mpfs_icicle/Kconfig | 26 +++++++++++++ board/microchip/mpfs_icicle/MAINTAINERS | 7 ++++ board/microchip/mpfs_icicle/Makefile | 7 ++++ board/microchip/mpfs_icicle/mpfs_icicle.c | 30 +++++++++++++++ configs/microchip_mpfs_icicle_defconfig | 8 ++++ include/configs/microchip_mpfs_icicle.h | 63

+++++++++++++++++++++++++++++++

...

7 files changed, 145 insertions(+) create mode 100644 board/microchip/mpfs_icicle/Kconfig create mode 100644 board/microchip/mpfs_icicle/MAINTAINERS create mode 100644 board/microchip/mpfs_icicle/Makefile create mode 100644 board/microchip/mpfs_icicle/mpfs_icicle.c create mode 100644 configs/microchip_mpfs_icicle_defconfig create mode 100644 include/configs/microchip_mpfs_icicle.h

Reviewed-by: Lukas Auer lukas.auer@aisec.fraunhofer.de

Applied to u-boot-riscv/master, thanks!