[PATCH v1 1/1] cmd: irq: Move do_irqinfo() prototype to a header file

Move do_irqinfo() prototype to a header file, otherwise compiler is not happy:
arch/x86/lib/interrupts.c:130:5: warning: no previous prototype for ‘do_irqinfo’ [-Wmissing-prototypes]
Signed-off-by: Andy Shevchenko andriy.shevchenko@linux.intel.com --- cmd/irq.c | 3 --- include/irq_func.h | 3 +++ 2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/cmd/irq.c b/cmd/irq.c index 655aba576a8b..da223b4b2cce 100644 --- a/cmd/irq.c +++ b/cmd/irq.c @@ -29,9 +29,6 @@ U_BOOT_CMD( "[on, off]" );
-/* Implemented in $(CPU)/interrupts.c */ -int do_irqinfo(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[]); - U_BOOT_CMD( irqinfo, 1, 1, do_irqinfo, "print information about IRQs", diff --git a/include/irq_func.h b/include/irq_func.h index c7c4babbfc90..28ec0bd83038 100644 --- a/include/irq_func.h +++ b/include/irq_func.h @@ -23,4 +23,7 @@ void reset_timer(void); void enable_interrupts(void); int disable_interrupts(void);
+/* Implemented in $(CPU)/interrupts.c */ +int do_irqinfo(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[]); + #endif

On Sat, 5 Oct 2024 at 13:14, Andy Shevchenko andriy.shevchenko@linux.intel.com wrote:
Move do_irqinfo() prototype to a header file, otherwise compiler is not happy:
arch/x86/lib/interrupts.c:130:5: warning: no previous prototype for ‘do_irqinfo’ [-Wmissing-prototypes]
Signed-off-by: Andy Shevchenko andriy.shevchenko@linux.intel.com
cmd/irq.c | 3 --- include/irq_func.h | 3 +++ 2 files changed, 3 insertions(+), 3 deletions(-)
Reviewed-by: Simon Glass sjg@chromium.org

On Sat, 05 Oct 2024 22:14:29 +0300, Andy Shevchenko wrote:
Move do_irqinfo() prototype to a header file, otherwise compiler is not happy:
arch/x86/lib/interrupts.c:130:5: warning: no previous prototype for ‘do_irqinfo’ [-Wmissing-prototypes]
Applied to u-boot/master, thanks!
participants (3)
-
Andy Shevchenko
-
Simon Glass
-
Tom Rini