Hi Wolfgang,

-----Original Message----- From: wd@denx.de [mailto:wd@denx.de] Sent: 09 June, 2004 18:39 To: Deak Imre (Nokia-M/Helsinki) Cc: u-boot-users@lists.sourceforge.net Subject: Re: [U-Boot-Users] [PATCH] OMAP1610 cs boot mode

...

Maybe it should be a CONFIG variable instead of 4 targets for each board (H2, Innovator), like CONFIG_OMAP_BOOTMODE_CS0 CONFIG_OMAP_BOOTMODE_CS3 CONFIG_OMAP_BOOTMODE_DETECT ?

Te question is: how many people are likely to change this?

Here it's quite a useful option, since you need only one binary instead of two, to boot in either of the two modes. I suggest that we keep the Makefile targets as they are: omap1610h2_cs_autoboot_config omap1610inn_cs_autoboot_config

Thanks, added - except for the part which modifies common/env_flash.c

Here, instead of simply initializing the relevant variables at compile time, you added code to do this at run time. I don't think this is a good idea. Please explain why you are doing this, and which problem you attempt to fix.

It needs to be done in runtime since CFG_FLASH_BASE is defined as a variable when one of the new targets is selected:

include/configs/omap1610inn.h:

[...]

#ifdef CONFIG_CS_AUTOBOOT /* Determine CS assignment in runtime */

#ifndef __ASSEMBLY__ extern unsigned long omap_flash_base; /* set in flash__init */ #endif #define CFG_FLASH_BASE omap_flash_base

[...]

#endif

Regards, Imre