Re: [U-Boot] [PATCH v2 2/2] riscv: tools: Add big endian target support to prelink-riscv

Hi Marcus
From: Marcus Comstedt [mailto:marcus@mc.pp.se] Sent: Thursday, August 08, 2019 4:36 AM To: Rick Chen Cc: U-Boot Mailing List; Rick Jian-Zhi Chen(陳建志); K.C. Kuen-Chern Lin(林坤 成) Subject: Re: [PATCH v2 2/2] riscv: tools: Add big endian target support to prelink-riscv
Hi Rick,
Rick Chen rickchen36@gmail.com writes:
Thanks for your efforts about the support for big endian ELFs. But I don't have big endian toolchain to verify.
I don't think anyone has a big endian toolchain for riscv at this juncture. :-) (No specification for big/bi endian has been nailed down yet, AFAIK, although there has been discussion about how to implement it.)
I expect the patch to work for symmetry reasons - the places that need byteswapping when the host is little endian and the target is big endian are exactly the same as the places that need byteswapping when the host is big endian and the target is little endian (a case which I have tested), so it's just a matter of keeping track of the endianness of the host (something which U-Boot does internally already) versus the endianness of the target (which is handled by this patch).
Merging this right now is probably about as useful as merging 128-bit ELF support, but I don't think it really adds any maintainence burden, so it might be simpler than keeping it around in patchwork. It's your call. :-)
Thanks for your explanation. :)
I have applied to u-boot-riscv/master, thanks!
Regards, Rick
// Marcus
participants (1)
-
Rick Chen