[U-Boot] [PATCH] mtd, nand: move some printfs to debug output.

current U-Boot shows on startup (for example on the enbw_cmc board) the following printfs from the nand subsystem:
Flash: 2 MiB NAND: Bad block table found at page 65472, version 0x01 Bad block table found at page 65408, version 0x01 nand_read_bbt: Bad block at 0x000002980000 nand_read_bbt: Bad block at 0x000003240000 128 MiB MMC: davinci: 0
remove them to debug output, so it shows with this patch:
Flash: 2 MiB NAND: 128 MiB MMC: davinci: 0
Signed-off-by: Heiko Schocher hs@denx.de Cc: Scott Wood scottwood@freescale.com --- [hs@pollux u-boot]$ ./tools/checkpatch.pl 20120215/0001-mtd-nand-move-some-printfs-to-debug-output.patch total: 0 errors, 0 warnings, 25 lines checked
NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX MULTISTATEMENT_MACRO_USE_DO_WHILE
20120215/0001-mtd-nand-move-some-printfs-to-debug-output.patch has no obvious style problems and is ready for submission. [hs@pollux u-boot]$
drivers/mtd/nand/nand_bbt.c | 13 +++++++------ 1 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/mtd/nand/nand_bbt.c b/drivers/mtd/nand/nand_bbt.c index 2b730e0..bf12df8 100644 --- a/drivers/mtd/nand/nand_bbt.c +++ b/drivers/mtd/nand/nand_bbt.c @@ -259,10 +259,10 @@ static int read_bbt(struct mtd_info *mtd, uint8_t *buf, int page, int num, mtd->ecc_stats.bbtblocks++; continue; } - /* Leave it for now, if its matured we can move this - * message to MTD_DEBUG_LEVEL0 */ - printk(KERN_DEBUG "nand_read_bbt: Bad block at 0x%012llx\n", - (loff_t)((offs << 2) + (act >> 1)) << this->bbt_erase_shift); + MTDDEBUG(MTD_DEBUG_LEVEL0, "nand_read_bbt: " \ + "Bad block at 0x%012llx\n", + (loff_t)((offs << 2) + (act >> 1)) + << this->bbt_erase_shift); /* Factory marked bad or worn out ? */ if (tmp == 0) this->bbt[offs + (act >> 3)] |= 0x3 << (act & 0x06); @@ -651,8 +651,9 @@ static int search_bbt(struct mtd_info *mtd, uint8_t *buf, struct nand_bbt_descr if (td->pages[i] == -1) printk(KERN_WARNING "Bad block table not found for chip %d\n", i); else - printk(KERN_DEBUG "Bad block table found at page %d, version 0x%02X\n", td->pages[i], - td->version[i]); + MTDDEBUG(MTD_DEBUG_LEVEL0, "Bad block table found " \ + "at page %d, version 0x%02X\n", td->pages[i], + td->version[i]); } return 0; }

On Tue, Feb 14, 2012 at 10:34:05PM -0000, Heiko Schocher wrote:
current U-Boot shows on startup (for example on the enbw_cmc board) the following printfs from the nand subsystem:
Flash: 2 MiB NAND: Bad block table found at page 65472, version 0x01 Bad block table found at page 65408, version 0x01 nand_read_bbt: Bad block at 0x000002980000 nand_read_bbt: Bad block at 0x000003240000 128 MiB MMC: davinci: 0
remove them to debug output, so it shows with this patch:
Flash: 2 MiB NAND: 128 MiB MMC: davinci: 0
Signed-off-by: Heiko Schocher hs@denx.de Cc: Scott Wood scottwood@freescale.com
Applied to u-boot-nand-flash
-Scott
participants (2)
-
Heiko Schocher
-
Scott Wood