[U-Boot] [PULL] Please pull u-boot-imx
Hi Tom,
Fabio fixed a build issue yesterday. It is just a single patch, but it should be flow into the release. You can pick it udirectly p, but I have also applied to u-boot-imx to make things easier.
The following changes since commit 5e62f828256d66e2b28def4f9ef20a2a05c2d04f:
Prepare v2018.03-rc4 (2018-03-05 20:27:08 -0500)
are available in the git repository at:
git://www.denx.de/git/u-boot-imx.git master
for you to fetch changes up to eca6f053c89bca8ac702e8cf74d187cce2197acb:
imximage: Check the IVT offset in the correct location (2018-03-08 22:36:01 +0100)
---------------------------------------------------------------- Fabio Estevam (1): imximage: Check the IVT offset in the correct location
tools/imximage.c | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-)
Stefano
Hi Stefano,
On Fri, Mar 9, 2018 at 7:13 AM, Stefano Babic sbabic@denx.de wrote:
Hi Tom,
Fabio fixed a build issue yesterday. It is just a single patch, but it should be flow into the release. You can pick it udirectly p, but I have also applied to u-boot-imx to make things easier.
Troy made a good observation yesterday: he asked me if after applying this patch the error is still shown when BOOT_FROM is not passed in the cfg file.
I tested it and it does not.
So we have some options here that I would like to discuss:
1. Drop the error message completely. This message is only helpful for developers during bring up phase
2. Understand better the problem and fix the parallel build issue
I think 1 can be done for the upcoming release as the negative effect of breaking builds is worse than showing the lack of BOOT_FROM tag.
Option number 2 would require more time to implement.
If you like I can resent a v2 of option 1 where the error message is removed.
Please let me know your thoughts.
Thanks,
Fabio Estevam
Hi Fabio,
On 09/03/2018 11:42, Fabio Estevam wrote:
Hi Stefano,
On Fri, Mar 9, 2018 at 7:13 AM, Stefano Babic sbabic@denx.de wrote:
Hi Tom,
Fabio fixed a build issue yesterday. It is just a single patch, but it should be flow into the release. You can pick it udirectly p, but I have also applied to u-boot-imx to make things easier.
Troy made a good observation yesterday: he asked me if after applying this patch the error is still shown when BOOT_FROM is not passed in the cfg file.
I tested it and it does not.
Something strange happens...
So we have some options here that I would like to discuss:
- Drop the error message completely. This message is only helpful for
developers during bring up phase
- Understand better the problem and fix the parallel build issue
I think 1 can be done for the upcoming release as the negative effect of breaking builds is worse than showing the lack of BOOT_FROM tag.
My concern is more that build is broken, yes. Release is now upcoming, we can do just a few changes.
Option number 2 would require more time to implement.
If you like I can resent a v2 of option 1 where the error message is removed.
It is a hack, but we can do just for the release. I have already applied V1, I will drop it from u-boot-imx. I will also apply "imx: syscounter: make sure asm is volatile" as you told me today, and then I send a PR with these two patches to Tom.
Best regards, Stefano
Hi Stefano,
On Fri, Mar 9, 2018 at 8:11 AM, Stefano Babic sbabic@denx.de wrote: If you like I can resent a v2 of option 1 where the error message is removed.
It is a hack, but we can do just for the release. I have already applied V1, I will drop it from u-boot-imx. I will also apply "imx: syscounter: make sure asm is volatile" as you told me today, and then I send a PR with these two patches to Tom.
Sounds good! I have sent a v3 patch.
Thanks
participants (2)
-
Fabio Estevam -
Stefano Babic