[U-Boot-Users] [PATCH] add support for Toradex Colibri module
Hi,
this patch adds basic support for Toradex PXA27x based Colibri module. It cleanly applies on u-boot-1.1.6.
However, I didn't manage to get the flash to work at all, at boot time, I always get the message "Flash: 0 kB". I'm new to the U-Boot environment, so maybe I missed same essentials here.
Also, the DM9000 driver does not seem to be able to correctly read its MAC address on this platform. I've read some mails about similar behaviour. Is there any patch going upstream soon? For now, I helped myself by hacking a fake MAC to bd->bi_enetaddr right before initialization but that's of course not a solution.
Thanks and best regards, Daniel
On 22:38 Fri 30 Nov , Daniel Mack wrote:
Hi,
this patch adds basic support for Toradex PXA27x based Colibri module. It cleanly applies on u-boot-1.1.6.
However, I didn't manage to get the flash to work at all, at boot time, I always get the message "Flash: 0 kB". I'm new to the U-Boot environment, so maybe I missed same essentials here.
Also, the DM9000 driver does not seem to be able to correctly read its MAC address on this platform. I've read some mails about similar behaviour. Is there any patch going upstream soon? For now, I helped myself by hacking a fake MAC to bd->bi_enetaddr right before initialization but that's of course not a solution.
Thanks and best regards, Daniel
Please rebase your code on the last u-boot 1.3.0
Best regards, J.
On Fri, Nov 30, 2007 at 11:09:57PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
Please rebase your code on the last u-boot 1.3.0
Oops, I was trapped by the sourceforge cemetery, sorry. Patch against 1.3.0 is attached.
Best regards, Daniel
MAKEALL | 1 Makefile | 3 board/colibri/Makefile | 51 ++++ board/colibri/colibri.c | 61 +++++ board/colibri/config.mk | 1 board/colibri/lowlevel_init.S | 465 ++++++++++++++++++++++++++++++++++++++++++ board/colibri/pxavoltage.S | 178 ++++++++++++++++ board/colibri/u-boot.lds | 56 +++++ include/asm-arm/mach-types.h | 13 + include/configs/colibri.h | 261 +++++++++++++++++++++++ 10 files changed, 1090 insertions(+)
On Sat, Dec 01, 2007 at 12:13:35AM +0100, Daniel Mack wrote:
Patch against 1.3.0 is attached.
Best regards, Daniel
MAKEALL | 1 Makefile | 3 board/colibri/Makefile | 51 ++++ board/colibri/colibri.c | 61 +++++ board/colibri/config.mk | 1 board/colibri/lowlevel_init.S | 465 ++++++++++++++++++++++++++++++++++++++++++ board/colibri/pxavoltage.S | 178 ++++++++++++++++ board/colibri/u-boot.lds | 56 +++++ include/asm-arm/mach-types.h | 13 + include/configs/colibri.h | 261 +++++++++++++++++++++++ 10 files changed, 1090 insertions(+)
Has this patch been taken?
Greets, Daniel
On Sat, Jan 12, 2008 at 09:27:35AM +0100, Daniel Mack wrote:
On Sat, Dec 01, 2007 at 12:13:35AM +0100, Daniel Mack wrote:
Patch against 1.3.0 is attached.
Has this patch been taken?
Is there anything the maintainers of U-Boot dislike about this patch? Or what is the reason for all my messages being ignored completely? At least some feedback would be pleasant.
Daniel
Dear Daniel,
in message 20080123150644.GA3302@buzzloop.caiaq.de you wrote:
On Sat, Jan 12, 2008 at 09:27:35AM +0100, Daniel Mack wrote:
On Sat, Dec 01, 2007 at 12:13:35AM +0100, Daniel Mack wrote:
Patch against 1.3.0 is attached.
Has this patch been taken?
I did not receive a pull request from the ARM custodian whichincluded this patch. In other words, no, so far not.
Is there anything the maintainers of U-Boot dislike about this patch? Or what is the reason for all my messages being ignored completely? At least some feedback would be pleasant.
I agree, and I apologize. I'm not satisfied with the state of ARM support myself.
Peter, could you please comment on this? Do you have any specific plans for this and a list of other ARM patches?
Best regards,
Wolfgang Denk
Dear Daniel,
in message 20071130231335.GA10869@buzzloop.caiaq.de you wrote:
Patch against 1.3.0 is attached.
Best regards, Daniel
MAKEALL | 1 Makefile | 3 board/colibri/Makefile | 51 ++++ board/colibri/colibri.c | 61 +++++ board/colibri/config.mk | 1 board/colibri/lowlevel_init.S | 465 ++++++++++++++++++++++++++++++++++++++++++ board/colibri/pxavoltage.S | 178 ++++++++++++++++ board/colibri/u-boot.lds | 56 +++++ include/asm-arm/mach-types.h | 13 + include/configs/colibri.h | 261 +++++++++++++++++++++++ 10 files changed, 1090 insertions(+)
There are coding style issues with your patch: trailing white space, C++ comments, indentation not by multiples of 8 characters.
Please clean up and resubmit.
And while you are at it - please keep lists sorted (MAKEALL, Makefile).
Best regards,
Wolfgang Denk
Hi Wolfgang,
thanks for your response.
On Mon, 2008-02-04 at 00:07 +0100, Wolfgang Denk wrote:
There are coding style issues with your patch: trailing white space, C++ comments, indentation not by multiples of 8 characters.
Please clean up and resubmit.
And while you are at it - please keep lists sorted (MAKEALL, Makefile).
Ok, done. New, refurbished patch is attached.
Thanks and best regards, Daniel
In message 1202906813.6976.2.camel@omuntu you wrote:
Ok, done. New, refurbished patch is attached.
Please don't attach, but include inline. Ideally, use git-send-email to send the patch.
Signed-off-by line missing. Please rebase and resubmit.
Best regards,
Wolfgang Denk
participants (3)
-
Daniel Mack -
Jean-Christophe PLAGNIOL-VILLARD -
Wolfgang Denk