[U-Boot] [GIT PULL V2] Please pull u-boot-mmc master
Dear Tom,
Could you pull these patches into u-boot/master? (I have tested the buildman.)
The following changes since commit 22f3368e71321db1e0e15dfbf54b052367890ec7:
Merge branch 'master' of git://git.denx.de/u-boot-mips (2017-05-13 16:45:35 -0400)
are available in the git repository at:
git://git.denx.de/u-boot-mmc.git master
for you to fetch changes up to b3125088a3cc362a21aa3bbd0c0e4e74d74a6f2b:
mmc: atmel_sdhci: Enable the quirk SDHCI_QUIRK_WAIT_SEND_CMD (2017-05-16 06:29:28 +0900)
---------------------------------------------------------------- Jean-Jacques Hiblot (2): include: config: am335x: disable DM_MMC_OPS if DM_MMC is disabled drivers: omap_hsmmc: move to DM_MMC_OPS
Masahiro Yamada (5): mmc: sdhci-cadence: import updates from Linux 4.12 sandbox_noblk_defconfig: disable CONFIG_GENERIC_MMC blanche_defconfig: enable CONFIG_MMC mmc: replace CONFIG_GENERIC_MMC with CONFIG_MMC mmc: descend into drivers/mmc only when CONFIG_MMC is enabled
Wenyou Yang (2): mmc: sdhci: Fix maximum clock for programmable clock mode mmc: atmel_sdhci: Enable the quirk SDHCI_QUIRK_WAIT_SEND_CMD
Makefile | 1 - arch/arm/Kconfig | 2 +- board/BuR/common/common.c | 2 +- board/bosch/shc/board.c | 2 +- board/compulab/cl-som-am57x/cl-som-am57x.c | 4 +- board/compulab/cm_t35/cm_t35.c | 4 +- board/compulab/cm_t3517/cm_t3517.c | 2 +- board/compulab/cm_t54/cm_t54.c | 2 +- board/corscience/tricorder/tricorder.c | 4 +- board/gumstix/duovero/duovero.c | 2 +- board/hisilicon/hikey/hikey.c | 2 +- board/isee/igep00x0/igep00x0.c | 4 +- board/logicpd/am3517evm/am3517evm.c | 2 +- board/logicpd/omap3som/omap3logic.c | 4 +- board/logicpd/zoom1/zoom1.c | 2 +- board/overo/overo.c | 4 +- board/pandora/pandora.c | 2 +- board/quipos/cairo/cairo.c | 2 +- board/samsung/arndale/arndale.c | 2 +- board/samsung/common/board.c | 2 +- board/samsung/common/misc.c | 4 +- board/samsung/goni/goni.c | 2 +- board/samsung/smdkv310/smdkv310.c | 2 +- board/sunxi/board.c | 2 +- board/technexion/tao3530/tao3530.c | 4 +- board/ti/am3517crane/am3517crane.c | 2 +- board/ti/am57xx/board.c | 2 +- board/ti/beagle/beagle.c | 4 +- board/ti/dra7xx/evm.c | 2 +- board/ti/evm/evm.c | 4 +- board/ti/ks2_evm/board_k2g.c | 2 +- board/ti/omap5_uevm/evm.c | 2 +- board/ti/panda/panda.c | 2 +- board/ti/sdp4430/sdp.c | 2 +- board/ti/ti814x/evm.c | 2 +- board/timll/devkit8000/devkit8000.c | 4 +- common/board_r.c | 4 +- common/spl/Kconfig | 4 +- configs/blanche_defconfig | 3 +- configs/sandbox_noblk_defconfig | 1 - drivers/Makefile | 1 + drivers/mmc/Kconfig | 5 +-- drivers/mmc/Makefile | 28 ++++++------- drivers/mmc/atmel_sdhci.c | 4 +- drivers/mmc/davinci_mmc.c | 2 +- drivers/mmc/omap_hsmmc.c | 39 +++++++++++++---- drivers/mmc/sdhci-cadence.c | 67 +++++++++++++++++++++++++----- drivers/mmc/sdhci.c | 18 ++++---- include/configs/am335x_evm.h | 2 + include/configs/am335x_shc.h | 1 + include/configs/chiliboard.h | 1 + 51 files changed, 172 insertions(+), 101 deletions(-)
Best Regards, Jaehoon Chung
On Tue, May 16, 2017 at 06:36:34AM +0900, Jaehoon Chung wrote:
Dear Tom,
Could you pull these patches into u-boot/master? (I have tested the buildman.)
The following changes since commit 22f3368e71321db1e0e15dfbf54b052367890ec7:
Merge branch 'master' of git://git.denx.de/u-boot-mips (2017-05-13 16:45:35 -0400)
are available in the git repository at:
git://git.denx.de/u-boot-mmc.git master
for you to fetch changes up to b3125088a3cc362a21aa3bbd0c0e4e74d74a6f2b:
mmc: atmel_sdhci: Enable the quirk SDHCI_QUIRK_WAIT_SEND_CMD (2017-05-16 06:29:28 +0900)
Applied to u-boot/master, thanks!
I don't know which patch break Rockchip armv7 SoC on latest source code. The SPL works fine, but it hang at some unknown place in U-Boot, I can't get any log event I enable the DEBUG option.
I test with below commit 4125bbc Merge branch 'master' of git://git.denx.de/u-boot-mmc
armv8 work fine, but armv7 not works, I test with rk3288 and another WIP SoC, both of them hangs without any log message.
Any one have any clue?
Thanks, - Kever
Hi Kever,
On Wed, May 17, 2017 at 4:43 PM, Kever Yang kever.yang@rock-chips.com wrote:
I don't know which patch break Rockchip armv7 SoC on latest source code. The SPL works fine, but it hang at some unknown place in U-Boot, I can't get any log event I enable the DEBUG option.
I test with below commit 4125bbc Merge branch 'master' of git://git.denx.de/u-boot-mmc
armv8 work fine, but armv7 not works, I test with rk3288 and another WIP SoC, both of them hangs without any log message.
Any one have any clue?
You can use 'git bisect' to identify which commit breaks the things.
Regards, Bin
Hi Bin,
Thanks for your suggestion, I already find the root cause.
This patch change the image package and lead to all Rockchip SoCs
with BACK_TO_BROM enabled can not work.
https://www.mail-archive.com/u-boot@lists.denx.de/msg245567.html
Is it possible to do verify commits for different platform like kernelci for kernel patches in U-Boot?
Thanks, - Kever On 05/17/2017 05:24 PM, Bin Meng wrote:
Hi Kever,
On Wed, May 17, 2017 at 4:43 PM, Kever Yang kever.yang@rock-chips.com wrote:
I don't know which patch break Rockchip armv7 SoC on latest source code. The SPL works fine, but it hang at some unknown place in U-Boot, I can't get any log event I enable the DEBUG option.
I test with below commit 4125bbc Merge branch 'master' of git://git.denx.de/u-boot-mmc
armv8 work fine, but armv7 not works, I test with rk3288 and another WIP SoC, both of them hangs without any log message.
Any one have any clue?
You can use 'git bisect' to identify which commit breaks the things.
Regards, Bin
+Tom
Hi Kever,
On 17 May 2017 at 03:56, Kever Yang kever.yang@rock-chips.com wrote:
Hi Bin,
Thanks for your suggestion, I already find the root cause.
This patch change the image package and lead to all Rockchip SoCs
with BACK_TO_BROM enabled can not work.
https://www.mail-archive.com/u-boot@lists.denx.de/msg245567.html
Is it possible to do verify commits for different platform like kernelci for kernel patches in U-Boot?
We do use buildman to verify that things build, and that tests pass on sandbox. But specific boards can still become broken.
Tom has something like this set up and uses it to check the boards he has. I encourage you to set up some boards at your facility and do this!
Regards, Simon
Thanks,
- Kever
On 05/17/2017 05:24 PM, Bin Meng wrote:
Hi Kever,
On Wed, May 17, 2017 at 4:43 PM, Kever Yang kever.yang@rock-chips.com wrote:
I don't know which patch break Rockchip armv7 SoC on latest source code. The SPL works fine, but it hang at some unknown place in U-Boot, I can't get any log event I enable the DEBUG option.
I test with below commit 4125bbc Merge branch 'master' of git://git.denx.de/u-boot-mmc
armv8 work fine, but armv7 not works, I test with rk3288 and another WIP SoC, both of them hangs without any log message.
Any one have any clue?
You can use 'git bisect' to identify which commit breaks the things.
Regards, Bin
U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
On Mon, May 22, 2017 at 02:26:21PM -0600, Simon Glass wrote:
+Tom
Hi Kever,
On 17 May 2017 at 03:56, Kever Yang kever.yang@rock-chips.com wrote:
Hi Bin,
Thanks for your suggestion, I already find the root cause.
This patch change the image package and lead to all Rockchip SoCs
with BACK_TO_BROM enabled can not work.
https://www.mail-archive.com/u-boot@lists.denx.de/msg245567.html
Is it possible to do verify commits for different platform like kernelci for kernel patches in U-Boot?
We do use buildman to verify that things build, and that tests pass on sandbox. But specific boards can still become broken.
Tom has something like this set up and uses it to check the boards he has. I encourage you to set up some boards at your facility and do this!
Indeed, it's time for another reminder about both tbot (which Heiko runs and instance of and maintains) and test/py/test.py + https://github.com/swarren/uboot-test-hooks which is what we use to control qemu targets in travis-ci and real hardware in various labs (Stephen has one for tegra and I know there's a few other private setups) including mine. I don't however have any Rockchip targets, but suggestions of a board that would be a good fit for a lab are welcome (ie easy console and recovery from bad builds).
Tom, Simon,
On 05/23/2017 04:38 AM, Tom Rini wrote:
On Mon, May 22, 2017 at 02:26:21PM -0600, Simon Glass wrote:
+Tom
Hi Kever,
On 17 May 2017 at 03:56, Kever Yang kever.yang@rock-chips.com wrote:
Hi Bin,
Thanks for your suggestion, I already find the root cause.
This patch change the image package and lead to all Rockchip SoCs
with BACK_TO_BROM enabled can not work.
https://www.mail-archive.com/u-boot@lists.denx.de/msg245567.html
Is it possible to do verify commits for different platform like kernelci for kernel patches in U-Boot?
We do use buildman to verify that things build, and that tests pass on sandbox. But specific boards can still become broken.
Tom has something like this set up and uses it to check the boards he has. I encourage you to set up some boards at your facility and do this!
Indeed, it's time for another reminder about both tbot (which Heiko runs and instance of and maintains) and test/py/test.py + https://github.com/swarren/uboot-test-hooks which is what we use to control qemu targets in travis-ci and real hardware in various labs (Stephen has one for tegra and I know there's a few other private setups) including mine. I don't however have any Rockchip targets, but suggestions of a board that would be a good fit for a lab are welcome (ie easy console and recovery from bad builds).
I can try to setup one although I have no any experience on this, is there a step by step document I can learn from? For kernel, it can use net boot with TFTP, but for U-Boot/SPL, we need to flash the eMMC or SD card, which make it more complicate and I don't have a solution for automatic test. I may need to verify for different SoCs, for example, I found that the rk3036 build also been broken, the SPL size is too large now(bigger than 4KB), I still don't have time to figure it out.
Thanks, - Kever
On Tue, May 23, 2017 at 04:43:56PM +0800, Kever Yang wrote:
Tom, Simon,
On 05/23/2017 04:38 AM, Tom Rini wrote:
On Mon, May 22, 2017 at 02:26:21PM -0600, Simon Glass wrote:
+Tom
Hi Kever,
On 17 May 2017 at 03:56, Kever Yang kever.yang@rock-chips.com wrote:
Hi Bin,
Thanks for your suggestion, I already find the root cause.
This patch change the image package and lead to all Rockchip SoCs
with BACK_TO_BROM enabled can not work.
https://www.mail-archive.com/u-boot@lists.denx.de/msg245567.html
Is it possible to do verify commits for different platform like kernelci for kernel patches in U-Boot?
We do use buildman to verify that things build, and that tests pass on sandbox. But specific boards can still become broken.
Tom has something like this set up and uses it to check the boards he has. I encourage you to set up some boards at your facility and do this!
Indeed, it's time for another reminder about both tbot (which Heiko runs and instance of and maintains) and test/py/test.py + https://github.com/swarren/uboot-test-hooks which is what we use to control qemu targets in travis-ci and real hardware in various labs (Stephen has one for tegra and I know there's a few other private setups) including mine. I don't however have any Rockchip targets, but suggestions of a board that would be a good fit for a lab are welcome (ie easy console and recovery from bad builds).
I can try to setup one although I have no any experience on this, is there a step by step document I can learn from?
Not exactly, but there's READMEs for it all.
For kernel, it can use net boot with TFTP, but for U-Boot/SPL, we need to flash the eMMC or SD card, which make it more complicate and I don't have a solution for automatic test.
Is there some recovery method via USB or similar? Does the ROM support reading from say FAT? Having to raw-write to an SD card is still a tricky operation, in a recoverable way.
I may need to verify for different SoCs, for example, I found that the rk3036 build also been broken, the SPL size is too large now(bigger than 4KB), I still don't have time to figure it out.
wrt sizes, you need to start using the existing linker script hooks that make this fail to link :)
participants (5)
-
Bin Meng -
Jaehoon Chung -
Kever Yang -
Simon Glass -
Tom Rini