[U-Boot] [PATCH 1/3] arm: kirkwood: dts: Add openrd-* dtb makefile build targets
The following Kirkwood dtb build targets are currently missing:
kirkwood-openrd-base.dtb kirkwood-openrd-client.dtb kirkwood-openrd-ultimate.dtb
This patch adds them to the Makefile to fix the build error.
Signed-off-by: Stefan Roese sr@denx.de Cc: Chris Packham judge.packham@gmail.com --- arch/arm/dts/Makefile | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile index 4f05df1321..f36b801219 100644 --- a/arch/arm/dts/Makefile +++ b/arch/arm/dts/Makefile @@ -56,6 +56,9 @@ dtb-$(CONFIG_KIRKWOOD) += \ kirkwood-ns2lite.dtb \ kirkwood-ns2max.dtb \ kirkwood-ns2mini.dtb \ + kirkwood-openrd-base.dtb \ + kirkwood-openrd-client.dtb \ + kirkwood-openrd-ultimate.dtb \ kirkwood-pogo_e02.dtb \ kirkwood-sheevaplug.dtb
Remove the superfluous CONFIG_ENV_ADDR definition. Its not needed as CONFIG_ENV_OFFSET is also set to the same value.
Signed-off-by: Stefan Roese sr@denx.de Cc: Chris Packham judge.packham@gmail.com --- include/configs/openrd.h | 1 - 1 file changed, 1 deletion(-)
diff --git a/include/configs/openrd.h b/include/configs/openrd.h index 17611bc568..c96d4c4d48 100644 --- a/include/configs/openrd.h +++ b/include/configs/openrd.h @@ -41,7 +41,6 @@ * it has to be rounded to sector size */ #define CONFIG_ENV_SIZE 0x20000 /* 128k */ -#define CONFIG_ENV_ADDR 0x60000 #define CONFIG_ENV_OFFSET 0x60000 /* env starts here */ /* * Environment is right behind U-Boot in flash. Make sure U-Boot
On Thu, 11 Apr 2019, 10:33 PM Stefan Roese, sr@denx.de wrote:
Remove the superfluous CONFIG_ENV_ADDR definition. Its not needed as CONFIG_ENV_OFFSET is also set to the same value.
Signed-off-by: Stefan Roese sr@denx.de Cc: Chris Packham judge.packham@gmail.com
Reviewed-by: Chris Packham judge.packham@gmail.com
include/configs/openrd.h | 1 - 1 file changed, 1 deletion(-)
diff --git a/include/configs/openrd.h b/include/configs/openrd.h index 17611bc568..c96d4c4d48 100644 --- a/include/configs/openrd.h +++ b/include/configs/openrd.h @@ -41,7 +41,6 @@
- it has to be rounded to sector size
*/ #define CONFIG_ENV_SIZE 0x20000 /* 128k */ -#define CONFIG_ENV_ADDR 0x60000 #define CONFIG_ENV_OFFSET 0x60000 /* env starts here */ /*
- Environment is right behind U-Boot in flash. Make sure U-Boot
-- 2.21.0
On 11.04.19 12:33, Stefan Roese wrote:
Remove the superfluous CONFIG_ENV_ADDR definition. Its not needed as CONFIG_ENV_OFFSET is also set to the same value.
Signed-off-by: Stefan Roese sr@denx.de Cc: Chris Packham judge.packham@gmail.com
Applied to u-boot-marvell/master.
Thanks, Stefan
We have run now multiple times into size issues with the openrd board port. To finally fix this, this patch now moves the U-Boot size from 0x6.0000 to 0x8.0000, giving enough space for the next time.
This also changes the environment location and potentially the MTD partitioning, but I see no better fix for now. Especially since this board does not have an active maintainer.
Signed-off-by: Stefan Roese sr@denx.de Cc: Chris Packham judge.packham@gmail.com --- include/configs/openrd.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/configs/openrd.h b/include/configs/openrd.h index c96d4c4d48..62d8862cc7 100644 --- a/include/configs/openrd.h +++ b/include/configs/openrd.h @@ -41,7 +41,7 @@ * it has to be rounded to sector size */ #define CONFIG_ENV_SIZE 0x20000 /* 128k */ -#define CONFIG_ENV_OFFSET 0x60000 /* env starts here */ +#define CONFIG_ENV_OFFSET 0x80000 /* env starts here */ /* * Environment is right behind U-Boot in flash. Make sure U-Boot * doesn't grow into the environment area.
On Thu, 11 Apr 2019, 10:33 PM Stefan Roese, sr@denx.de wrote:
We have run now multiple times into size issues with the openrd board port. To finally fix this, this patch now moves the U-Boot size from 0x6.0000 to 0x8.0000, giving enough space for the next time.
This also changes the environment location and potentially the MTD partitioning, but I see no better fix for now. Especially since this board does not have an active maintainer.
Signed-off-by: Stefan Roese sr@denx.de Cc: Chris Packham judge.packham@gmail.com
One alternative option I looked at was trimming down the dtb to drop the nodes that aren't used in u-boot. This might just get it under the 0x60000 limit ... for a while.
I agree that this is the best approach in leiu of anyone maintiaining the board. Once this is applied the openrd boards can be reenabled in travis.
Reviewed-by: Chris Packham judge.packham@gmail.com
---
include/configs/openrd.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/configs/openrd.h b/include/configs/openrd.h index c96d4c4d48..62d8862cc7 100644 --- a/include/configs/openrd.h +++ b/include/configs/openrd.h @@ -41,7 +41,7 @@
- it has to be rounded to sector size
*/ #define CONFIG_ENV_SIZE 0x20000 /* 128k */ -#define CONFIG_ENV_OFFSET 0x60000 /* env starts here */ +#define CONFIG_ENV_OFFSET 0x80000 /* env starts here */ /*
- Environment is right behind U-Boot in flash. Make sure U-Boot
- doesn't grow into the environment area.
-- 2.21.0
On Fri, Apr 12, 2019 at 07:08:40PM +1200, Chris Packham wrote:
On Thu, 11 Apr 2019, 10:33 PM Stefan Roese, sr@denx.de wrote:
We have run now multiple times into size issues with the openrd board port. To finally fix this, this patch now moves the U-Boot size from 0x6.0000 to 0x8.0000, giving enough space for the next time.
This also changes the environment location and potentially the MTD partitioning, but I see no better fix for now. Especially since this board does not have an active maintainer.
Signed-off-by: Stefan Roese sr@denx.de Cc: Chris Packham judge.packham@gmail.com
One alternative option I looked at was trimming down the dtb to drop the nodes that aren't used in u-boot. This might just get it under the 0x60000 limit ... for a while.
I agree that this is the best approach in leiu of anyone maintiaining the board. Once this is applied the openrd boards can be reenabled in travis.
Reviewed-by: Chris Packham judge.packham@gmail.com
Please note the board is currently orphaned and excluded from travis builds due to the size problem. So if someone is going to address this, I want to see the board un-orphaned too (and travis updated to build it again), thanks!
On Sat, Apr 13, 2019 at 09:00:48AM -0400, Tom Rini wrote:
On Fri, Apr 12, 2019 at 07:08:40PM +1200, Chris Packham wrote:
On Thu, 11 Apr 2019, 10:33 PM Stefan Roese, sr@denx.de wrote:
We have run now multiple times into size issues with the openrd board port. To finally fix this, this patch now moves the U-Boot size from 0x6.0000 to 0x8.0000, giving enough space for the next time.
This also changes the environment location and potentially the MTD partitioning, but I see no better fix for now. Especially since this board does not have an active maintainer.
Signed-off-by: Stefan Roese sr@denx.de Cc: Chris Packham judge.packham@gmail.com
One alternative option I looked at was trimming down the dtb to drop the nodes that aren't used in u-boot. This might just get it under the 0x60000 limit ... for a while.
I agree that this is the best approach in leiu of anyone maintiaining the board. Once this is applied the openrd boards can be reenabled in travis.
Reviewed-by: Chris Packham judge.packham@gmail.com
Please note the board is currently orphaned and excluded from travis builds due to the size problem. So if someone is going to address this, I want to see the board un-orphaned too (and travis updated to build it again), thanks!
Anyone? Thanks!
On 24.04.19 15:21, Tom Rini wrote:
On Sat, Apr 13, 2019 at 09:00:48AM -0400, Tom Rini wrote:
On Fri, Apr 12, 2019 at 07:08:40PM +1200, Chris Packham wrote:
On Thu, 11 Apr 2019, 10:33 PM Stefan Roese, sr@denx.de wrote:
We have run now multiple times into size issues with the openrd board port. To finally fix this, this patch now moves the U-Boot size from 0x6.0000 to 0x8.0000, giving enough space for the next time.
This also changes the environment location and potentially the MTD partitioning, but I see no better fix for now. Especially since this board does not have an active maintainer.
Signed-off-by: Stefan Roese sr@denx.de Cc: Chris Packham judge.packham@gmail.com
One alternative option I looked at was trimming down the dtb to drop the nodes that aren't used in u-boot. This might just get it under the 0x60000 limit ... for a while.
I agree that this is the best approach in leiu of anyone maintiaining the board. Once this is applied the openrd boards can be reenabled in travis.
Reviewed-by: Chris Packham judge.packham@gmail.com
Please note the board is currently orphaned and excluded from travis builds due to the size problem. So if someone is going to address this, I want to see the board un-orphaned too (and travis updated to build it again), thanks!
Anyone? Thanks!
I can add myself as maintainer and add it back to the travis builds. Even though I can only compile test because I don't have access to this board.
Thanks, Stefan
On Wed, Apr 24, 2019 at 03:49:35PM +0200, Stefan Roese wrote:
On 24.04.19 15:21, Tom Rini wrote:
On Sat, Apr 13, 2019 at 09:00:48AM -0400, Tom Rini wrote:
On Fri, Apr 12, 2019 at 07:08:40PM +1200, Chris Packham wrote:
On Thu, 11 Apr 2019, 10:33 PM Stefan Roese, sr@denx.de wrote:
We have run now multiple times into size issues with the openrd board port. To finally fix this, this patch now moves the U-Boot size from 0x6.0000 to 0x8.0000, giving enough space for the next time.
This also changes the environment location and potentially the MTD partitioning, but I see no better fix for now. Especially since this board does not have an active maintainer.
Signed-off-by: Stefan Roese sr@denx.de Cc: Chris Packham judge.packham@gmail.com
One alternative option I looked at was trimming down the dtb to drop the nodes that aren't used in u-boot. This might just get it under the 0x60000 limit ... for a while.
I agree that this is the best approach in leiu of anyone maintiaining the board. Once this is applied the openrd boards can be reenabled in travis.
Reviewed-by: Chris Packham judge.packham@gmail.com
Please note the board is currently orphaned and excluded from travis builds due to the size problem. So if someone is going to address this, I want to see the board un-orphaned too (and travis updated to build it again), thanks!
Anyone? Thanks!
I can add myself as maintainer and add it back to the travis builds. Even though I can only compile test because I don't have access to this board.
OK. Make sure to include updating the travis rules when you update the MAINTAINERS file, thanks!
On 24.04.19 16:13, Tom Rini wrote:
On Wed, Apr 24, 2019 at 03:49:35PM +0200, Stefan Roese wrote:
On 24.04.19 15:21, Tom Rini wrote:
On Sat, Apr 13, 2019 at 09:00:48AM -0400, Tom Rini wrote:
On Fri, Apr 12, 2019 at 07:08:40PM +1200, Chris Packham wrote:
On Thu, 11 Apr 2019, 10:33 PM Stefan Roese, sr@denx.de wrote:
We have run now multiple times into size issues with the openrd board port. To finally fix this, this patch now moves the U-Boot size from 0x6.0000 to 0x8.0000, giving enough space for the next time.
This also changes the environment location and potentially the MTD partitioning, but I see no better fix for now. Especially since this board does not have an active maintainer.
Signed-off-by: Stefan Roese sr@denx.de Cc: Chris Packham judge.packham@gmail.com
One alternative option I looked at was trimming down the dtb to drop the nodes that aren't used in u-boot. This might just get it under the 0x60000 limit ... for a while.
I agree that this is the best approach in leiu of anyone maintiaining the board. Once this is applied the openrd boards can be reenabled in travis.
Reviewed-by: Chris Packham judge.packham@gmail.com
Please note the board is currently orphaned and excluded from travis builds due to the size problem. So if someone is going to address this, I want to see the board un-orphaned too (and travis updated to build it again), thanks!
Anyone? Thanks!
I can add myself as maintainer and add it back to the travis builds. Even though I can only compile test because I don't have access to this board.
OK. Make sure to include updating the travis rules when you update the MAINTAINERS file, thanks!
Yep. I'll send a patch for this once I've pushed this patch here to mainline, which should happen shortly.
Thanks, Stefan
On 11.04.19 12:33, Stefan Roese wrote:
We have run now multiple times into size issues with the openrd board port. To finally fix this, this patch now moves the U-Boot size from 0x6.0000 to 0x8.0000, giving enough space for the next time.
This also changes the environment location and potentially the MTD partitioning, but I see no better fix for now. Especially since this board does not have an active maintainer.
Signed-off-by: Stefan Roese sr@denx.de Cc: Chris Packham judge.packham@gmail.com
Applied to u-boot-marvell/master.
Thanks, Stefan
On Thu, 11 Apr 2019, 10:33 PM Stefan Roese, sr@denx.de wrote:
The following Kirkwood dtb build targets are currently missing:
kirkwood-openrd-base.dtb kirkwood-openrd-client.dtb kirkwood-openrd-ultimate.dtb
This patch adds them to the Makefile to fix the build error.
Signed-off-by: Stefan Roese sr@denx.de Cc: Chris Packham judge.packham@gmail.com
Reviewed-by: Chris Packham judge.packham@gmail.com
arch/arm/dts/Makefile | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile index 4f05df1321..f36b801219 100644 --- a/arch/arm/dts/Makefile +++ b/arch/arm/dts/Makefile @@ -56,6 +56,9 @@ dtb-$(CONFIG_KIRKWOOD) += \ kirkwood-ns2lite.dtb \ kirkwood-ns2max.dtb \ kirkwood-ns2mini.dtb \
kirkwood-openrd-base.dtb \kirkwood-openrd-client.dtb \kirkwood-openrd-ultimate.dtb \ kirkwood-pogo_e02.dtb \ kirkwood-sheevaplug.dtb-- 2.21.0
On 11.04.19 12:33, Stefan Roese wrote:
The following Kirkwood dtb build targets are currently missing:
kirkwood-openrd-base.dtb kirkwood-openrd-client.dtb kirkwood-openrd-ultimate.dtb
This patch adds them to the Makefile to fix the build error.
Signed-off-by: Stefan Roese sr@denx.de Cc: Chris Packham judge.packham@gmail.com
Applied to u-boot-marvell/master.
Thanks, Stefan
participants (3)
-
Chris Packham -
Stefan Roese -
Tom Rini