Re: [U-Boot] Initial environment variables
Ron Madrid wrote:
When I submitted patches for my new board SIMPC8313 I
recall being told that
I had inappropriately initialized some of my
environment variables. Most
specifically I am interested in having default
serverip, ipaddr, and ethaddr
environment variables. Is this most
appropriately done with a specific
#define (such as #define CONFIG_SERVERIP) or within
#define
CONFIG_EXTRA_ENV_SETTINGS?
You can set CONFIGs for all of these things in your own private build and they'll work, but they're inappropriate for main-line U-boot. I hope the reasoning is obvious.
I'm do not understand why and I see in several include/configs/*.h files that these environment variable are being set as default. I'm guessing that there's something that I'm missing.
Ron
On Thursday 16 July 2009 16:46:36 Ron Madrid wrote:
Ron Madrid wrote:
When I submitted patches for my new board SIMPC8313 I recall being told that I had inappropriately initialized some of my environment variables. Most specifically I am interested in having default serverip, ipaddr, and ethaddr environment variables. Is this most appropriately done with a specific #define (such as #define CONFIG_SERVERIP) or within #define CONFIG_EXTRA_ENV_SETTINGS?
You can set CONFIGs for all of these things in your own private build and they'll work, but they're inappropriate for main-line U-boot. I hope the reasoning is obvious.
I'm do not understand why and I see in several include/configs/*.h files that these environment variable are being set as default. I'm guessing that there's something that I'm missing.
the board maintainer decides the default env values, not board users. Ben's comment was probably on the assumption that you are in the latter category. -mike
Dear Mike Frysinger,
In message 200907161656.44300.vapier@gentoo.org you wrote:
I'm do not understand why and I see in several include/configs/*.h files that these environment variable are being set as default. I'm guessing that there's something that I'm missing.
the board maintainer decides the default env values, not board users. Ben's comment was probably on the assumption that you are in the latter category.
That's only the first stage.
After that, the custodian decides what is acceptable for mainline, and after that the project mainainer - ummm, that's me.
And we do not accept any "default network configurations" in mainline.
I'm really fed up by zillions of devices all coming up with the very same MAC address just because the board vendor (1) has no clue and (2) is too stingy to buy a block of MAC addresses.
Best regards,
Wolfgang Denk
On Thursday 16 July 2009 18:21:57 Wolfgang Denk wrote:
Mike Frysinger wrote:
I'm do not understand why and I see in several include/configs/*.h files that these environment variable are being set as default. I'm guessing that there's something that I'm missing.
the board maintainer decides the default env values, not board users. Ben's comment was probably on the assumption that you are in the latter category.
That's only the first stage.
After that, the custodian decides what is acceptable for mainline, and after that the project mainainer - ummm, that's me.
And we do not accept any "default network configurations" in mainline.
I'm really fed up by zillions of devices all coming up with the very same MAC address just because the board vendor (1) has no clue and (2) is too stingy to buy a block of MAC addresses.
we arent talking mac addresses here which i agree -- any default/hardcoding there is wrong -mike
participants (3)
-
Mike Frysinger -
Ron Madrid -
Wolfgang Denk