Missed rename of CONFIG_RAM_RK3399_LPDDR4
Hi,
I think this line: https://source.denx.de/u-boot/u-boot/-/blob/master/drivers/ram/rockchip/sdra... should be
#if defined(CONFIG_RAM_ROCKCHIP_DEBUG) instead of #if defined(CONFIG_RAM_RK3399_LPDDR4)
The condition now evaluates to false on the RockPro64 board in the latest U-Boot version, which I believe is incorrect.
Thanks, David Sebek
+Jagan Teki +Kever Yang
On Thu, 30 Mar 2023 at 15:26, David Sebek dasebek@gmail.com wrote:
Hi,
I think this line: https://source.denx.de/u-boot/u-boot/-/blob/master/drivers/ram/rockchip/sdra... should be
#if defined(CONFIG_RAM_ROCKCHIP_DEBUG) instead of #if defined(CONFIG_RAM_RK3399_LPDDR4)
The condition now evaluates to false on the RockPro64 board in the latest U-Boot version, which I believe is incorrect.
Thanks, David Sebek
Correction: The correct condition should be: #if defined(CONFIG_RAM_ROCKCHIP_LPDDR4)
The constant was renamed from CONFIG_RAM_RK3399_LPDDR4 to CONFIG_RAM_ROCKCHIP_LPDDR4 in commit 26f92be0. I accidentally copy-pasted the wrong value in my previous email.
On Thu, Mar 30, 2023 at 4:14 PM Simon Glass sjg@chromium.org wrote:
+Jagan Teki +Kever Yang
On Thu, 30 Mar 2023 at 15:26, David Sebek dasebek@gmail.com wrote:
Hi,
I think this line:
https://source.denx.de/u-boot/u-boot/-/blob/master/drivers/ram/rockchip/sdra...
should be
#if defined(CONFIG_RAM_ROCKCHIP_DEBUG) instead of #if defined(CONFIG_RAM_RK3399_LPDDR4)
The condition now evaluates to false on the RockPro64 board in the latest U-Boot version, which I believe is incorrect.
Thanks, David Sebek
On Fri, Mar 31, 2023 at 2:13 AM David Sebek dasebek@gmail.com wrote:
Correction: The correct condition should be: #if defined(CONFIG_RAM_ROCKCHIP_LPDDR4)
The constant was renamed from CONFIG_RAM_RK3399_LPDDR4 to CONFIG_RAM_ROCKCHIP_LPDDR4 in commit 26f92be0. I accidentally copy-pasted the wrong value in my previous email.
Please send a patch to mailinglist, if there is any issue.
Thanks, Jagan.
participants (3)
-
David Sebek -
Jagan Teki -
Simon Glass