[U-Boot] PATCH 2/2] Add pci/pcie E1000 ethernet support for MPC8544DS and MPC8536 boards
From: Roy Zang tie-fei.zang@freescale.com
Add pci/pcie E1000 ethernet support for MPC8544DS and MPC8536 boards. Signed-off-by: Roy Zang tie-fei.zang@freescale.com
--- include/configs/MPC8536DS.h | 1 + include/configs/MPC8540ADS.h | 1 + 2 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/include/configs/MPC8536DS.h b/include/configs/MPC8536DS.h index 9e00b89..e23f8f9 100644 --- a/include/configs/MPC8536DS.h +++ b/include/configs/MPC8536DS.h @@ -45,6 +45,7 @@ #define CONFIG_SYS_PCI_64BIT 1 /* enable 64-bit PCI resources */
#define CONFIG_FSL_LAW 1 /* Use common FSL init code */ +#define CONFIG_E1000 1 /* Defind e1000 pci Ethernet card*/
#define CONFIG_TSEC_ENET /* tsec ethernet support */ #define CONFIG_ENV_OVERWRITE diff --git a/include/configs/MPC8540ADS.h b/include/configs/MPC8540ADS.h index 5253611..327b342 100644 --- a/include/configs/MPC8540ADS.h +++ b/include/configs/MPC8540ADS.h @@ -50,6 +50,7 @@ #define CONFIG_TSEC_ENET /* tsec ethernet support */ #define CONFIG_ENV_OVERWRITE #define CONFIG_FSL_LAW 1 /* Use common FSL init code */ +#define CONFIG_E1000 1 /* Defind e1000 pci Ethernet card*/
/* * sysclk for MPC85xx
On Jul 8, 2009, at 3:18 AM, Roy Zang wrote:
From: Roy Zang tie-fei.zang@freescale.com
Add pci/pcie E1000 ethernet support for MPC8544DS and MPC8536 boards. Signed-off-by: Roy Zang tie-fei.zang@freescale.com
include/configs/MPC8536DS.h | 1 + include/configs/MPC8540ADS.h | 1 + 2 files changed, 2 insertions(+), 0 deletions(-)
The comment says MPC8544, the patch is to MPC8540. Which one is correct ? :)
- k
On Wed, 2009-07-08 at 22:32 +0800, Kumar Gala wrote:
On Jul 8, 2009, at 3:18 AM, Roy Zang wrote:
From: Roy Zang tie-fei.zang@freescale.com
Add pci/pcie E1000 ethernet support for MPC8544DS and MPC8536
boards.
Signed-off-by: Roy Zang tie-fei.zang@freescale.com
include/configs/MPC8536DS.h | 1 + include/configs/MPC8540ADS.h | 1 + 2 files changed, 2 insertions(+), 0 deletions(-)
The comment says MPC8544, the patch is to MPC8540. Which one is correct ? :)
It is 8544DS board. Thanks. Sorry for the mistake. It is my oversight when I regenerate the patch before send out. Pick up this one:
From: Roy Zang tie-fei.zang@freescale.com Add pci/pcie E1000 ethernet support for MPC8544DS and MPC8536 boards. Signed-off-by: Roy Zang tie-fei.zang@freescale.com
--- include/configs/MPC8536DS.h | 1 + include/configs/MPC8544DS.h | 1 + 2 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/include/configs/MPC8536DS.h b/include/configs/MPC8536DS.h index 9e00b89..e23f8f9 100644 --- a/include/configs/MPC8536DS.h +++ b/include/configs/MPC8536DS.h @@ -45,6 +45,7 @@ #define CONFIG_SYS_PCI_64BIT 1 /* enable 64-bit PCI resources */
#define CONFIG_FSL_LAW 1 /* Use common FSL init code */ +#define CONFIG_E1000 1 /* Defind e1000 pci Ethernet card*/
#define CONFIG_TSEC_ENET /* tsec ethernet support */ #define CONFIG_ENV_OVERWRITE diff --git a/include/configs/MPC8544DS.h b/include/configs/MPC8544DS.h index 59cfde6..91f337f 100644 --- a/include/configs/MPC8544DS.h +++ b/include/configs/MPC8544DS.h @@ -44,6 +44,7 @@ #define CONFIG_SYS_PCI_64BIT 1 /* enable 64-bit PCI resources */
#define CONFIG_FSL_LAW 1 /* Use common FSL init code */ +#define CONFIG_E1000 1 /* Defind e1000 pci Ethernet card*/
#define CONFIG_TSEC_ENET /* tsec ethernet support */ #define CONFIG_ENV_OVERWRITE
Dear Roy Zang,
In message 1247105148.29920.3.camel@rock.ap.freescale.net you wrote:
Sorry for the mistake. It is my oversight when I regenerate the patch before send out. Pick up this one:
From: Roy Zang tie-fei.zang@freescale.com Add pci/pcie E1000 ethernet support for MPC8544DS and MPC8536 boards. Signed-off-by: Roy Zang tie-fei.zang@freescale.com
Doesn't apply with git-am. Please use git-format-patch to create patches.
Best regards,
Wolfgang Denk
Wolfgang Denk wrote:
Dear Roy Zang,
In message 1247105148.29920.3.camel@rock.ap.freescale.net you wrote:
Sorry for the mistake. It is my oversight when I regenerate the patch before send out. Pick up this one:
From: Roy Zang tie-fei.zang@freescale.com Add pci/pcie E1000 ethernet support for MPC8544DS and MPC8536 boards. Signed-off-by: Roy Zang tie-fei.zang@freescale.com
Doesn't apply with git-am. Please use git-format-patch to create patches.
Best regards,
Wolfgang Denk
Still undergoing review (sorry it's taking so long). Please don't apply yet.
regards, Ben
Dear Ben Warren,
In message 4A5F9A05.70104@gmail.com you wrote:
From: Roy Zang tie-fei.zang@freescale.com Add pci/pcie E1000 ethernet support for MPC8544DS and MPC8536 boards. Signed-off-by: Roy Zang tie-fei.zang@freescale.com
Doesn't apply with git-am. Please use git-format-patch to create patches.
...
Still undergoing review (sorry it's taking so long). Please don't apply yet.
I did not intend to meddle with your business. Just wanted to point out formal deficiencies of the patch.
Best regards,
Wolfgang Denk
-----Original Message----- From: Wolfgang Denk [mailto:wd@denx.de] Sent: Friday, July 17, 2009 6:26 AM To: Ben Warren Cc: Zang Roy-R61911; U-Boot-Denx; Kumar Gala Subject: Re: [U-Boot] PATCH 2/2] Add pci/pcie E1000 ethernet support for MPC8544DS and MPC8536 boards
Dear Ben Warren,
In message 4A5F9A05.70104@gmail.com you wrote:
From: Roy Zang tie-fei.zang@freescale.com Add pci/pcie E1000 ethernet support for MPC8544DS and
MPC8536 boards.
Signed-off-by: Roy Zang tie-fei.zang@freescale.com
Doesn't apply with git-am. Please use git-format-patch to create patches.
...
Still undergoing review (sorry it's taking so long).
Please don't apply
yet.
I did not intend to meddle with your business. Just wanted to point out formal deficiencies of the patch.
I always use git-format-patch to create patches :-(. The issue maybe induced by wrong format when I reply the mail. Anyway, I will resend it . Before that, I'd like to get Ben's feedback. Thanks. Roy
-----Original Message----- From: Ben Warren [mailto:biggerbadderben@gmail.com] Sent: Friday, July 17, 2009 5:22 AM To: Wolfgang Denk Cc: Zang Roy-R61911; U-Boot-Denx; Kumar Gala Subject: Re: [U-Boot] PATCH 2/2] Add pci/pcie E1000 ethernet support for MPC8544DS and MPC8536 boards
Wolfgang Denk wrote:
Dear Roy Zang,
you wrote:
Sorry for the mistake. It is my oversight when I
regenerate the patch
before send out. Pick up this one:
From: Roy Zang tie-fei.zang@freescale.com Add pci/pcie E1000 ethernet support for MPC8544DS and
MPC8536 boards.
Signed-off-by: Roy Zang tie-fei.zang@freescale.com
Doesn't apply with git-am. Please use git-format-patch to create patches.
Best regards,
Wolfgang Denk
Still undergoing review (sorry it's taking so long). Please don't apply yet.
Sorry. It is really long, but I do not see reason to split it :-(. In fact the kernel file is bigger than this one. Thanks. Roy
On Jul 8, 2009, at 9:05 PM, Roy Zang wrote:
correct ? :)
It is 8544DS board. Thanks. Sorry for the mistake. It is my oversight when I regenerate the patch before send out. Pick up this one:
From: Roy Zang tie-fei.zang@freescale.com Add pci/pcie E1000 ethernet support for MPC8544DS and MPC8536 boards. Signed-off-by: Roy Zang tie-fei.zang@freescale.com
include/configs/MPC8536DS.h | 1 + include/configs/MPC8544DS.h | 1 + 2 files changed, 2 insertions(+), 0 deletions(-)
applied
- k
-----Original Message----- From: Kumar Gala [mailto:galak@kernel.crashing.org] Sent: Tuesday, July 21, 2009 22:04 PM To: Zang Roy-R61911 Cc: U-Boot-Denx Subject: Re: PATCH 2/2] Add pci/pcie E1000 ethernet support for MPC8544DS and MPC8536 boards
On Jul 8, 2009, at 9:05 PM, Roy Zang wrote:
correct ? :)
It is 8544DS board. Thanks. Sorry for the mistake. It is my oversight when I regenerate
the patch
before send out. Pick up this one:
From: Roy Zang tie-fei.zang@freescale.com Add pci/pcie E1000 ethernet support for MPC8544DS and MPC8536 boards. Signed-off-by: Roy Zang tie-fei.zang@freescale.com
include/configs/MPC8536DS.h | 1 + include/configs/MPC8544DS.h | 1 + 2 files changed, 2 insertions(+), 0 deletions(-)
Then I will send out the individual e1000 driver update to Ben. Thanks. Roy
participants (5)
-
Ben Warren -
Kumar Gala -
Roy Zang -
Wolfgang Denk -
Zang Roy-R61911