[U-Boot] [PATCH] x86: kconfig: Remove meaningless 'select n'

'select n' selects a constant symbol, which is meaningless and has no effect. Maybe this was meant to be a 'default n', though bool and tristate symbols already implicitly default to n.
Discovered in Kconfiglib (https://github.com/ulfalizer/Kconfiglib), which does more strict checking here:
kconfiglib.KconfigSyntaxError: board/google/Kconfig:34: Couldn't parse ' select n': expected nonconstant symbol
Signed-off-by: Ulf Magnusson ulfalizer@gmail.com --- board/google/Kconfig | 1 - 1 file changed, 1 deletion(-)
diff --git a/board/google/Kconfig b/board/google/Kconfig index e56c026ef6..766db1b449 100644 --- a/board/google/Kconfig +++ b/board/google/Kconfig @@ -31,7 +31,6 @@ config TARGET_CHROMEBOOK_LINK64
config TARGET_CHROMEBOX_PANTHER bool "Chromebox panther (not available)" - select n help Note: At present this must be used with coreboot. See README.x86 for instructions.

On Tue, Jan 30, 2018 at 8:59 PM, Ulf Magnusson ulfalizer@gmail.com wrote:
'select n' selects a constant symbol, which is meaningless and has no effect. Maybe this was meant to be a 'default n', though bool and tristate symbols already implicitly default to n.
Discovered in Kconfiglib (https://github.com/ulfalizer/Kconfiglib), which does more strict checking here:
kconfiglib.KconfigSyntaxError: board/google/Kconfig:34: Couldn't parse ' select n': expected nonconstant symbol
Signed-off-by: Ulf Magnusson ulfalizer@gmail.com
board/google/Kconfig | 1 - 1 file changed, 1 deletion(-)
Reviewed-by: Bin Meng bmeng.cn@gmail.com

On Tue, Jan 30, 2018 at 9:04 PM, Bin Meng bmeng.cn@gmail.com wrote:
On Tue, Jan 30, 2018 at 8:59 PM, Ulf Magnusson ulfalizer@gmail.com wrote:
'select n' selects a constant symbol, which is meaningless and has no effect. Maybe this was meant to be a 'default n', though bool and tristate symbols already implicitly default to n.
Discovered in Kconfiglib (https://github.com/ulfalizer/Kconfiglib), which does more strict checking here:
kconfiglib.KconfigSyntaxError: board/google/Kconfig:34: Couldn't parse ' select n': expected nonconstant symbol
Signed-off-by: Ulf Magnusson ulfalizer@gmail.com
board/google/Kconfig | 1 - 1 file changed, 1 deletion(-)
Reviewed-by: Bin Meng bmeng.cn@gmail.com
applied to u-boot-x86, thanks!
participants (2)
-
Bin Meng
-
Ulf Magnusson